From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id D53443858D1E for ; Wed, 20 Sep 2023 17:00:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D53443858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=undo.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=undo.io Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-307d20548adso41934f8f.0 for ; Wed, 20 Sep 2023 10:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undo.io; s=google2; t=1695229234; x=1695834034; darn=sourceware.org; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=IsnOIpaw2PMTJDUxRCtxEuuYriSTBHvhSbVev+oqgnQ=; b=C9QTgXZMcOFMb4vthoxI/4URSaD+JhAHI7Pqhdok1Yhlp9smGqClTF/YOpO/HNMhgp /Qwi7DZaMoWStLrwAmCVS3cGPLOLlaYPa/gTcH5geM/Iej7Dt1f1TDHj2+zUTjBKXMnl tqyJHVKpL0cTVPMXMLyqaBJvEc251jVSatdTGeubzxBXpUTZdg5ywak8Msiqez1ahWCW o06qn13/SEygKfv5WeITbxkB6YXEM+M/0SMUw9ZxPiDQqGT0rYRHaHrjsBm0IoLqGPlc e8fEWYNZMyZVwtN/Dk4wZYRuShn4L3qQq+RyREHyLIt5vwQxV4hBAfJrQfIaEr5xCAGo +WYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695229234; x=1695834034; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IsnOIpaw2PMTJDUxRCtxEuuYriSTBHvhSbVev+oqgnQ=; b=A1Ruwz0n/F4l1wO10uwyJ3LpUDJWF39RjimeCcHNaHjuFE+1nsUlbTYqfhH6nZPk4h RVVyJc8hV7H48AreL5Ystg89Vfg0CuM1oNlYAB3Sgc6VUR5vfWZK7EX8j81DuFipMFC3 dJkyrkWvGOrh32YA5aqmhB8/2trI9ZLiCTQK7NOoVfk55Zqe6JvvK+8xIUd7m3Dsv26M /ZLqworS8tpHQfPTX5oFXhib5ndwLVcJuk4O6VO1jUA2TKurNiVQee6W1Ar+u4Q/A84T ZjRddQ41OSIEwbo04/1q3bsHirkPTM6n5LJ0sYdyKbNs8tguFBQUs5DlhinIi0oUN3/7 Fdxw== X-Gm-Message-State: AOJu0Yyh//rv9ZFgjXV/NOrOL3AWz9EhevSxR9Gpd4RDXrV22LHbmpts JIYm2fJ6UuMRN+p9dudBvk2xZTnB8ke9um/2ZJhMKTovwFXuoxl7KWsrnsAjDDoU1gu+S/VDd9R 9FRv8c11VUMs4ZjSfjjCGVfWFDmiMdpQppuS46kFZ63Ye8vtIB7CHSfWODIGCl8jowNJBRXs= X-Google-Smtp-Source: AGHT+IE0nwXbYyiY5zTdCDptdy3staCXUrboHiXTn4UGBBNJc3D1fH0zPk37rzQPLc0UgvxmWnab1Q== X-Received: by 2002:adf:fac3:0:b0:309:1532:8287 with SMTP id a3-20020adffac3000000b0030915328287mr2979222wrs.19.1695229234209; Wed, 20 Sep 2023 10:00:34 -0700 (PDT) Received: from sbrinz-thinkpad (nrwh-14-b2-v4wan-164712-cust797.vm23.cable.virginm.net. [86.15.219.30]) by smtp.gmail.com with ESMTPSA id i10-20020a5d558a000000b003141e629cb6sm18910860wrv.101.2023.09.20.10.00.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 10:00:33 -0700 (PDT) From: Magne Hov To: Pedro Alves , Tom Tromey , Magne Hov via Gdb-patches Subject: Re: [PATCH v2 1/2] gdb: keep record of thread numbers for reverse execution targets In-Reply-To: References: <20230629083651.3145268-1-mhov@undo.io> <20230707162451.3605544-1-mhov@undo.io> <20230707162451.3605544-2-mhov@undo.io> <871qeu86nm.fsf@tromey.com> Date: Wed, 20 Sep 2023 18:00:32 +0100 Message-ID: <5spm2c230v.fsf@undo.io> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 20 2023, Pedro Alves wrote: > On 2023-09-19 17:33, Tom Tromey wrote: >>>>>>> "Magne" == Magne Hov via Gdb-patches writes: >> >> Magne> Targets that support reverse execution may report threads that have >> Magne> previously been seen to exit. Currently, GDB assigns a new thread >> Magne> number every time it sees the same thread (re)appearing, but this is >> Magne> problematic because it makes the output of `info threads` inconsistent, >> Magne> and because thread-specific breakpoints depend on stable thread-numbers >> Magne> in order to stop on the right thread. >> >> Thank you for the patch. >> >> Magne> + std::unordered_map, hash_ptid> ptid_thread_num_map; >> >> You'll have to update this for the hash_ptid -> std::hash >> change. However, that's trivial. > > I think I have some concerns. Could you hold off a bit? No worries, I'll hold off until you've had time to have a look. > > Sorry I've not managed to stay on top of patch as I'd wish I would. > -- Magne Hov | Software Engineer | Direct: +44 7395 395 648 | mhov@undo.io Undo | Record. Replay. Resolve