From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>, Hannes Domani <ssbssa@yahoo.de>,
Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: "next" into line longer than the source window-width (Re: [RFC 8.3 0/3] Some style fixes)
Date: Thu, 14 Mar 2019 20:25:00 -0000 [thread overview]
Message-ID: <6035325c-bb76-fe7f-5688-8c78a8b89a1a@redhat.com> (raw)
In-Reply-To: <83lg1i3hkj.fsf@gnu.org>
On 03/13/2019 03:44 PM, Eli Zaretskii wrote:
> I also found another regression in the TUI configuration: if you step
> with, say, "next" through the program, and execution winds up on a
> line that is longer than the source window-width, then the current
> line gets redrawn in reverse video, and as result it overwrites the
> window-frame and a portion of the next source line. This happens
> because we only update one source line, and we do that in a way that
> doesn't take the window width and horizontal scrolling offset into
> account.
>
> Here's the patch that fixes this regression:
>
> --- gdb/tui/tui-winsource.c~5 2019-03-12 16:51:50.000000000 +0200
> +++ gdb/tui/tui-winsource.c 2019-03-13 08:21:02.303443600 +0200
> @@ -382,12 +387,30 @@ tui_set_is_exec_point_at (struct tui_lin
> {
> changed++;
> content[i]->which_element.source.is_exec_point = new_state;
> - tui_show_source_line (win_info, i + 1);
> }
> i++;
> }
> if (changed)
> - tui_refresh_win (&win_info->generic);
> + {
> + struct gdbarch *gdbarch = win_info->detail.source_info.gdbarch;
> + struct symtab *s = NULL;
> +
> + if (win_info->generic.type == SRC_WIN)
> + {
> + struct symtab_and_line cursal
> + = get_current_source_symtab_and_line ();
> +
> + if (cursal.symtab == NULL)
> + s = find_pc_line_symtab (get_frame_pc (get_selected_frame (NULL)));
> + else
> + s = cursal.symtab;
> + }
> + tui_update_source_window_as_is (win_info, gdbarch, s,
> + win_info->generic.content[0]
> + ->which_element.source.line_or_addr,
> + FALSE);
> + tui_refresh_win (&win_info->generic);
> + }
The substance of the patch LGTM.
But all this code above looks very much like the new tui_refill_source_window
function, added today by 6f11e6824e15. I think you can replace all
the above with:
- tui_refresh_win (&win_info->generic);
+ tui_refill_source_window (win_info);
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-03-14 20:25 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 21:04 [RFC 8.3 0/3] Some style fixes Tom Tromey
2019-03-08 21:04 ` [RFC 8.3 3/3] Avoid a crash in source_cache::extract_lines Tom Tromey
2019-03-13 17:07 ` Pedro Alves
2019-03-13 17:20 ` Tom Tromey
2019-03-13 18:06 ` Pedro Alves
2019-03-14 11:37 ` Tom Tromey
2019-03-08 21:04 ` [RFC 8.3 2/3] Add the "set style source" command Tom Tromey
2019-03-09 6:17 ` Eli Zaretskii
2019-03-11 20:13 ` Tom Tromey
2019-03-09 11:18 ` Philippe Waroquiers
2019-03-11 20:13 ` Tom Tromey
2019-03-11 20:25 ` Eli Zaretskii
2019-03-08 21:04 ` [RFC 8.3 1/3] Make TUI react to "set style enabled" Tom Tromey
2019-03-13 19:28 ` Pedro Alves
2019-03-14 11:43 ` Tom Tromey
2019-03-09 6:17 ` [RFC 8.3 0/3] Some style fixes Eli Zaretskii
2019-03-10 13:14 ` Eli Zaretskii
2019-03-11 20:15 ` Tom Tromey
2019-03-12 16:44 ` Eli Zaretskii
2019-03-13 15:50 ` Eli Zaretskii
2019-03-14 12:21 ` Tom Tromey
2019-03-14 14:40 ` Pedro Alves
2019-03-14 15:36 ` Eli Zaretskii
2019-03-15 12:34 ` Fix pressing down in the TUI (Re: [RFC 8.3 0/3] Some style fixes) Pedro Alves
2019-03-15 13:37 ` Eli Zaretskii
2019-03-15 13:56 ` Pedro Alves
2019-03-16 17:59 ` Eli Zaretskii
2019-03-24 15:35 ` Simon Marchi
2019-03-25 1:36 ` Simon Marchi
2019-03-25 15:14 ` Tom Tromey
2019-03-26 0:52 ` Simon Marchi
2019-03-15 15:33 ` Tom Tromey
2019-03-15 12:43 ` Avoid overwriting the TUI source window frame " Pedro Alves
2019-03-16 12:17 ` Eli Zaretskii
2019-03-15 14:15 ` [PATCH v2] Fix first time you type UP or DOWN in TUI's command window " Pedro Alves
2019-03-15 15:38 ` Eli Zaretskii
2019-03-18 20:24 ` Pedro Alves
2019-03-19 6:09 ` Eli Zaretskii
2019-03-19 18:14 ` Pedro Alves
2019-03-09 14:28 ` [RFC 8.3 0/3] Some style fixes Hannes Domani via gdb-patches
2019-03-12 16:48 ` Tom Tromey
2019-03-12 17:09 ` Hannes Domani via gdb-patches
2019-03-13 15:44 ` Eli Zaretskii
2019-03-14 20:25 ` Pedro Alves [this message]
2019-03-17 16:05 ` "next" into line longer than the source window-width (Re: [RFC 8.3 0/3] Some style fixes) Eli Zaretskii
2019-03-14 20:58 ` [PATCH] Fix scrolling right in the TUI " Pedro Alves
2019-03-15 12:34 ` Hannes Domani via gdb-patches
2019-03-15 21:51 ` Tom Tromey
2019-03-18 14:41 ` Pedro Alves
2019-03-17 16:06 ` Eli Zaretskii
2019-03-12 17:29 ` [RFC 8.3 0/3] Some style fixes Eli Zaretskii
2019-03-12 17:29 ` Eli Zaretskii
2019-03-12 17:32 ` Eli Zaretskii
2019-03-26 20:52 ` Pedro Franco de Carvalho
2019-03-14 11:44 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6035325c-bb76-fe7f-5688-8c78a8b89a1a@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).