From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60648 invoked by alias); 22 May 2018 03:06:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60632 invoked by uid 89); 22 May 2018 03:06:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:617 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 May 2018 03:06:21 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7C1401EF62; Mon, 21 May 2018 23:06:19 -0400 (EDT) Subject: Re: [PATCH 09/10] remote: Make vcont_builder a class To: Pedro Alves , gdb-patches@sourceware.org References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-10-palves@redhat.com> From: Simon Marchi Message-ID: <603566f0-e2f8-236c-7593-ea86943d49f0@simark.ca> Date: Tue, 22 May 2018 05:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180516141830.16859-10-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00521.txt.bz2 On 2018-05-16 10:18 AM, Pedro Alves wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * remote.c (vcont_builder): Now a class. Make all data members > private. > (vcont_builder) : > Declare methods. > (vcont_builder_restart): Rename to ... > (vcont_builder::restart): ... this. > (vcont_builder_flush): Rename to ... > (vcont_builder::flush): ... this. > (vcont_builder_push_action): Rename to ... > (vcont_builder::push_action): ... this. > (remote_target::commit_resume): Adjust. LGTM. Simon