From: Simon Marchi <simark@simark.ca>
To: Jan Vrany <jan.vrany@fit.cvut.cz>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] Fix segfault when invoking -var-info-path-expression on a dynamic varobj
Date: Mon, 02 Jul 2018 02:04:00 -0000 [thread overview]
Message-ID: <60370429-7eca-0600-dc41-06b5a9365560@simark.ca> (raw)
In-Reply-To: <57e1cd0c-c9bc-896f-16a7-daa89e916079@simark.ca>
On 2018-07-01 09:43 PM, Simon Marchi wrote:
>> diff --git a/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py b/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py
>> new file mode 100644
>> index 0000000000..34d016fb89
>> --- /dev/null
>> +++ b/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py
>> @@ -0,0 +1,57 @@
>> +# Copyright (C) 2008-2018 Free Software Foundation, Inc.
>> +
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 3 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
>> +
>> +import sys
>> +import gdb
>> +import gdb.types
>> +
>> +# Folowing is for Python 3 compatibility...
>
> "Following"
>
> There's an extra \n at the end of py-mi-var-info-path-expression.exp, which git
> complains about.
Actually, it might be the lack of \n at the end of py-mi-var-info-path-expression.py,
please check that too.
Simon
prev parent reply other threads:[~2018-07-02 2:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 20:54 Jan Vrany
2018-07-02 1:43 ` Simon Marchi
2018-07-02 2:04 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60370429-7eca-0600-dc41-06b5a9365560@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@fit.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).