From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=yPKF=4M=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id CDB33385B52F
	for <gdb-patches@sourceware.org>; Wed, 14 Dec 2022 16:01:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CDB33385B52F
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [10.0.0.11] (unknown [217.28.27.60])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 369D91E112;
	Wed, 14 Dec 2022 11:01:03 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1671033663; bh=3lvxaaHgJqsJVMVR2tocVWo6qDWHww7k2BKsHazRSq0=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=X98a3sCLG8aQkezNyhCZGXMk3pJ30knbnykqfXJlTnodups7CJYE1TNNF8xWnQxoE
	 YxRR3m7aJEcO03CQdckFsBLOMe2TjVxH0cKewM3FA9ggdk8xG8/Dh5Mgnv2lVTdlN1
	 7W7giWgXhO5+NRGSUo6SEhdAKYF1IhUDa4opITaM=
Message-ID: <603b56b4-5983-832d-89ad-7e1f7669065c@simark.ca>
Date: Wed, 14 Dec 2022 11:01:02 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] gdb: fix command lookup in execute_command () commands"
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>,
 Jan Vrany via Gdb-patches <gdb-patches@sourceware.org>
Cc: Jan Vrany <jan.vrany@labware.com>, luis.machado@arm.com
References: <4dc13e01-2fd8-a63e-24f2-a1f7c7650d3b@simark.ca>
 <20221214110747.1150349-1-jan.vrany@labware.com> <87lenadlhr.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <87lenadlhr.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>



On 12/14/22 10:59, Tom Tromey wrote:
> Simon> Here are the unexpected failures I saw:
> 
> [...]
> 
> Jan> Hmm. I do not see these failures.
> 
> I applied the patch and ran the full test suite.  I'm on x86-64 Fedora 34.
> 
> I see two new FAILs but they are in thread tests and so I assume they
> are just the usual kind of racy test thing.
> 
> I didn't see any of the failures that Simon reports.
> 
> So, from my perspective your proposed patch seems fine.  I don't think
> we need to back out the previous patch.
> 
> Simon, could you maybe double-check your results somehow?  Or pick one
> of the failures and try to see why it's happening?
> 
> thanks,
> Tom

Do you have ASan enabled in that build?

Simon