From: Simon Marchi <simon.marchi@polymtl.ca>
To: John Darrington <john@darrington.wattle.id.au>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] gdb: Added builtin types for 24 bit integers.
Date: Thu, 23 Aug 2018 20:35:00 -0000 [thread overview]
Message-ID: <603c98bc68bec04acb84d809c838abb0@polymtl.ca> (raw)
In-Reply-To: <20180823200349.gxeuad3ms3c2apei@jocasta.intra>
On 2018-08-23 16:03, John Darrington wrote:
> On Thu, Aug 23, 2018 at 03:41:11PM -0400, Simon Marchi wrote:
>
> Hi John,
>
> It's always useful to have a little commit message along with the
> patch
> to explain why this is needed. What's your problem and how does
> it help
> you solve it. Could you expand a bit on your patches?
>
> Thanks,
>
> Hi Simon,
>
> Sorry, I had presumed it was self evident from the final patch, which
> adds support for the S12Z target - a 24 bit architecture.
Well this is new information to me :).
It is clear now, but somebody doing a git blame to know why 24-bit
integer types were added would only find the patch that adds them by
itself and wonder who uses that. A little message like
This patch adds 24-bit integer types, used when debugging on the S12Z
architecture (added by a later patch in this series).
clears that up. That might looks a bit silly, but I think it helps in
the long run.
> It seems that up till now there has been no 24 bit targets, so the
> other
> two patches as some necessary things to make that possible.
Thanks. Coming back to the code of the patch, I was wondering if these
24-bit types are useful or even relevant for any other architecture.
Would it work if you only defined the types for s12z architectures,
storing the reference in the gdbarch_tdep object?
Simon
next prev parent reply other threads:[~2018-08-23 20:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 17:35 John Darrington
2018-08-23 17:35 ` [PATCH 3/3] GDB: New target s12z John Darrington
2018-08-23 17:56 ` Eli Zaretskii
2018-08-26 17:19 ` Simon Marchi
2018-08-26 17:41 ` John Darrington
2018-08-26 18:16 ` Simon Marchi
2018-08-26 22:55 ` Simon Marchi
2018-08-27 6:30 ` John Darrington
2018-08-27 12:54 ` Simon Marchi
2018-08-28 15:35 ` Tom Tromey
2018-08-23 17:35 ` [PATCH 2/3] GDB: Add support for 24 bit addresses John Darrington
2018-08-24 20:34 ` Simon Marchi
2018-08-25 4:56 ` John Darrington
2018-08-23 17:55 ` [PATCH 1/3] gdb: Added builtin types for 24 bit integers Eli Zaretskii
2018-08-23 19:41 ` Simon Marchi
2018-08-23 20:04 ` John Darrington
2018-08-23 20:35 ` Simon Marchi [this message]
2018-08-24 6:11 ` John Darrington
2018-08-24 15:09 ` Simon Marchi
2018-08-24 15:29 ` John Darrington
2018-08-24 20:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603c98bc68bec04acb84d809c838abb0@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).