From: Vlad Ivanov <vlad.ivanov@lab-systems.ru>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: "schwab@suse.de" <schwab@suse.de>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdbarch: Add pc_signed field and use it when adjusting BP addresses
Date: Thu, 15 Mar 2018 13:10:00 -0000 [thread overview]
Message-ID: <604111521119420@web34o.yandex.ru> (raw)
In-Reply-To: <20180315125901.CE510D804A7@oc3748833570.ibm.com>
15.03.2018, 15:59, "Ulrich Weigand" <uweigand@de.ibm.com>:
> If the address is already correct, why don't you simply set
> gdbarch_significant_addr_bit
> to 64 in the mips back-end instead of adding a new gdbarch routine?
That would affect address printing. Moreover, semantically it's
probably not a good practice because the code would imply that for
all kind of MIPS all 64 bits of address are significant, whereas
in reality it differs from target to target.
Regards,
Vlad
next prev parent reply other threads:[~2018-03-15 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 11:22 vlad.ivanov
2018-03-15 11:34 ` Andreas Schwab
2018-03-15 11:36 ` Vlad Ivanov
2018-03-15 12:59 ` Ulrich Weigand
2018-03-15 13:10 ` Vlad Ivanov [this message]
2018-03-15 14:06 ` Ulrich Weigand
2018-03-15 14:23 ` Vlad Ivanov
2018-03-19 14:14 ` Maciej W. Rozycki
2018-03-19 14:29 ` Ulrich Weigand
2018-03-15 13:46 ` Andreas Schwab
2018-03-15 13:56 ` Vlad Ivanov
2018-03-15 11:43 ` Vlad Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604111521119420@web34o.yandex.ru \
--to=vlad.ivanov@lab-systems.ru \
--cc=gdb-patches@sourceware.org \
--cc=schwab@suse.de \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).