From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DE7E23858001 for ; Wed, 26 May 2021 02:49:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE7E23858001 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14Q2ngVV031635 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 May 2021 22:49:47 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14Q2ngVV031635 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9FC9C1E01F; Tue, 25 May 2021 22:49:42 -0400 (EDT) Subject: Re: [PATCH 0/4] gdb, btrace: infrun fixes To: Markus Metzger , gdb-patches@sourceware.org References: <20210316093501.936148-1-markus.t.metzger@intel.com> From: Simon Marchi Message-ID: <60553bb0-c1cf-36df-94d3-c43c6f5c29db@polymtl.ca> Date: Tue, 25 May 2021 22:49:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210316093501.936148-1-markus.t.metzger@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 26 May 2021 02:49:42 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 02:49:54 -0000 On 2021-03-16 5:34 a.m., Markus Metzger via Gdb-patches wrote: > This small patch series fixes a few issues around reverse/replay stepping that > result in hangs. > > Tested with record btrace on IA. > > Markus Metzger (4): > gdb, infrun, btrace: fix reverse/replay stepping at end of execution > history > gdb, infrun, record: fix hang when step-over fails with no-history > gdb, infrun, record: move no-history notification into normal_stop > gdb, infrun: fix multi-threaded reverse stepping > > gdb/gdbthread.h | 7 ++ > gdb/infrun.c | 87 +++++++++++---- > gdb/record-btrace.c | 19 ++-- > gdb/testsuite/gdb.btrace/cont-hang.exp | 47 ++++++++ > .../gdb.btrace/implicit-stop-replaying.exp | 105 ++++++++++++++++++ > .../gdb.btrace/multi-thread-break-hang.exp | 92 +++++++++++++++ > gdb/testsuite/gdb.btrace/step-hang.exp | 46 ++++++++ > gdb/testsuite/gdb.btrace/stepn.exp | 56 ++++++++++ > 8 files changed, 430 insertions(+), 29 deletions(-) > create mode 100644 gdb/testsuite/gdb.btrace/cont-hang.exp > create mode 100644 gdb/testsuite/gdb.btrace/implicit-stop-replaying.exp > create mode 100644 gdb/testsuite/gdb.btrace/multi-thread-break-hang.exp > create mode 100644 gdb/testsuite/gdb.btrace/step-hang.exp > create mode 100644 gdb/testsuite/gdb.btrace/stepn.exp > I went through the patches. I know next to nothing about the reverse execution mechanism, and don't really have time these days to get up to speed to understand the problems and associated fixes, so I hope that someone more qualified can take a look and approve (although I know that this area has not been touched by many people, so I don't know who that would be). All I can say is that the tests look well written and adequately commented, such that if I ever had to debug them, I would be able to understand the original intentions. Simon