From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67]) by sourceware.org (Postfix) with ESMTPS id 643613857C62 for ; Thu, 4 Nov 2021 16:27:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 643613857C62 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bfGXZR2pNHYVYO7PVJeoTrCiObofUjYFKtoujtKSkmVcSohUfzmOL5G02Bs9p8Q031OeRAL9K3TJ4JLPn360kv0lYgCf8WROtgpmjpoMRlquj5b/o1ZeX7c3cdXckbWVv1k5+VwWU3KnoH28r/xyUxMo8FS92C3v3R/kZ9BjhIp2LEJ1UXrWp0UzfdJVutRmdb9g0ypORfm+KCIGs8y7jvYiRA1qC4+mIqvLexiq/Nx5WVvSyIVsB5oIb2ovyyYnXXSGqQJgDhJi1ohh33TmNcgsELUJ8A7k6r3Laqz+NBFxdU72KCBlQAb0RaRnb4FbofrDYPwhgdGofywwFy/cnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5cvh88Sm+ojtqpvJjn5lbdYCUxyUpCo8HgS7YxIiufI=; b=gukYjhGsW3Ld6Ixdc443Esy513nHBhV9FLSpEu6DJ0uIEifxJhhJeqPPT+dHnzc1gvKEHvW7Wg61x9S1SplWtoympzcjl22m5JGwz1nsL+2KSOF41kmGeKAvH04F7TJ2Ke1eN0XrxfCAhoZzbW1Cjt8nazEfZBG8Tfxr54AQVbB8MPyLCLgn8doA0CM/GgOY1ElV3q2FqCATu0a5zterfIiGuzWgCsnfB/9OC08+JMqEHap2ydfKnaDg8CoUCoUI8pZWPONGLHwKt2sqzXfrjpNft9V719Oiv6tx5raLuebTXIjfzXcnoUcgseNHGPXTcfp8mt2DE9vjg/ewM/lRtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5307.namprd12.prod.outlook.com (2603:10b6:408:104::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 16:27:02 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35%5]) with mapi id 15.20.4649.021; Thu, 4 Nov 2021 16:27:02 +0000 Subject: Re: [PATCH v3 27/28] Add DW_OP_LLVM_extend DWARF operation To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20211014093235.69756-1-zoran.zaric@amd.com> <20211014093235.69756-28-zoran.zaric@amd.com> <20211101214855.2rgdzus44rp6kpiu@ubuntu.lan> From: Zoran Zaric Message-ID: <60958674-158d-9a5e-07ba-7fc65275f14f@amd.com> Date: Thu, 4 Nov 2021 16:26:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20211101214855.2rgdzus44rp6kpiu@ubuntu.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0448.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::28) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 Received: from [IPv6:2a00:23c7:1093:6301:5176:73b0:d1d0:121d] (2a00:23c7:1093:6301:5176:73b0:d1d0:121d) by LO2P265CA0448.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Thu, 4 Nov 2021 16:27:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d5ea934-81a4-4630-55c3-08d99fafee4d X-MS-TrafficTypeDiagnostic: BN9PR12MB5307: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wx2a5PwXLnRSsCcMOnuv3Qy50HARfFk6DybF9gAuRX7d4faYA83N0XulpvdCKWeVUuZyiSiPh9iuot0kn4fVJtV7isLekDrwPwlIRFha5PrGs+OKcIYZFawMPsm3ASUNAN18MqnXCFPXlH7TS6UktKjH7qRMoER7c9/1xYekAxzdAPPZUjzlrpXtr93GHAsh0vhxh6ePf0Lh/sT8m7Zb5jkj1Xy7mrejGINdZO9UJ07Yd4yzuJLjwJ46da4udx8pfMvupwyDbpmQ8ixWrKAs52nPoruqcP7oOgqZ1+7923QCvdAEUbCZEs71rnfDqw4SxDkKb7s7+d9yKH5emXJskyzVXQFz5/FnPVMktY41ItLJ39nSZIC4MGpQ4mTNK6vMwJG8TPu5yjRSh4rU3rdWlGyFsu/FYgrVCJ/7tYMOiR2BPpNC0u611Ic9wMG7wUEx10X4qVprE+NpFDWijRdSzvyV23s7EyFOaXEV8HXrtPO/brEmVwp0/L2BOuBixpUQqM5XmIof9Q8ZTwl1RRe33b3GoeEH0nUvDLythkGqL850yzlEkjRQWQd7Za5eQeQEdUPecEIbc6ZLYQYKrMpfX/MK3JK6y2w+162WTUz+EXxTQ9TfpX7oHiXq7XkglX4/seh0KTm7C89w+vIyosvNziKWI58UvMbcFRYbgsBhcyJwEbvUcPH5bqTEn4/uPoV7bIjYBKvTCT9g6w3CFuBYgFlwWuB2MS8FR6ioMpWyfLNGhrcLIXTmU34uQM2hiw1T X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31696002)(8936002)(6486002)(44832011)(8676002)(53546011)(66556008)(2616005)(66946007)(66476007)(2906002)(316002)(36756003)(4326008)(31686004)(86362001)(186003)(508600001)(6666004)(6916009)(5660300002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MElLVVlnc3RHdUR6ZVRaU0F3L2NFT2xON0ZiOEFzQlpPWksxa0tEVVd6WU02?= =?utf-8?B?MEVXR0plaWFIQkdiMGxXc1VNRXlsZ2NTNXY0T2FqMlhFZEh1bHZYd1ZHWDA0?= =?utf-8?B?cHlsR3l0Y1JnRnJ6TFlrQm5JUTgrc29yZGllS2tib2JoenFSbFVvN1pQdzVT?= =?utf-8?B?Q3Y3WXo2aXRvWEpOdnV1OS8zK1ZJT2xBZXJJdm1xb2owUU9McHNRMXNpNDMz?= =?utf-8?B?ckRWUTdidnVQWlNNdHhEVEJORE9na3k4NE9VNXN3c0k0NnZsUk8wa2IvdlpS?= =?utf-8?B?MlIyM0hwMHNQSXpRbExXNFQvcmh5eDBGMXd2dmJxUGl0UWV5MlI5WWJkTlgx?= =?utf-8?B?eGM1QTMwc1IyaDdlcVlpRFdidjBmWW5jcGxaKzh4TDI1c2JoaGlVRFNXZ3R6?= =?utf-8?B?enBZYW9obllBRVdPTm1JWmtZOGV5RmNOUmVRUjNiNEpUbzVNSlpXZWZqSXFE?= =?utf-8?B?dDY3TlIzK2NGLzhGSnVGK2tXUWNaZHB6S0VZa1FmV2dwdXcwYXJkZmxUWlFi?= =?utf-8?B?RmdWMjJUNmVjZWplYjhueTZoN1ZuTzJDTlVYWUZvcHZqam1VcFZrSGliK2Zp?= =?utf-8?B?UnN5UXFZdE5wOTB3ZTk0MDNhTkh4MXRvaFNpNTNHVVhYRFhybUNBSmVZVktl?= =?utf-8?B?ZGoya0wxUWZLTExVYTBNWHZuY3B1WDMwcmtnSHJQTmt2OGsvdm5QOTlyR0U2?= =?utf-8?B?OEpMWHZCWU9pSERqNnhwWGo3b3hDZlk5V25aejM2anQ0RWtCcWlvL0VlblpL?= =?utf-8?B?bSt0dEJIRUJaRklBZkh5SXl0VURnczlOUzRpM2dIbDgvUWk5WUxyc05yZWhC?= =?utf-8?B?Z0RJZkxqd0dpTWYwVjZDbEEyOVd6cnVLbCtGY0dSbDNMRzVrSFU1bkFKcW9S?= =?utf-8?B?Z0F4dTR2Q3BqR0laOVNxbk9nc2Q2ekR1dUI3S2J3K0hUcFY4WlRqeE1VR3Z2?= =?utf-8?B?UDVsOGkrWkRTaUJEd09xVGdnTkRVVFVBUkVLcCtoRFlEZUsveDg2NnFGNVY3?= =?utf-8?B?cnF1U1NvTEZnT09odG5JZlJwNExsTkNZK1lweFdWeW1tWjRqUmttN0JCdWh1?= =?utf-8?B?eFIzY0ZPTjRYUDBDMnBZNzFZMDdoYUkrdW1qUW5CNkFnVzNXSDRIc3EwNEg0?= =?utf-8?B?dCtBOTFJd1BkL1ljNjdyY0JEQTdlR1NVZ3QyYmQwQTV2T251bVFWVUpsNDZY?= =?utf-8?B?VW1NclBIRmlIQVhrQzBlTmtWMjhtcG1HTmpEUHMrMEZQSzh6bENzS2paSjk2?= =?utf-8?B?eEVNbWlVYUU0Mm1rbUY2cWMwMEhhcWhBV1hjYjRZM1ZoT2NxNGladHptNkJY?= =?utf-8?B?R2NFbDlpMUZuaHdzZmFrTDFPb3E5aEo1MWpJaENLVGxENW56VTRENFFVeGZ0?= =?utf-8?B?VTNmUkx4V0Y4eXB3cnFRUTg4cjBMenFLU25nVGFqQ0xRZXU4d0p1YUN1NVVT?= =?utf-8?B?V01lQ2p3dnVhVmZrU2FUczJGWk5rbjU4em53ay92Rnp0RzVjQzE0aDYveVVE?= =?utf-8?B?czBXcHV5S211K2VKbGtXanB4MTFlM2k5RER4c09lSFBSNUN0K0x0UkZsb3lr?= =?utf-8?B?NWYwQ0pzU3o2dnVKdjFTV3VmWkYvbm1sQlgwNGRLS1Vpd2xZNGRJMEIzMUV4?= =?utf-8?B?Wkxwb3d5Z2FXYVV1YkpqNkFsWDJGVzlvTXVvY2kvVnZNK2pDLzVRTVZTZm5F?= =?utf-8?B?UEdOeWcybzc1T2kzUkJLdkZyVkI1RTNBZUhKbmZMVXNXcHJZRkhQV1N4aFZX?= =?utf-8?B?cFJtU0VFcnUyUVlqVjBTU1lIYjFueHpsMjQzNnc1bmxUZU9xblRZczl3c2Nl?= =?utf-8?B?Y1NON2plcEc5S2xjNTBuUHhpQ00ydk5ic2UvVE5ZbzVhOU5Oa20xTHlJS2h2?= =?utf-8?B?dFJJY0lrd3YwckFTem9yaTdLRWgrYVlhWnFCQU9tbEVySytLdnFVNUFIR3RI?= =?utf-8?B?cFNMemtzRkY0UFdGRGMvSURsU1p0OWhqSmFLV09JcXg2c0xkdXpBdk8ra2ZO?= =?utf-8?B?M29kUzUzTXk4QW1iek5oRU5FS0NTVUhsVEdCakJBUWhnUmo1cUp0UzMyWk80?= =?utf-8?B?T2J1MytxM1NWR0tkb2VndnFjNWoyY3BucXJqUGlYenlCUCs4Ti9xMHJiK0dD?= =?utf-8?B?QWJDaEgvQW9xQnVvMGhtNkw2cjZsNFlXNzg5NnZHVW5pU2cyMndodVAvd1kx?= =?utf-8?B?RzJyVUJEaklnT00wOWxLZTJXVWRNWW5heDZTajNidFcvSFVsdmxsWk9CUVQ1?= =?utf-8?Q?HaFFfacJbcuxp5XpMw4ccw+Ahz6duZ5OnQL4VMHJLg=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d5ea934-81a4-4630-55c3-08d99fafee4d X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 16:27:02.0085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ORBAU1CDWc/ocWeyihAwW2TLqrfgynZlx4fuEJIhLGDgyjXRffnYQP+kRRaXl3OkJMfRQcDulw2s4fIgkxD1rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5307 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 16:27:09 -0000 On 11/1/21 9:48 PM, Lancelot SIX wrote: > [CAUTION: External Email] > > Hi, > > On Thu, Oct 14, 2021 at 10:32:34AM +0100, Zoran Zaric via Gdb-patches wrote: >> Previous changes allow a new set of more complex DWARF expression >> operations to be added which are very usefull for SIMD/SIMT like >> architectures. First of which is the DW_OP_LLVM_extend operation >> that pops one stack element (which must be a location description) >> and treat it as a number of pieces of a new composite location >> description. >> >> This means that a resulting composite location contains a given >> number of pieces of a given bit size, where all the pieces are >> described by the same location description found on top of the stack. >> >> gdb/ChangeLog: >> >> * compile/compile-loc2c.c (compute_stack_depth_worker): Add >> new DW_OP_LLVM_extend operation support. >> * dwarf2/expr.c (dwarf_expr_context::create_extend_composite): >> New method that creates the extend composite. >> (dwarf_expr_context::execute_stack_op): Add new >> DW_OP_LLVM_extend operation support. >> * dwarf2/loc.c (dwarf2_get_symbol_read_needs): Add new >> DW_OP_LLVM_extend operation support. >> (disassemble_dwarf_expression): Add new DW_OP_LLVM_extend >> operation support. >> >> include/ChangeLog: >> >> * dwarf2.def: Add new DW_OP_LLVM_extend enumeration. >> >> gdb/testsuite/ChangeLog: >> >> * gdb.dwarf2/dw2-llvm-extend.exp: New test. >> * lib/dwarf.exp: Add new DW_OP_LLVM_extend operation support. >> --- >> gdb/compile/compile-loc2c.c | 4 + >> gdb/dwarf2/expr.c | 44 ++++++ >> gdb/dwarf2/loc.c | 12 ++ >> gdb/testsuite/gdb.dwarf2/dw2-llvm-extend.exp | 148 +++++++++++++++++++ >> gdb/testsuite/lib/dwarf.exp | 5 + >> include/dwarf2.def | 1 + >> 6 files changed, 214 insertions(+) >> create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-llvm-extend.exp >> >> diff --git a/gdb/compile/compile-loc2c.c b/gdb/compile/compile-loc2c.c >> index ba177726d4f..2c5e13cfb6c 100644 >> --- a/gdb/compile/compile-loc2c.c >> +++ b/gdb/compile/compile-loc2c.c >> @@ -366,6 +366,10 @@ compute_stack_depth_worker (int start, int *need_tempvar, >> ++stack_depth; >> break; >> >> + case DW_OP_LLVM_extend: >> + stack_depth -= 2; > > If DW_OP_LLVM_extend pops one element from the stack and pushes one > composite value back, shouldn't the net result be 0i stack_depth wise? > > Best, > Lancelot. > Good point. Thanks, Zoran