From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2048.outbound.protection.outlook.com [40.107.94.48]) by sourceware.org (Postfix) with ESMTPS id 3C79C3858028 for ; Tue, 17 Oct 2023 14:41:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C79C3858028 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3C79C3858028 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.94.48 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697553689; cv=pass; b=OvtqKuB4qvQoTehCTQKIDjK7beL1RugnWTgHlXydcLMWaDCmSuLWPucx7WxK6k1bfDitSrgZNxJiVxk/26vJ8BgFPPePqiR2qARFKar7zzm/LkciIIyx9Ae2vwTun6nXuQwTQk9BT/PetDHsr+9jhn0iLZs/o26E8thuoVY4+7g= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697553689; c=relaxed/simple; bh=oiRTWOYlxov1URuXcVm2OMebkQOT8MIxQPLN/cSGOlE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=PwlXDQvY0XfE++uOrSYG6fxULdkpjKlAlVYIcS7ZNO9LQ+Z9+zsFs1/PGCHUp11jZhqRPmlewSpIBQQZskpYDsz1IGMFKGgXPjYHShJ9ipN9s5infZoW961p6Be2C4hGXHjursUCppVeEG5HEDO2QP+GPUGS+jlm6Xh3Edh0w7o= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=II3TeDskv5KzCk2AYInA6kzmsRXufcJX9ncRLJWexRBT8nfjJZk/GTU59PzYqKniMN8kEEio0fUS5hrFcX6HgK8eSiFlHk81ZXsz6O8vM8Thz/BzDZ5ViSFAMLeES+zxrOU31uV60fc0ab8/weYnI1JPksPXpf5vC9B1Dn9Qu5K5axw5zaCHf8pD2MQxSD8cAOcSKD2IAfs6c9xD+B1umzR7l/KGL8dlDf3vCKSApBznVBwwKCKenPz2aomK9+fKuYvCxtKtUOAMy50gNEmkjsg+ih9qMdeLLs2TFBYmWJzwz2cpSMpnQg4RSgEsEFI3hHALP80bHnrTahHa7UuAgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6XUXLLa2gH3w7VDTAwigq7yq0fQ1i+Zmms2c2ES3aU=; b=d74S2PJVzWgM2xx2uQxWiSOcCderCEN8F1x+CeBqus3HofkJ833mskMpKowCj+YP4ykVvg2nU1kNOdnjve2+/kLEluzZ10opQCPENkN3WahNIqbHNlJ/mJGFDGRMpU0t/DA2jPA0sDlTCqvSkAGh5iqZ4zbeS5qKa3YaK6xCoO7BqtoQHb7SpYfiVnxtRiCFAL/AkdWb4l4o3KwN9be9I3oejxT8+ce1BQ82vRH1w8tHZVua9fKzxTcyhnc6ghcxKN+vIHGLExIU/icC6Y4/kogbAwBd+zY67b2aqTX+M58o5JDnC2ST1MgKJyeVFIVj6loZpvvpZJyxSS7jP67NIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6XUXLLa2gH3w7VDTAwigq7yq0fQ1i+Zmms2c2ES3aU=; b=xCjJtLfa7FyF1FLB9UEYCAFMU9hTgoJTUJh2T4ih6pxz1PRlBNViWxxfPn3V6AurGhduG9ymV+mJro5trofau8qSC3PRt7UyAP0fWfRfHSzwObS7G/5vE1O4ESTrp3UEimXMtvZigsaz/9bGJdaOcQHbxJu+kUMZ2h/XXzJvCMI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by DS0PR12MB7679.namprd12.prod.outlook.com (2603:10b6:8:134::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Tue, 17 Oct 2023 14:41:25 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f%7]) with mapi id 15.20.6863.047; Tue, 17 Oct 2023 14:41:25 +0000 Message-ID: <60a7f9cd-3c64-4100-9334-5879db42a62a@amd.com> Date: Tue, 17 Oct 2023 15:41:18 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231017111629.307261-1-lancelot.six@amd.com> <6e3b93f0-f9b1-4e92-aa8b-65ee0d56ebc1@simark.ca> From: Lancelot SIX In-Reply-To: <6e3b93f0-f9b1-4e92-aa8b-65ee0d56ebc1@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::10) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|DS0PR12MB7679:EE_ X-MS-Office365-Filtering-Correlation-Id: 23e9e34e-5610-4601-a0a9-08dbcf1f23bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6GWx+3qcyEEr7EBTWyYgq8MMeGm6tVn4Jorm381juUtwg+iPgjX12ojD7G5Zk/Cyi2trr/NZV1McFWq4Dr0WzIttiPjkDf8qmzKGBprHF38jzSE3pMLSIwI1Hp0duTn23G34viu8l75bbLthkeSDZGzEK+CotAC/j1gkZaAGlOrwMvxh0KRIr/ewJ4oH0WIByXa3BjocW6ed63ZQYQZ+ITXswKX5p0JpyHtEEE+G9WHC3n2X73ppri7WL80UEyzD6BjvIUOrDpJJPPq7Awkor9wB5F7WkJ6v9Nmo71evTfXmTACj5CIqDpOin4m5J8Pfejz+F4idGDKtZFuExyyI/SJgBf+1iWqVNI0jgLxGmxGDGIZTh/EpwfKt8UbW+8EvNh1V9LxyxZqaMULChIt4Rf2BMeZyM/JtESRq5ygOwKvBvgbl9hKwWbDxgQNcCw/bmk9L82MWoEKxlze2q7C4fsaIhJVflyTUThg+/BLqIfZrl/XaKiwZSPnE/7ypb97Q7lKcjZA1S1AIYlq+g+v4yDtm0Zc7D6ZfSAI6ApZoEZoM4ACXEYJliV2JebQ+BnJmiEcwbFHh7FPdJZ/xsUshUO62gBdV898geC+0UMadsbdmNsa2hvbjXSJpODtylLdhSvC1k4JzhK+sxXqWWtm87w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB9079.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(346002)(396003)(39860400002)(366004)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(53546011)(6506007)(5660300002)(2906002)(26005)(36756003)(6666004)(83380400001)(2616005)(38100700002)(86362001)(31696002)(6512007)(6486002)(478600001)(66946007)(66476007)(66556008)(41300700001)(84970400001)(316002)(8936002)(8676002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnIvN0JTQTdvb0RTTDZLMGJsMVVhTzFKcFpPVE56UnkwcnUxdGkxdDBSbHhz?= =?utf-8?B?UmdLTTFaSnlYZFplalRFR0pERDZpdytjK2NHQ09zdWRDTkhKeHdvVkR1c1c4?= =?utf-8?B?cXM5b2dNYnZIRXFmbEVML2VlQnBaSS9BMGNDZ2FQQVlLZGU0WFFGNVdVWjY4?= =?utf-8?B?OFhxbG9lK1JmM2k3T09xWVJlbVZwVU5ybWtVMEg5T2pqUC9LempuRThsUVh3?= =?utf-8?B?KzZmMGRLQ2I4THNHcTE0djd2S3ExODhMYWZjM0NDZnBYTG0ybmxIejhVa3hh?= =?utf-8?B?MjRUY0FWSXVDQkpxMWJ2cHVTenpxVytoaitocEk4Y2RldWxMTU5IY0grWlVo?= =?utf-8?B?dTR5R09yUTdkS25BbWQwZzdRYTVzRTV4SVFYR2kyQ014RnExRmd2MXFscXp5?= =?utf-8?B?UVcvYXZRQjhJSFl6RGNlQjUzQWN2WGZjNW9jazg1UnNqcm9UYStFNlVXbEcy?= =?utf-8?B?eEhZREIzNEpXRXlIRW12YXc0Z29IS3IrVHR4RytVWk0zeGtIcEdxMXlaNXlQ?= =?utf-8?B?Uks5WmF5ZlU3dWtsM08wbVI3ZlR0c3JucGpXYmIwZFJNOE1uTU02d1ZydGsy?= =?utf-8?B?NkpoTFhaU0JncjZkY2pQcHE2RFFGY01SMHBzNEMvdE4wSmtZNHR2K3F6OEpK?= =?utf-8?B?UXUxVFN0ZzlqMHZadHFsWnJHZE51OEVDMCtINU4xcldDNC9oV3FqSlIwY1h4?= =?utf-8?B?WVpZWlBGUWhiVUFHTWppMmJ1QjkzT1l4SXlVSGFPTkhJTkFxYmNvc0pOZkFI?= =?utf-8?B?RE5hMW5OdGNEVHM5aEJ1UEljK2Q2ampid2NGd0Y0aFJ1L041TW50Y2FlWlpx?= =?utf-8?B?TW5XVlUybEVqbm91dVd2YzRFOGRmbDJzd2pnL0w5Q2dqNGg4NFRiOENZVFd1?= =?utf-8?B?c2pZZzA4eDR0UTZtL213WFpXenBxQStpdlRQSkhYZVNUMjRWSnl2WWd5a09x?= =?utf-8?B?cnJDVjhXd1BOUVpKbC96K0NtVXR6Mi9DazBWQnNjWHJ6L3IrL0VMVHBBZWkw?= =?utf-8?B?QW1HNk9vMzlMZ2RTdHBjeHlEOFNEakhCemhub1FnYWtFUEVpT2xHYUJjb2tU?= =?utf-8?B?NkpqQmZ1N2tYVlNuUUlKWjlUK1ZoQ3lKZm5PSllBTW5jRUlub2JrTGQ1YzVj?= =?utf-8?B?YU9mRUs3MllpYTYxbFNOSTU2czJCbjRBV3MyZXNJUlhvaXh1OW5RUU4rR1h4?= =?utf-8?B?Y0o4NENLT29JLzJJL29xRmdGTXNoU3RGQ0FGT3BvWVpFQW14K003bXRRcG02?= =?utf-8?B?MTI2ZDZxdVphY1N2NU53ZWhPUG9sR05CSFFhT2RCSzNCL01zclBGUzR5Wk40?= =?utf-8?B?MkF5SHVIYi9iaTVTd1YxdGZoRFJKK1l5T0FDS3k1QXkwQnBldGlibVkwRnV4?= =?utf-8?B?a0UyUU03WVhyazFFNXJBdlpTM2k3R2dPQjJ4bjJ5TlYzNlo3Z1NnWDJCdllU?= =?utf-8?B?R2NIMDBpSFJ0d0Y0NUNiQVAzRFpxSWVBVDF5dE5iRldLbGdkMHJLUHRiQnJG?= =?utf-8?B?WFVhM3lacEJsZWZZREtCZW5MVUluUjFHZzdwZmNRMVhJeDhtYUVaTS9pWFV5?= =?utf-8?B?SEdIT2JMNlNyYVZmOTNHcHdIUlVDRGJMZXpmZi84ZVRkZ2xuVU41MElTdmln?= =?utf-8?B?RnBtV1ZYb2duM1k4ZDRoS3FlUER6T2RxeDllaDFUZ3FsZTlJb2x3MUlZdFp3?= =?utf-8?B?MUxQQ0VHRGRCT3pWWUIzalNuclpVSU5iVG9GSEYzem0wYUJjVkJRUlhBY3lU?= =?utf-8?B?RlEvUmVlQ3ZERkhucG9DU0I1Qm5QZVJvZjk0TE1OS1IvTE5QTkEwOW1uMXBv?= =?utf-8?B?blpOSUc3S3lhdmVzMlJsMVRXSWUzL1ZSQ1ZrWHNWVHNLUWNMemtCQXA0MEpo?= =?utf-8?B?L0crdnJnbDcyM2pwbGtjaUNYOGovZnNjV3JNeXhxS1hNYWNjQlZsSE1vd1FR?= =?utf-8?B?ZEJJc3ZKcWxGT2RQUFhmNWFWYllsLzBkV2VzaXRFdEhtUzRXQUM5K0hYZmdn?= =?utf-8?B?T0lwWEowOXZiOHpvRnBxQ0dUS3Zhb2UzWldJU1U2Vm1lR2lwMzFOZHJka3Vn?= =?utf-8?B?TDVGWG82aDJQaEJhbDJubU54c09PUHIzMFhPOHpnMTEzb2E0eStPMmR6WXhN?= =?utf-8?Q?FVrU/lSKXx87fxvPoEL5zV4NP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23e9e34e-5610-4601-a0a9-08dbcf1f23bb X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:41:25.5462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9rVoM2LjyWOo5avzqGIGuGC3ughIgh0gIs5GNoqLU1/PDJGvhmC3wVVgsRgGZ/gl4zqgL7z7S8paGJ4JePlzcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7679 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 10/17/23 07:16, Lancelot Six wrote: >> The gdb.rocm/multi-inferior-gpu.exp testcase uses a "continue $thread" >> command, but this is incorrect. If "continue" is given an argument, it >> sets the ignore count of the breakpoint the thread stopped at. >> >> For this testcase it does not really matter since the breakpoint is not >> meant to be hit anymore, so whatever the ignore count is won't influence >> the outcome of the test. It is worth fixing nevertheless. >> >> While at changing it, switch to using "continue&" to consume the GDB >> prompt right away. This makes the following pattern matching more >> reliable. > > I don't understand the "more reliable" part, can you explain? > > Simon There will be a "(gdb) " prompt appearing at some point after a "continue", but in non-stop we don't really control when it appears (if I understand correctly). It seems that other non-stop tests use the "&" variant and consume the prompt immediately. With this, before the next command is issued, we know that 1) we got a prompt and 2) we have seen the process we just released finish. Overall, I am mostly trying to follow patterns I caught in other non-stop tests. Best, Lancelot.