From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13280 invoked by alias); 8 Dec 2017 12:23:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13270 invoked by uid 89); 8 Dec 2017 12:23:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 12:23:06 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 634476A7D9; Fri, 8 Dec 2017 12:23:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BDD4C9231D; Fri, 8 Dec 2017 12:23:04 +0000 (UTC) Subject: Re: [PATCH 3/3] Clear non-significant bits of address in watchpoint To: Yao Qi , gdb-patches@sourceware.org References: <1512727471-30745-1-git-send-email-yao.qi@linaro.org> <1512727471-30745-4-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <60b7151b-625a-15a2-2754-8e3c7aeefa41@redhat.com> Date: Fri, 08 Dec 2017 12:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1512727471-30745-4-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00181.txt.bz2 Looks good to me with formatting nits pointed out below fixed. On 12/08/2017 10:04 AM, Yao Qi wrote: > 2017-12-01 Yao Qi > > * breakpoint.c (update_watchpoint): Call > significant_addr. Wrong name: significant_addr -> address_significant. Guess you went back and forth deciding the function name. :-) > @@ -1867,7 +1867,7 @@ update_watchpoint (struct watchpoint *b, int reparse) > loc->gdbarch = get_type_arch (value_type (v)); > > loc->pspace = frame_pspace; > - loc->address = addr; > + loc->address = address_significant (loc->gdbarch, addr); Spurious space before '='. Thanks, Pedro Alves