From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43032 invoked by alias); 12 Nov 2017 16:00:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43021 invoked by uid 89); 12 Nov 2017 16:00:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:372 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 12 Nov 2017 16:00:27 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 916A51E030; Sun, 12 Nov 2017 11:00:16 -0500 (EST) Subject: Re: [PATCHv4 1/5] gdb: Remove duplicate declaration of a function To: Andrew Burgess , gdb-patches@sourceware.org Cc: donb@codesourcery.com References: <2677012b106ea6d716c7f6baf9388fe3d3772402.1508418720.git.andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: <60f40b41-3e67-1ee8-6a66-a09d4079be70@simark.ca> Date: Sun, 12 Nov 2017 16:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <2677012b106ea6d716c7f6baf9388fe3d3772402.1508418720.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00224.txt.bz2 On 2017-10-19 09:27 AM, Andrew Burgess wrote: > A function is declared in two header files. Remove the extra function, or global variable? > declaration, and add an include of the correct header into the one place > this seems cause an issue. What issue? The change in itself looks good to me. Simon