From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2075.outbound.protection.outlook.com [40.107.115.75]) by sourceware.org (Postfix) with ESMTPS id 93C693858281 for ; Tue, 10 Oct 2023 15:01:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93C693858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqTuZMC9zUrkBuzPsyb+dQVVkjf8tW4/oN8Ru03Yq5L3b3WaA16guwEc3CJtVLhzFVC+J6A09rdjMOGLjLWwWnGxfY8D0oppKX8Nm7zAwOhkaKBuPTPTZoAbrj2UFtIpoJ3gBuWoWoUA0W85Lu576ApZuyRPLpvAHLPzSqTzV+4wFFftQLpjXUADhBWnGekmvjaTOQQds3A0mY3TPFk5FzuDd3Yg0bn7t6sVUn/vSMPkQ2djMgvVmoIxEsD994bC2gyLBqsgiMxnLynGr53QYgA53kGYBiybYZ8rh+6Fyc9cqv/AbqXkqG8g2aE3yZkPnyAqjyRcQjcdeV6qqPArwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CYVT9Re87VN4qlan5+JDOfosGbSOQcHZH2Kq1HjHh38=; b=gnzwq7HQH5TdQG8aOYC3xX7qP+3QO0NqM6p2oWFGM3haxt24MsWok7rfVEAufm/Hsfype6oDqnmIsy9HWdtxYmO2ZAhXKgGsN9o048WB6OfqfvRATNX3pkPdM/CGZRDZGp0WTvqc50IZ3lxEmeiqicG+Kaf4lZLbfJ7b3jzK8qwV5zAaLK8o2h4nzaOP/7yZLpqt2CNXQUkOmDIfxEfPMi0IAvFKGuahKMutCj2QwI1Ixi9b18n56zXEViLVm0rA/uqQhKl9flEy6WH+kYsx57wUrqqWvd4l7aOheGZqGlDOSz5ReF0kxqKxVGE84mz+flP4ZDcqDFMCld+MUFNXhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYVT9Re87VN4qlan5+JDOfosGbSOQcHZH2Kq1HjHh38=; b=fnIN9eI4BhHsEx0CCcgRHNlPskXjKItu35911Qo8QsXa6LXUmv3/qcKcbpKJHpyx1yBnnuWQkg8o2wQKCyoH5wkum2Lo1o61qYFqW3XzSjx72JED39JlvZ42oY7fbanziZOV4EOTZvp7gCflR+Wz2n1Y1i9m5J0VZXFObTIlkOFJzT1p2tVSm9bvtBN8AwvUYBE0TpK92vdX8kgh5nzA1ARAAMM+xz2+/OU7mDrHjmHXRQoFUa5njhLTOCDdJP14eeSVsfAPXEwqv17eoEbKixKTwus/S789vpYXcN9vfZq3FXTM2OAdOSNHF1KVsNVQt8Yp5woIOzCWJ5g8awR+Yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT1PR01MB8377.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 15:01:50 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%6]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 15:01:50 +0000 Message-ID: <61054ea7-50b4-4183-b4ec-c8e0bad85bf1@efficios.com> Date: Tue, 10 Oct 2023 11:01:50 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] gdb: add assertion when marking the remote async flag Content-Language: fr To: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <20231004020701.260411-1-simon.marchi@polymtl.ca> <20231004020701.260411-4-simon.marchi@polymtl.ca> <87a5ssdu5l.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87a5ssdu5l.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0281.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:68::26) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT1PR01MB8377:EE_ X-MS-Office365-Filtering-Correlation-Id: fa87276a-5aa2-4017-c630-08dbc9a1d50d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ICYqjJS1PlPJ2I12hzdBS2Uj16tPRXSY/g0ssS3bmfd4oSvJfrEr6Us3fMYaf2/yL6s83KpluFVw6a92E/xeqkCA2CHW7Qfals0/aD7gNW39qhQzl79BD9yCp5CLOXOcEy+dzWZ+4FSY9Y/g0MXeVSV6yx8kk6bfZkRYiu3FXSeF8YWHTkOvJyvIfLUNTtdb8kVCJpsjFBW2bp0IiYog5eGmsh0kzFL34Y+BtUTjtA3CFW5cYD2h3Cu3D2cs9oWC2dosrIiFptAIFqb1G7Jj1dcvdYlS12kexGEsJnyORGfM1JrSV4gvh5X2GvJDFgKBR27eYKXRIqy1Y9sU4D0c2jcf/OXE35A943tZfMhy+nPAeueX0aWZOdBVqgWDwetVdjsukkJPDFN1cKsw8foeCDpQMFKQo1g0ziQQSxNU11fbgM+8/hatXzTJhWy65t9A+hNynCIMDPa7GilNlNqxW66mGG24bA8k+9skzJ/vLh2yj2yKl/XXnAp4VV1aY4+n4rizQjuH7CIA9PcETUvDDZMaXb9gnb091GVtbOM5sVhySgtd0NsRvrBjhqJrxdzETBYtszclqEGPEvi/EqsuHNzq1eaqP159H2/guxOB6fmEQmLATkbfiqNq6Hw7uNFPValhbZM8+fQmKKppxrlV6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(366004)(376002)(39830400003)(136003)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(110136005)(316002)(66946007)(66556008)(66476007)(6506007)(38100700002)(6512007)(2616005)(53546011)(6486002)(26005)(478600001)(44832011)(2906002)(31696002)(41300700001)(5660300002)(8936002)(8676002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mlo0TFkxNXEzVFU3dzJIcWh2YU9RUU9oVlRod1dBdTVjMk9ET1hRdzA3OFhX?= =?utf-8?B?UmtDeW05OWtjRkNxTUFjWXlrSlJxbjNlbkc3L0xyWHo3TVB0OENoNWxhZVo4?= =?utf-8?B?R0tLeW44a3A3eFhhKzhqMi9BMkpvTkNzSjYvdXBLcXpoWUNTVS9hcXdhbWJh?= =?utf-8?B?ZklYR3hKdTQ3Q0d3TEQzN2kwai9CWVBVSHBZRG4rZEhON1ZKc2JpYTRDc296?= =?utf-8?B?dVB5ZUZFSSthampZNFZWNGRuSXhkSzBqM01yaFpqRFZTL0NITldBaHRNUUIy?= =?utf-8?B?MTFZZ0h5dnZQNHhDcG1IMVo5Vlpyam1aYmJjZ05Ua205LzVCY290b2VoaGlT?= =?utf-8?B?MVZvYzBTTTJ6VS96OGdldVFhNWRFSXR3UHZnVGZPSG9iMkR4YTJXek9HSnho?= =?utf-8?B?V3hwelhRYW4wWll3VTdWWEloZklXdVQ1ckVLNG1ZaCtva1l2OENQQnJjb1Nq?= =?utf-8?B?YjVhbFQ1dEo0cWViUmNwd3FlWkJ5NU5naVZTUWt6bTVEbXQrZlRKV1c1QVZ5?= =?utf-8?B?RkQ0K3ErV1NDblVWOXA4cmdYOFFGMlVkdFZYOHNuMUY1dmdXU1F0VWc0QVpu?= =?utf-8?B?Tjl0cDEra2Y4RDVHR09UbVAwT3NDR0Rxd3Fjb3FZVFpRVDNFNW82M3gzbUdu?= =?utf-8?B?Y0RZQTZxQTBEc2JHWFltSXo0ZkRiWTREL3YyTDJBVGh1a1J4VUlxVFVjazhY?= =?utf-8?B?NE5zZjg2aWVPTkw3QmZZYWQ5RzRoUFN2RTlKZHBueGJMTVJEQWxuRXVRM05Q?= =?utf-8?B?N09kazRFUFlvUTI0RE9MUlN4MVdLRVN5MlJ5OWhWd1FyNzFBY0JoZGZTR05H?= =?utf-8?B?L1F1ZE93UnVjVnJHQkpMaWNSaEZuaFZlUHN6a3M2L2RNUWpWeERRSUFRTW1Y?= =?utf-8?B?OTRLVHRxQW5nWERBcGJFbTZWMXRCMmJmaVFHZnBGMjdxeHhSZ1QxbUROQVh2?= =?utf-8?B?UTdUTWg2YTFpTytZL285VHhYbGFvNlExM3ZqK0Myd3JTeFdIRGZDb29VTlZY?= =?utf-8?B?R1Z0Y2RUQUFjM0JvcDlDMnVxYkpOYXB3b1piNUk5WUt6eXRBSnAvVGMvRCtQ?= =?utf-8?B?Y1E5dmZpUUZlOENvY2d1eW5NZEtaRnIzMCsxTEEzOE1sWFFXT0JIaFlTcllr?= =?utf-8?B?Kzcyd1ZRN3pmY3pzV0F2bTF6NDhjem5tRHJCSTBNSFFIeDVkQUJEajdsV3U2?= =?utf-8?B?a1R0dEp3c1hRR1crUXpKWEM4TlM1dDVlTzBObzRQK0ZnMXNheElpcS95aEVE?= =?utf-8?B?WGFUNms1YlVmS25oR3JMSUR2M1JhVVhJMXAyTkI5VmdqT00wUWxUbUpZQmYy?= =?utf-8?B?d3FWZ1MreEtJTkRBMzVwaUlYMTEwZ010RmJqS0crU2hXTHhOTjIwR3NndEhW?= =?utf-8?B?eTJlQkZHdEZWRUQzVGNXcUgwcWZta1o5WXdIQk5TcWFrbTBXWktjc1lkd2tr?= =?utf-8?B?NG9VKzNYb1g1bU1GTG5lNmJGd3N0QVpzNWtLNU1waTJqUGgyVHJSczRmUXNH?= =?utf-8?B?VHJ1dnpXelEzM1YybWJuZmhTR2djYjk1c0dvMnZoQXRIZGMvd2l5MXpaSytu?= =?utf-8?B?d3FhSWdYTFRZTUZ4OFNlV2o1Mm4xbjMxbFpnYmdIS2lheVNrV3NaQ0k2VjRB?= =?utf-8?B?VytYZUN0L21XaHdYRkNSdFlsNEVWNzJBem1HSDloek0vQllLUFN3TlhmL3E0?= =?utf-8?B?OXdrc0VFZEZNVjk5MGFmL204di9HUU5LZlZ1VHkyeW13K3BYVVlCeTNFdldQ?= =?utf-8?B?MlRJNTNQVmRHS2N0NjREVlJyMnNMWlhSMHVOd3hlMEZ3cU8rdDBFNk5pSXds?= =?utf-8?B?MmdHMnFrajllWFNXQ0VWWjdCZVkvbzJXQ2ozOG1icHFCZzVNUTZ4dWNGTjRN?= =?utf-8?B?N2FxTGJnMlBETHJQcWdOWXF3OEVtWkdiNCthVDBRMWg5NTlBWEROcmE0WFRW?= =?utf-8?B?OFRqTlNldE0wQUZnM0ZSa1pYOFB6empGM1JzbDNqUUhlYzFRaUx2aDNxM0Vp?= =?utf-8?B?U2EzMUd5NkJ5SVdlbU4zZmdkTGJjUkU3UmhMNU9CUGZJcitFQ3ZNb1FSM3g5?= =?utf-8?B?S0xHbWNmWTBTNzJsb2MrUzlRTEEvdTliNzBXVlhMTCtSZndOT2MvbklBN0FU?= =?utf-8?B?aEJGa0FTendFejNQMlVPWkczWUVsU2hodnZuL2J3ZTR5d05lU2tISDZFSWcy?= =?utf-8?B?NWc9PQ==?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa87276a-5aa2-4017-c630-08dbc9a1d50d X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 15:01:50.6502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h6bZjUoFt+EzEcQswVzqoUJEZvcTzEnbZR98t16qhczp5UcdgEyNEUQAJssVVJuJ/OTze2NnGihxUwB1txYlvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8377 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/9/23 05:25, Andrew Burgess wrote: > Simon Marchi via Gdb-patches writes: > >> From: Simon Marchi >> >> As reported in bug 30630 [1], we hit a case where the remote target's >> async flag is marked while the target is not configured (yet) to work >> async. This should not happen. It is caught thanks to this assert in >> remote_target::wait: >> >> /* Start by clearing the flag that asks for our wait method to be called, >> we'll mark it again at the end if needed. If the target is not in >> async mode then the async token should not be marked. */ >> if (target_is_async_p ()) >> rs->clear_async_event_handler (); >> else >> gdb_assert (!rs->async_event_handler_marked ()); >> >> This is helpful, but I think that we could have caught the problem earlier than >> that, at the moment we marked the handler. Catching problems earlier >> makes them easier to debug. > > Agreed. Looked through this series, all looks good. I had a few nits > that I reported, but otherwise: > > Approved-By: Andrew Burgess Thanks, I'll push if my CI run is clean with the changes applied. Simon