From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by sourceware.org (Postfix) with ESMTPS id 3BB013858D38 for ; Tue, 22 Aug 2023 13:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BB013858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-31c5cac3ae2so1269637f8f.3 for ; Tue, 22 Aug 2023 06:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692709340; x=1693314140; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3RvvpRyqfF8kUyTUaeU28LwVq0xuDDl9Lm27U/1305M=; b=B6CN1PIFI02GzqLJkVqWXcSzyw4WU3GxYH0AZe/YWhwlBIY6oJxP4X/NSJGiuvC8cP QstW4W4WWvfMyD7OOThGMMqGEpqihF/ICHU6bTjFTXoI2SYqzBe0pMT9UVrFucy+r28V B/BNwDa0TayuC3rOqnhVFUj4c92mtYj8wscE+c4PpcpTzxTg935mTqqRENhVokDw/fo/ c1E2B2Vnkd6ItSluN0sZzU6GTktVM20i3hwnCMu1Mshnk/gGTgIbhKcyBLc5+a1tc0Dl BXXbYiqLXkpee4Fs0oa9XD1l1ok7XMwBvrxoHELvRpT3edcWDpR8y64zq+cyy40Vbvk3 8DAQ== X-Gm-Message-State: AOJu0Yz2Bj7WrOKJtPgl126zdMys/l7H9Rc4TpV0hruWCzScJWf2OrrV ALx+goz6IA74Omti/2tBVjc= X-Google-Smtp-Source: AGHT+IGBFo/RK5f5Erj6Fh9spcal2pqDcNqpHZhasysLO2PbqGPMuoQQOe1zcSYUFXBqVlmQyWsljw== X-Received: by 2002:a5d:4a12:0:b0:317:49a2:1f89 with SMTP id m18-20020a5d4a12000000b0031749a21f89mr7209354wrq.1.1692709339686; Tue, 22 Aug 2023 06:02:19 -0700 (PDT) Received: from ?IPV6:2001:8a0:f90f:8600:1210:1829:770d:f735? ([2001:8a0:f90f:8600:1210:1829:770d:f735]) by smtp.gmail.com with ESMTPSA id e11-20020a5d65cb000000b0031416362e23sm16079643wrw.3.2023.08.22.06.02.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 06:02:18 -0700 (PDT) Message-ID: <611e248d-9555-2519-dac6-7adf0e019230@palves.net> Date: Tue, 22 Aug 2023 14:02:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/3] Fix thread exited messages for remote targets Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-08-21 10:31, Andrew Burgess wrote: > The point of this series is to fix the thread ... exited messages for > remote targets. I made a previous attempt to fix this issue: > > https://inbox.sourceware.org/gdb-patches/0215c520c680334efac7f0544d834ec1fb7aff8e.1669634536.git.aburgess@redhat.com/ > https://inbox.sourceware.org/gdb-patches/d6d49338119d2a32e060f95219aacac31bdf4886.1674207665.git.aburgess@redhat.com/ > > But Pedro hinted that he had a better solution as part of his step > over clone/exit work, the latest version of which can be found here: > > https://inbox.sourceware.org/gdb-patches/20221212203101.1034916-31-pedro@palves.net/ > > Unfortunately, the larger series, of which that commit is a part, > seems to have stalled. Yeah, sorry, I saw your reviews a few weeks ago, so I started reviewing your infcalls series as a way to "pay" for your reviews, before addressing your comments in my series, but then summer vacations and other priorities got in the way. I still have every interest to get that series merged. > However, that particular patch doesn't really > depend on anything else in the series, and so, in this series I've > pulled out this one patch (3/3), along with one other patch on which > the above sort-of depended (1/3 - this changes a similar area of GDB). Thank you. > > The remaining patch (2/3) is my own work, and is an additional > refactor which I think follows naturally from the first patch. > > Patches #1 and #3 are mostly Pedro's work, though, some updates were > needed during the rebase. Any bugs introduced by the rebase are mine. > All looks good to me, please go ahead and merge it. Pedro Alves > --- > > Andrew Burgess (1): > gdb: remove the silent parameter from exit_inferior_1 and cleanup > > Pedro Alves (2): > gdb: make inferior::clear_thread_list always silent > gdb: centralize "[Thread ...exited]" notifications > > gdb/annotate.c | 4 +- > gdb/breakpoint.c | 4 +- > gdb/bsd-kvm.c | 2 +- > gdb/corelow.c | 2 +- > gdb/fbsd-nat.c | 3 - > gdb/gdbthread.h | 22 ++++++-- > gdb/inferior.c | 35 ++++-------- > gdb/inferior.h | 12 ++-- > gdb/infrun.c | 2 +- > gdb/interps.c | 6 +- > gdb/interps.h | 8 ++- > gdb/linux-nat.c | 8 +-- > gdb/mi/mi-interp.c | 4 +- > gdb/mi/mi-interp.h | 3 +- > gdb/netbsd-nat.c | 3 - > gdb/observable.h | 11 ++-- > gdb/procfs.c | 6 -- > gdb/python/py-inferior.c | 4 +- > gdb/testsuite/gdb.mi/mi-thread-bp-deleted.exp | 14 +---- > .../gdb.threads/thread-bp-deleted.exp | 12 +--- > gdb/thread.c | 56 +++++++++++++------ > gdb/tracectf.c | 2 +- > gdb/tracefile-tfile.c | 2 +- > gdb/windows-nat.c | 20 ++----- > 24 files changed, 121 insertions(+), 124 deletions(-) > > > base-commit: b080fe54fb3414b488b8ef323c6c50def061f918