From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id F0B033858002 for ; Tue, 30 Mar 2021 17:40:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F0B033858002 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12UHeIdB015028 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Mar 2021 13:40:23 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12UHeIdB015028 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3767C1E789; Tue, 30 Mar 2021 13:40:18 -0400 (EDT) Subject: Re: GDB 10.2 Release: Proposing Mar 13-14 for official GDB 10.2 release To: Joel Brobecker , Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20210306064611.GB807147@adacore.com> <06d96113-d09b-993f-0f55-00c297b4e591@simark.ca> <20210310024850.GA247585@adacore.com> <17184b08-d7e7-a62c-b689-35ab3f179f06@polymtl.ca> <20210316034551.GE3188@adacore.com> <875z19dyju.fsf@tromey.com> <20210330075944.GE11111@adacore.com> From: Simon Marchi Message-ID: <61318dec-2034-1425-51e5-de5ff846ef8e@polymtl.ca> Date: Tue, 30 Mar 2021 13:40:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210330075944.GE11111@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 30 Mar 2021 17:40:18 +0000 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2021 17:40:26 -0000 On 2021-03-30 3:59 a.m., Joel Brobecker wrote: > Hi Tom, > > On Mon, Mar 29, 2021 at 11:02:13PM -0600, Tom Tromey wrote: >>>> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c >>>> index 704ba9f36655..5d9256bece1e 100644 >>>> --- a/gdb/dwarf2/read.c >>>> +++ b/gdb/dwarf2/read.c >>>> @@ -1954,7 +1954,8 @@ dwarf2_has_info (struct objfile *objfile, >>>> doesn't require relocations and if there aren't partial symbols >>>> from some other reader. */ >>>> if (!objfile_has_partial_symbols (objfile) >>>> - && !gdb_bfd_requires_relocations (objfile->obfd)) >>>> + && !gdb_bfd_requires_relocations (objfile->obfd) >>>> + && 0) >>>> { >>>> /* See if one has been created for this BFD yet. */ >>>> per_bfd = dwarf2_per_bfd_bfd_data_key.get (objfile->obfd); >>>> >>>> We can then take our time to look at a proper fix for master. >> >> Joel> It's quite nice to see that this feature could be disabled with >> Joel> a one-liner like this. >> >> Joel> Unless Tom has other ideas, this seems like the way to go for me. >> >> Sorry I didn't respond to this earlier. >> I think it's fine for the branch. > > Great, thank you! > > Speaking of the branch, given your patch below, perhaps we can have > best of both worlds if we go with the solution you suggest? > If we could converge on that by the time the weekend comes, > I think it would be reasonable to backport your patch to the branch > as well. This is now pushed. Quick! Release before any more bugs pop up! Simon