Re: [RFAv2 1/4] Implement user defined prefix.

[Simon Marchi <simark@simark.ca>]

> diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
> index 06cdcd6bfe..e0463cb5b7 100644
> --- a/gdb/cli/cli-script.c
> +++ b/gdb/cli/cli-script.c
> @@ -29,6 +29,7 @@
>  #include "cli/cli-cmds.h"
>  #include "cli/cli-decode.h"
>  #include "cli/cli-script.h"
> +#include "cli/cli-style.h"
>  
>  #include "extension.h"
>  #include "interps.h"
> @@ -1395,7 +1396,15 @@ do_define_command (const char *comname, int from_tty,
>        int q;
>  
>        if (c->theclass == class_user || c->theclass == class_alias)
> -	q = query (_("Redefine command \"%s\"? "), c->name);
> +	{
> +	  /* if C is a prefix command, tell the user its subcommands will
> +	     be kept, and ask if ok to redefine the command.  */
> +	  if (c->prefixlist != nullptr)
> +	    q = query (_("Keeping subcommands of prefix command \"%s\".\n"
> +			 "Redefine command \"%s\"? "), c->name, c->name);
> +	  else
> +	    q = query (_("Redefine command \"%s\"? "), c->name);
> +	}

I think it's nice to mention that the subcommands will be kept.  But if the command
is a prefix command and has never been defined itself, wouldn't you skip the question?
Don't you find it strange to ask "Redefine" for something that was never defined?

Simon