From: Pedro Alves <palves@redhat.com>
To: Omair Javaid <omair.javaid@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2][PR gdb/23210] Unset gdbarch significant_addr_bit by default
Date: Tue, 29 May 2018 13:12:00 -0000 [thread overview]
Message-ID: <6185ec68-3e8e-3e3f-b89d-9499d1986357@redhat.com> (raw)
In-Reply-To: <1527296331-32213-1-git-send-email-omair.javaid@linaro.org>
On 05/26/2018 01:58 AM, Omair Javaid wrote:
> This version fixes the typo and gdbarch.sh issue highlighted in review.
>
> LGTM?
I think the resulting API ends up a little weird. Maybe a better
fit would be something around:
CORE_ADDR gdbarch_canonical_address (gdbarch *, CORE_ADDR addr);
with the default implementation being a nop [return ADDR] while
Aarch64's implementation would clear the tag and sign extend.
Dunno, not sure, I really did not think that through, and, as
I mentioned before, I'm totally OK with this as is, we understand
the issues and can always change it later.
More important right now is unbreaking 32-bit x86 and the branch.
Thus, OK as is. Please push to master and branch.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-05-29 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 1:25 Omair Javaid
2018-05-29 13:12 ` Pedro Alves [this message]
2018-05-29 19:52 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6185ec68-3e8e-3e3f-b89d-9499d1986357@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=omair.javaid@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).