From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52432 invoked by alias); 29 May 2018 12:09:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52422 invoked by uid 89); 29 May 2018 12:09:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 12:09:41 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7CE6BBB409; Tue, 29 May 2018 12:09:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0626B111670B; Tue, 29 May 2018 12:09:39 +0000 (UTC) Subject: Re: [PATCH v2][PR gdb/23210] Unset gdbarch significant_addr_bit by default To: Omair Javaid , gdb-patches@sourceware.org References: <1527296331-32213-1-git-send-email-omair.javaid@linaro.org> From: Pedro Alves Message-ID: <6185ec68-3e8e-3e3f-b89d-9499d1986357@redhat.com> Date: Tue, 29 May 2018 13:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1527296331-32213-1-git-send-email-omair.javaid@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00754.txt.bz2 On 05/26/2018 01:58 AM, Omair Javaid wrote: > This version fixes the typo and gdbarch.sh issue highlighted in review. > > LGTM? I think the resulting API ends up a little weird. Maybe a better fit would be something around: CORE_ADDR gdbarch_canonical_address (gdbarch *, CORE_ADDR addr); with the default implementation being a nop [return ADDR] while Aarch64's implementation would clear the tag and sign extend. Dunno, not sure, I really did not think that through, and, as I mentioned before, I'm totally OK with this as is, we understand the issues and can always change it later. More important right now is unbreaking 32-bit x86 and the branch. Thus, OK as is. Please push to master and branch. Thanks, Pedro Alves