From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id CB8873858C50 for ; Fri, 4 Aug 2023 00:14:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB8873858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0AA641F74D; Fri, 4 Aug 2023 00:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691108063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LtaK7Pk9z0Kfz4aAZAW2YVBzEdn4IzmrkIXExaGCT4A=; b=wPM3Mwrbg7qUtECBnUa8G+BdTJ9IiRs7hXIKQ7OHaGwDLfnW4UFvQXo/yM0x9Ngq6iFW0i E2GdQMgoLyHIGF5tJ9X3LN3MtaDOROcx+v1Rzjr4UwTVy5kYgh2Z6jOV8TTYLHprzt34YU EHgw633QOnCHqiN9znEAf8vnM8Ni4mY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691108063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LtaK7Pk9z0Kfz4aAZAW2YVBzEdn4IzmrkIXExaGCT4A=; b=eI9ER6a/qUqYzvfJOxYZTsvvpPr82aYMqCf630HvKdONXLqTbd2/NymWRLkpH6O1seid3n fy53GMOoylRIEJBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EBB6A134B0; Fri, 4 Aug 2023 00:14:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tGlmON5CzGT/MAAAMHmgww (envelope-from ); Fri, 04 Aug 2023 00:14:22 +0000 Message-ID: <61d5715e-91c1-0feb-95e1-fe88230a83da@suse.de> Date: Fri, 4 Aug 2023 02:14:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/6] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230802095305.3668-1-tdevries@suse.de> <873511dyas.fsf@tromey.com> From: Tom de Vries In-Reply-To: <873511dyas.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/2/23 21:44, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Thanks for this series. I read through it and sent a few notes. > > Tom> There's one more patch like that, I checked using pahole that the struct size > Tom> is not increased. > > "ptype/o" is basically pahole FWIW. > > I tend to think that in most cases, the size of objects doesn't really > matter. I mean, obviously we don't want to bloat them unnecessarily, > but for something like this, I just wouldn't worry much... and if we did > care there's probably some other way we could shrink them than worrying > about packing. > > In the olden days pretty much the only thing really worth worrying about > was partial symbols. Now I guess it would be cooked_index_entry. Ack. I've submitted a v3, following up on comments and dropping the patch that's no longer required. I'll commit tomorrow unless there are further comments. Thanks, - Tom