From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 554053858C78 for ; Mon, 27 May 2024 22:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 554053858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 554053858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716847261; cv=none; b=XvOcdY9qdjp/Ml2e3aBe1Srjs3nfs3l6L9DkwFVXCrNx4O+R8AapvYmwwE88u+KXueoX6+/WCn03ntKXNdXLhRPxz9ThGG86yWje2fYpoVOc1HrGT4oRsLS4udgc2m5po4pkNTxhmX84DzGqPWovshx79pM+SefeFIwEjdkSjY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716847261; c=relaxed/simple; bh=5iYTmeXMR+oMapRkJMDvpWT82uYVbqBVpjCbrbEBAaU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=B+IpkjKezh3X/I1v1jNc/iCS5/TIMlmoIRKvRxKwhFsXM32n79xqL3UAIw1c9wTACgAxZyJu5rTck7cNLs15dGJU42aIW+2Uuwofn5NVCrMe1tlJSh1k3XKdZnEo30oC21KFTsO+QjOygUdX737CneXEtRyI0o5aDfIrgVh2P0E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 490FC22252; Mon, 27 May 2024 22:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716847258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42tiQSBEE6UjG05pgPxLAM6u1S+l8SL+xLr4Zfg2Mb4=; b=JDfEIXCqLGjIFAywSw1Pa3kyKQSV7ra6esgQyNFz/5oS62ibCi4NdV0+JKtYgVS4SveOgu vY7LZ3RQlj86qzaC7rfzqxQZjSc7KxLhYgIqrgIILRjAgK5Bdt037zsWbT2pPVrlgUfje/ +2kHDFBZHPbNezjb4LZq7DjGVLPUJj4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716847258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42tiQSBEE6UjG05pgPxLAM6u1S+l8SL+xLr4Zfg2Mb4=; b=gRbzX5UJDedE1ktUVw+TnU1kQBVZMFZXhOfTNMP9eD7/7vFVpsz3/WNWJSJ1VJWwI0PpVl TW43AknusFB78uDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716847258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42tiQSBEE6UjG05pgPxLAM6u1S+l8SL+xLr4Zfg2Mb4=; b=JDfEIXCqLGjIFAywSw1Pa3kyKQSV7ra6esgQyNFz/5oS62ibCi4NdV0+JKtYgVS4SveOgu vY7LZ3RQlj86qzaC7rfzqxQZjSc7KxLhYgIqrgIILRjAgK5Bdt037zsWbT2pPVrlgUfje/ +2kHDFBZHPbNezjb4LZq7DjGVLPUJj4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716847258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42tiQSBEE6UjG05pgPxLAM6u1S+l8SL+xLr4Zfg2Mb4=; b=gRbzX5UJDedE1ktUVw+TnU1kQBVZMFZXhOfTNMP9eD7/7vFVpsz3/WNWJSJ1VJWwI0PpVl TW43AknusFB78uDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2E49B13A6B; Mon, 27 May 2024 22:00:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nJxPCZoCVWZSFAAAD6G6ig (envelope-from ); Mon, 27 May 2024 22:00:58 +0000 Message-ID: <61e940bc-abdb-4811-932d-ef5b7c7dd80e@suse.de> Date: Tue, 28 May 2024 00:00:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: fix unresolved test in gdb-caching-proc-consistency.exp To: Andrew Burgess , gdb-patches@sourceware.org References: <8d696883107c9d3b44aa35ee92d1d5199a12f93d.1716845155.git.aburgess@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <8d696883107c9d3b44aa35ee92d1d5199a12f93d.1716845155.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.29 X-Spam-Level: X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/27/24 23:26, Andrew Burgess wrote: > When running gdb.testsuite/gdb-caching-proc-consistency.exp with the > native-gdbserver board, I see an error reported: > > ERROR: gdbserver does not support attach 2036113 without extended-remote > > and a test is reported UNRESOLVED: > > UNRESOLVED: gdb.testsuite/gdb-caching-proc-consistency.exp: testcase '/gdb.testsuite/gdb-caching-proc-consistency.exp' aborted due to Tcl error > Hi Andrew, can you double-check that you're still running into this problem? My understanding is that this was fixed by commit 9839849c0c3 ("[gdb/testsuite] Fix can_spawn_for_attach_1 consistency check"). Thanks, - Tom > The problem is that we are calling the can_spawn_for_attach_1 caching > proc directly, rather than through the can_spawn_for_attach wrapper > proc (which is not caching). > > To fix this, in gdb-caching-proc-consistency.exp, I did consider > having 'test_file' spot 'can_spawn_for_attach_1' and test > 'can_spawn_for_attach' instead, but that runs into problems as the > 'test_proc' procedure does expect to be calling a caching proc, not a > non-caching wrapper proc. > > I could make 'test_proc' smarter, but in the end I just opted to > replicate the condition checks from 'can_spawn_for_attach' inside the > 'test_file' procedure, there's only two of them, this seems like the > easiest fix. > > If we end up with more cases like this then it might be worth > restructuring things in here to better handle wrapper procs, but for > now that doesn't feel necessary. > --- > .../gdb.testsuite/gdb-caching-proc-consistency.exp | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp b/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp > index 572ffb526ba..5312b395283 100644 > --- a/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp > +++ b/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp > @@ -91,6 +91,14 @@ proc test_file { file } { > "target_is_gdbserver" { set setup_gdb 1 } > "supports_memtag" { set setup_gdb 1 } > "have_native_target" { set setup_gdb 1 } > + "can_spawn_for_attach_1" { > + # This replicates the checks found in > + # 'can_spawn_for_attach'. > + if {[is_remote target] \ > + || [target_info exists use_gdb_stub]} { > + continue > + } > + } > default {set setup_gdb 0 } > } > > > base-commit: bdc10cded85aa8995e80394099c9e542b6172979