From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13996 invoked by alias); 12 Oct 2017 16:06:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12962 invoked by uid 89); 12 Oct 2017 16:05:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Oct 2017 16:05:57 +0000 Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.183.57]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id EC.02.26775.2E29FD95; Thu, 12 Oct 2017 18:05:55 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.57) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 12 Oct 2017 18:05:54 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.61.67] (192.75.88.130) by DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Thu, 12 Oct 2017 16:05:50 +0000 Subject: Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c From: Simon Marchi To: Simon Marchi , Tom Tromey CC: References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-5-tom@tromey.com> <79955c67-567b-7bc9-c238-9245c9ab1911@ericsson.com> Message-ID: <6226d3be-17c7-aa69-bdbf-efe11ffc1b5f@ericsson.com> Date: Thu, 12 Oct 2017 16:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <79955c67-567b-7bc9-c238-9245c9ab1911@ericsson.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MWHPR08CA0056.namprd08.prod.outlook.com (2603:10b6:300:c0::30) To DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa709ab5-92d7-4e65-33d2-08d5118b1c43 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DBXPR07MB317; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;3:mtu8sjPYQVBsv8qoUgfqofcwKY3gzMruZBHWgmILNxNZqcHsELwr69o+1pizr0CrUF7J4fYH5bjBbBy51KO2demQo3fYOpWqe7dyJQvhPUzpFGTFa+wMTIbFhcb3bjHYxANy+O1kl1/S+jG1l0N7PfX1YH2Z5Kcs7DLnlCMh6sCJm1fy6x/mF4RR/tE2n8QpPVFeZPJz0Xw4G/FGhcSwX87UVfdTz3uvoAnUppX8xwLXn+du2ohiDkPHdsQEc5td;25:ruI55fQcYT9q+RPVY4isMVCJETS19zVO4kXrjB2J6K31mo1HFZcHuzY3kUp66OfYPgSai19G4YCiMgPei+PBF5k0nJKNzx4yEOxiSr+EYGg0ofemgtzeH7LdstE4PnFqkVLf5WyXoTuK5atutqJpPhxCS8e44rcARK411WF0cU3zR4qVEkDR1JWSODLbax3KXKIAXvKIWT7ROqCK7Gu7fYYpl+sccpRHxHCqXDROPEO3htxvYLJpmoQtgGv22LXkXhSKOLTYAU3qOJO9tgGva1M5/9hJ1SfBNwfGGcDtdh271z+qKUN+B3KCz8eAcZvXDf6hIERWpU6+dUSnzNHdsA==;31:apUCTbvzukFJOTCobyt7Wq54HkjQX/IWI+nOXvO8ycsIWN0PaSomu9nRcysgD+rUYnQys+cE2YpMDWcVsIlwK2d3m+sBznhPg/InwPYE0FQ5HjUbTTXBlKFTpyVg1wK97SDrbhkJ3qjlKTGr1yN8TSNuL/I6DGlpvxL44wOerYo15L3j0qcbS8ygo0nnhn+QEHuIJDFdrlDOm+OD+1jWQR+SEz80LQpHfxPaGb4vHfg= X-MS-TrafficTypeDiagnostic: DBXPR07MB317: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;20:85kGYZpvyFMMcCUYjZNbKYD4FSVJmdjbHCtg0WAIEm9PlqI5fWTMD413aRjCt/YDai6hQnFBOyYXrqXwW2kdQIYvDLD/xQPWoLbSwcEIpZ6bcnRN18eLxqkP3ChSDIxHtPdU86KWrs93iBNhZXwysN2pSC21GSwKQgMFwFsjARpiTY1x7ttH52ihABPSzRyiOE87dyocRYu6OUcet0gLX8MiSoaevGG45fR0Pl2FsutioNzYj2MlMO9RoeEOIipBkMZ9uQLDsQ9DXWZlZ4cqqmRckidQ5saz4jDr0V0R3sG7N3dS2tySEp7qJYhVQTTVc8GkueAiwROvB4kaSlQxT2+sUtbKuUlnWw83en7bP8yEoctqm4usnbtVIbuKeqdQixhSx8cZaXqQfOF2JHd02/RC6UDWO2r7DQsCcF1sHx6UOUNtKpaQVXBcHryBxqUxTMzSG10xi8LmGi3K1Mirv8nYflWcmg/8cR18JDfan9FH5Sx6rTAT3V+7FZvekv+R;4:gpFvyT1GFlxXT3xYkY4Msv+ubHmXz/ebDnDd4uaygdThmsRrP5HKDoj2+3t6x79b3aCeugj556esdwo3i6RGmRDrRoWlyGecxnRCxj21GroQBWn8MRzharWD0oFnJXfHgLvFLcH+Fbe/Sl1kjihyGboxBotCffhq5rVAIJ6klGYFFanl04G4Y0vu8L+3i0YVFfKOgEOQJFuR3bZXIdXfB++NHaMxf9bxGWsSxYAtbBIkRaGovc82Ckr7SxnKVl6xW52Z+p+F86DReQbcYh8KXffoYNpKneR3scfEzaN9lHs= X-Exchange-Antispam-Report-Test: UriScan:(131327999870524); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB317;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB317; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(346002)(39860400002)(377454003)(52314003)(377424004)(199003)(189002)(24454002)(305945005)(5660300001)(8936002)(36756003)(81156014)(8676002)(81166006)(65826007)(25786009)(101416001)(54356999)(76176999)(7736002)(50986999)(33646002)(97736004)(53546010)(4001150100001)(23676002)(6486002)(229853002)(64126003)(2950100002)(6666003)(68736007)(31686004)(93886005)(105586002)(2906002)(50466002)(4326008)(65956001)(49976008)(65806001)(66066001)(478600001)(16576012)(110136005)(83506001)(58126008)(106356001)(2870700001)(189998001)(31696002)(53936002)(316002)(6246003)(86362001)(6116002)(3846002)(47776003)(16526018)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB317;H:[142.133.61.67];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMTc7MjM6L0E3UWNTd1E1dFdOKytxcllDZHUwaCtndEN5?= =?utf-8?B?RG9wQ0FoK2lVUHFKZm0wR0dPTkZMMUM4MXN5ODVYMHdrZUNMM0phMkw1bVJY?= =?utf-8?B?OS93RFlTM1gvcCtkZ1Z3YW9tWGJaakQyTWZndXlmWHFIT0UyTXhQVGNIVW8w?= =?utf-8?B?d3JkN2tDdGxYaTJESy9RYzJQVDdMZWZYZDhUTzhINnpBSk94OGhTelZVY1U2?= =?utf-8?B?L1NiZ1ZFYVZpcjRXN0VLMXdYZ0dVMWx4eE1YQ29mT1BVV1l3WjRKMkg5OWl5?= =?utf-8?B?cVduNmxEbnVDQzdMU0NidVdhaFl5aFZWSEg4T0dMa1p5QjZ6SXEyRkoxdUFs?= =?utf-8?B?T1BzTUM4bWNaU3NaNWM3Ni95Ris0WDFzSDkrWXdWaWdGbGFIN3Z4bjR3V2JV?= =?utf-8?B?elRWL3cyNUorMGpWb2dQL3pHUitmbURMRG0yQnpMeGtUWDMyUXh3Zis1WCsx?= =?utf-8?B?MzNkODdiMlpVWTg5Wk1UWHNueE00WWVTQk8rcGtMS2tRQzJrcTI5RHZFenAr?= =?utf-8?B?VFhpdWdKbER4TkljSHpHbVorcEFCR3phQXRYak9yRkl2cThETmdFT3lqbEhX?= =?utf-8?B?a1lwdFQ4MG5aU3NvdHRvYjhjOEg5QWp2MXBUWkh3ME0xSlRBUDErNm1zaGZv?= =?utf-8?B?WnhrQ1pyN1NNaWQvUFVvS1N0S3JDQzIxY21WdXhZaWo3MEtSb25CQTVqWnVX?= =?utf-8?B?UUdrc3prVHBCUmIvWTlIWUxEOUpYUnp0U0RBSXJPczFFYzRoOS9zZENrUDBK?= =?utf-8?B?RkJpaGtJajh6YVN2dU9KWUk1QnBhUTJXbjdSYi8rVUpGOEJNSUJGUFloS0tl?= =?utf-8?B?OGoxLzNXYURmb3duZlRtTmJSYUI1bXJES3FYNEU4UzN5Y1lUOXU5UHowUmFR?= =?utf-8?B?Z3UwSVlsejhnY2thd2ZmUTVkNSt4empnS0RLcGJxY3N2VmJDcngxcmluY2FQ?= =?utf-8?B?WUNSb2FLMDQxNHJTWC9TaXl0ZnRFMGZ1NGY2RW9jdWtoSHIraUg0WVU3MUsr?= =?utf-8?B?K0pvT1hmRC9oN2dVajVOYU5IZEJvcm0xTTBPbUFOMmhUenh2c1grQlBxY3Y4?= =?utf-8?B?a3p2VUdnVVhMOXc2SkZmelU3eW1UMDc1emp6RmRrVmdmRGhIRXRpMjJZOFZy?= =?utf-8?B?YUoxekw2b3JyckhDVmFRWHlyWkZzcjE3dXZ2QnpHUlV3Wm5mVWF5TmlUWTVs?= =?utf-8?B?L1pRWUMvN3BOTmQwS2JHbDh2V2FpNjBIaEFRcFFvOXl2ZlVSVXJvL3g2NEpI?= =?utf-8?B?M2NUL2NWRGxHdnhaSkdTQTRJUkdOSTdjQ042SndPZERqdWdIdjlDYWMwUnpK?= =?utf-8?B?SHgxWWdDTlc0eXNPbU9RZjE4aSsrazJqMkRzbHFqS1pzN1I4dDlBWnJkSFV1?= =?utf-8?B?S1l5ajd4c2FpdVpUYjYyanMyeHZvS2NzZDNKeGFzVXNXcDBwcWdqMGpNaFla?= =?utf-8?B?YytTR3YvUldtbHRMbEx3eThQaXJXcVJodzZ5S0hTaFo3QkpQTmxhRHFCNFRz?= =?utf-8?B?a1ljcDJ4T0dHWXZKd28xM2FvK0plS3N6Tk5yUUd5ejBCeE1mUER2NjhNOXNK?= =?utf-8?B?K3BjSGFLQThacXRzaHRYUVArb2NZVWs0ODJML0c3UTVDaXlZUXptZmIwVStr?= =?utf-8?B?eUFmNUV5NTNxOWIyZDlhd3pSN1doSUxFQkI1MUZ5WHdkc3N2MmhkSEJPUU50?= =?utf-8?B?Y2JHTmxLZkZDcWZPNTZNYUV1S0tNS09IL0ViNEgyVlBFdWYyb1I1MFhtT1Jm?= =?utf-8?B?Y1lKakQ0SWJuSGFOZnpnNXJGWkw5a0ZwVnFvcnVIT3Q0bzZsV0llNHJvMDJl?= =?utf-8?B?ZGVHWFN6TlhzT3J0M1JQTGtFT2dtYnMyanlYRTFIQlhCTjBtRzRMS3NaeXhC?= =?utf-8?B?Z1RzUC9vUCtCbFFHY01uZTkxcjMxUzhwWjkxWklDOXF5bUpsUHl1N3VERUFD?= =?utf-8?B?cHk2ZmNLSHNaQWdZSFlrWGE2SE1CWVh2bnBPNUJLVUloSzREaTk1aTR1cnZV?= =?utf-8?B?MWE3T0VkUGhyd1E3c3BwUjJuRkhqNVpBdndnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;6:JpuC2cwOqikqdE6W7cHfP4hdszSg+xmVl0w4Xc6C/R/mApHfNlkuG/09NJWiENHGEtnBENXFG8ozxLyfrdtwLdEEFO4nD8gIdcWV64xoN8y0IfpohSrEWx/IquW3v87ICI72siNGbhsW3BUeyiDm3wPmoPU1TlJRxnHAQsQKmiQwqWI8undEDNQEEp1XZd+YqJNUFDLFFuKk1cSGqDkwvKpBsDiRLjmhuQKC3wPh07PkyKKEg3cYNbI2z2TWk+EjLIqywLX6bzKsjVMeWvbOAMxkjg0SzG/I74sMqq0lBGgdHRQuVUn2FQ3idKnEpmy78BHCQyF7NMTTNbrmNX08KA==;5:FNHVAZqHacntAuL4wVDMN9ARJdPDLVIaVdEbzdIxIRfgPyNjfYrtMX1Ybo10RKvK2yoDkyuNTD6+tGVFk8fuNdMFDSSELMc+d+zY3UAM/3EszWgj+PgYn4AIhGA54/V8p4g5suOWvWmU25Jp8weXAg==;24:OO8/aH06oqg9GWHGUNSshAu8tKhLaDZHHWJ6SEW7z32q+uFVx5PzXvcOZUqB+LJPrxsUBtEmK2OfdcPtTUJ3QyMU/SV1oW0S/XovB18vWdA=;7:zZvKBCr+AipQMKHt/T0CS/e8EfQfZaC/veLEs++I8gF1WWdF54aPKOPt9Ri145mx5HBWI2JRiXWXEY/wAbG/FBS+ehKjgwe80vglPOH8e0Muk5jQLHMXXEKhA+/A1AZ5r0lOxlrqCu48+2JI8LY3oD8wrOwxWrOi8jstJ5v//hXaGuuGptWsHvX94xLIRoOBoy489O+w7LSpVlrjg2ake72FwtaW7uNR1W1Yio9Q07Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 16:05:50.4304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB317 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00312.txt.bz2 On 2017-10-12 11:36 AM, Simon Marchi wrote: > On 2017-09-09 02:35 PM, Simon Marchi wrote: >> On 2017-09-09 17:35, Tom Tromey wrote: >>> This changes one spot in disasm.c to use ui_out_emit_tuple.  This >>> patch required a large reindentation, so I've separated it out. >> >> "git show -w" does wonders!  The hard part is figuring out if there's something else in this big function using cleanups (and therefore if the cleanup variable should be kept). >> >> Anyway, this LGTM. >> >> Simon >> > > I found a regression, bisect pointed to this patch (which makes sense). > > 1. Run "disassemble /s" on a small enough terminal so that pagination kicks in. > 2. Type q to quit pagination. > > I get: > > ---Type to continue, or q to quit---q > /home/emaisin/src/binutils-gdb/gdb/ui-out.c:344: internal-error: void ui_out::pop_level(ui_out_type): Assertion `current_level ()->type () == type' failed. > A problem internal to GDB has been detected, > further debugging may prove unreliable. > Quit this debugging session? (y or n) > > Simon > Mixing RAII and cleanups probably changed the order in which the uiout elements are closed. In an outer scope (likely do_mixed_source_and_assembly), some uiout elements are opened and cleanups are installed. In pretty_print_insn, some other uiout elements are opened and RAII closers are used. When typing 'q', the cleanups are ran, just before the quit exception would be thrown. The RAII closers have not ran yet, because they would be when the exception is actually thrown. The solution would be to finish converting the uiout cleanups to RAII (I won't have time to do that in the near future, feel free to pick it up). Simon