From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id C9491386F41A for ; Mon, 12 Oct 2020 14:46:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9491386F41A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x331.google.com with SMTP id j136so17801402wmj.2 for ; Mon, 12 Oct 2020 07:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nDFxPdT/ULn3GrDABHovwioWq4BlC5vhklu7uofcdbM=; b=UoEnQ5j2Hs0yo7I/aZ9FOpneQ7LJ8GegoJJtw+kX4eI/+dclFehI3aibUCCRWTRmsh lxHm/DLn8XyZzOVLuc+98h8dX7l8mtLg56byzc9bd930Pd7KOWgyiSS40gbIX/tZa716 g/oTlcpsMoYKk4np3FcZD7o1UuothzRPxLiG9LsiGog5hBKrfaLVcSoYYHfott+BenYj zyCS0lPXzGKpMjGNVS20opryERgb81dmwPl3GRfrBk2FLpOOaQplR71Qk8z/SDat94rd zz77EZoh1T8+na/e2u9cllo9vJiFhkdyLszR1dc+2uRXzUU7seiE2CwILa3MhmmDwC+J D42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nDFxPdT/ULn3GrDABHovwioWq4BlC5vhklu7uofcdbM=; b=b+F2HYE5iczsZc2q8gJBW4ut7fyi3LEGAWiCvGbM4A3Eev+RIhOxQcGWHKTqclwgkA PZIaPxvpnzYqk91/lF+Ts4SSUszwwi87PH+jz31LEO8PgbzaeYVKM95sJWUjww4I095V aUqktJ+70oBgkZ8bZqpWZkr25SIXxMWjX6lRrFXT0DxOZZop9qD58O+BKcSKdB5IAkVM 96kBT3Bmc4wL6JsY552C+7RgLD6+rgKYdpiHs+INrL6A31VCBBYZZgPRDdyYuhKFoGqM MlZ7uDiIZ5G9CeAANrgHpRlUO1T7q2mqhAIvzBBZGQq56bT1e8dpmut3vAJAtlX5cq7Q 6RCw== X-Gm-Message-State: AOAM531xjFWiyKONg+o+M4jmMJRcTNaZl7lTyMYPoBgPOA2GfTbKhXza RzNbFR1H/3/ZBujuIGq21x4gVZyujoRaZA== X-Google-Smtp-Source: ABdhPJzR4cMc6gh1aYkjWDQkc7sLyhGA4Uo7pQBEXLU+scrnzaVVJTy7o/ieu6+lg3CqwAJp9eLm6w== X-Received: by 2002:a05:600c:247:: with SMTP id 7mr10725744wmj.7.1602514011684; Mon, 12 Oct 2020 07:46:51 -0700 (PDT) Received: from localhost (host86-130-161-39.range86-130.btcentralplus.com. [86.130.161.39]) by smtp.gmail.com with ESMTPSA id d7sm21977130wmd.48.2020.10.12.07.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 07:46:51 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 8/9] gdb: Improve documentation comment on language_defn::print_type Date: Mon, 12 Oct 2020 15:46:36 +0100 Message-Id: <623087c335aa21db719f4f8f43a5d9ab828d7419.1602508908.git.andrew.burgess@embecosm.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2020 14:46:54 -0000 Improves the comment at the declaration of language_defn::print_type. There should be no user visible changes after this commit. gdb/ChangeLog: * language.h (language_defn::print_type): Add variable names in declaration, and update header comment. --- gdb/ChangeLog | 5 +++++ gdb/language.h | 12 ++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/gdb/language.h b/gdb/language.h index 106d7667527..951343fd9a3 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -333,10 +333,14 @@ struct language_defn return nullptr; } - /* Print a type using syntax appropriate for this language. */ - - virtual void print_type (struct type *, const char *, struct ui_file *, int, - int, const struct type_print_options *) const = 0; + /* Print TYPE to STREAM using syntax appropriate for this language. + LEVEL is the depth to indent lines by. VARSTRING, if not NULL or the + empty string, is the name of a variable and TYPE should be printed in + the form of a declaration of a variable named VARSTRING. */ + + virtual void print_type (struct type *type, const char *varstring, + struct ui_file *stream, int show, int level, + const struct type_print_options *flags) const = 0; /* PC is possibly an unknown languages trampoline. If that PC falls in a trampoline belonging to this language, return -- 2.25.4