From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 22A5A3858CDB for ; Wed, 21 Sep 2022 18:13:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22A5A3858CDB Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6B7391E0D5; Wed, 21 Sep 2022 14:13:32 -0400 (EDT) Message-ID: <623a8aa1-e617-12f4-3fc3-70924eca1cde@simark.ca> Date: Wed, 21 Sep 2022 14:13:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/3] gdbsupport: move include/gdb/fileio.h contents to fileio.h Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi References: <20220826195459.2540898-1-simon.marchi@efficios.com> <20220829162926.3752040-1-simon.marchi@polymtl.ca> <20220829162926.3752040-2-simon.marchi@polymtl.ca> From: Simon Marchi In-Reply-To: <20220829162926.3752040-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 18:13:34 -0000 On 2022-08-29 12:29, Simon Marchi via Gdb-patches wrote: > From: Simon Marchi > > I don't see why include/gdb/fileio.h is placed there. It's not > installed by "make install", and it's not included by anything outside > of gdb/gdbserver/gdbsupport. > > Move its content back to gdbsupport/fileio.h. I have omitted the bits > inside an `#if 0`, since it's obviously not used, as well as the > "limits" constants, which are also unused. > > Change-Id: I6fbc2ea10fbe4cfcf15f9f76006b31b99c20e5a9 I pushed this series. Simon