From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 79DDA3858C98 for ; Wed, 28 Feb 2024 04:38:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79DDA3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79DDA3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709095131; cv=none; b=BUvtGjomgCWjW5DdNzhW8dASL/KyxQKtPtZ6dJcUpoMmHO08QZKs+4E81g4f9tDkJU7daIYzxh7JkXtkoisEvbC4swe4IpN3VcSJXjM1pfjNe1YhVP2WXt8Rss/sr1aDk5ATaZKCIXZpYEXVvuMmECxbPMMYGrfcj++2hdrsm0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709095131; c=relaxed/simple; bh=/Wqx0d+xhoxig7KGuFRqAejkIaDahMnF8Li/CHB0LUg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Er5A3VGXdoBxYzDyzw70oIxEUx0CXR3FAZS4cOFAwecKvWsYtbx78sPUWH3p3Xz8koDFA6s4fq/Xpjd1WyZg0rnvo334NGsisPl0VSZjnwvBrCjm7B/4d/x4GtVycN3CCuvSM3XGsDk8IBan9I+IQD7DQP7Mzf2OrgmZnG2ODvw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1709095129; bh=/Wqx0d+xhoxig7KGuFRqAejkIaDahMnF8Li/CHB0LUg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=mF6M4ceN7ybOgJqk40BMTXnrjSfl2w6uUcvAgxkaHwZCa6cUfY+JvOXFz9TQrlh0O CahogNk184navYlFmNRRvcDd8uLy0fmr5g6UqU7ue3XEXc0MQPEmAZMlVxW795Pay2 EZxvhr+/YaOAmwsH5fRFgBnzG5ql7anz7BYuT7eo= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8FB9D1E092; Tue, 27 Feb 2024 23:38:49 -0500 (EST) Message-ID: <624e7ed2-efc8-44c0-b6d8-d0fc67af7e6f@simark.ca> Date: Tue, 27 Feb 2024 23:38:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] aarch64: Use aarch64_debug_printf in a few more places Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org References: <20240227222043.10218-1-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20240227222043.10218-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-02-27 17:20, John Baldwin wrote: > No functional change > --- > gdb/arch/aarch64-insn.c | 51 +++++++++++++++-------------------------- > 1 file changed, 19 insertions(+), 32 deletions(-) > > diff --git a/gdb/arch/aarch64-insn.c b/gdb/arch/aarch64-insn.c > index 10818757cd4..3e40a51c443 100644 > --- a/gdb/arch/aarch64-insn.c > +++ b/gdb/arch/aarch64-insn.c > @@ -98,13 +98,10 @@ aarch64_decode_b (CORE_ADDR addr, uint32_t insn, int *is_bl, > *is_bl = (insn >> 31) & 0x1; > *offset = sbits (insn, 0, 25) * 4; > > - if (aarch64_debug) > - { > - debug_printf ("decode: 0x%s 0x%x %s 0x%s\n", > - core_addr_to_string_nz (addr), insn, > - *is_bl ? "bl" : "b", > - core_addr_to_string_nz (addr + *offset)); > - } > + aarch64_debug_printf ("decode: 0x%s 0x%x %s 0x%s\n", > + core_addr_to_string_nz (addr), insn, > + *is_bl ? "bl" : "b", > + core_addr_to_string_nz (addr + *offset)); You should remove the \n, I think, the _debug_printf functions adds one. Otherwise, LGTM. Approved-By: Simon Marchi Simon