public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 6/7] gdb, gdbserver: update thread identifier in enable_btrace target method
Date: Sat, 22 Jan 2022 23:02:36 -0500	[thread overview]
Message-ID: <6255abac-5141-8ff2-2217-b208b68795ad@polymtl.ca> (raw)
In-Reply-To: <20211202071525.3046816-7-markus.t.metzger@intel.com>

> diff --git a/gdbserver/gdbthread.h b/gdbserver/gdbthread.h
> index 7c293b1f89d..26a3bc86a25 100644
> --- a/gdbserver/gdbthread.h
> +++ b/gdbserver/gdbthread.h
> @@ -21,6 +21,9 @@
>  
>  #include "gdbsupport/common-gdbthread.h"
>  #include "inferiors.h"
> +#include "target/waitstatus.h"
> +#include "target.h"
> +#include "regcache.h"

Are these spurious changes?

Otherwise, LGTM.

Simon

  reply	other threads:[~2022-01-23  4:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  7:15 [PATCH v2 0/7] gdb, thread-iter: handle null_ptid Markus Metzger
2021-12-02  7:15 ` [PATCH v2 1/7] " Markus Metzger
2022-01-23  2:21   ` Simon Marchi
2021-12-02  7:15 ` [PATCH v2 2/7] gdb, btrace: rename record_btrace_enable_warn() Markus Metzger
2022-01-23  2:22   ` Simon Marchi
2021-12-02  7:15 ` [PATCH v2 3/7] gdb, ptid: add is_lwp() and is_lwp_or_pid() Markus Metzger
2022-01-23  2:36   ` Simon Marchi
2022-01-24 16:32     ` Metzger, Markus T
2022-01-24 17:04       ` Simon Marchi
2022-01-25  9:40         ` Metzger, Markus T
2021-12-02  7:15 ` [PATCH v2 4/7] gdb, btrace: check inferior_ptid in record_btrace_target::xfer_partial() Markus Metzger
2022-01-23  3:22   ` Simon Marchi
2022-01-24 16:58     ` Metzger, Markus T
2022-01-24 17:22       ` Simon Marchi
2022-01-25  9:40         ` Metzger, Markus T
2021-12-02  7:15 ` [PATCH v2 5/7] gdb, btrace: switch threads in remote_btrace_maybe_reopen() Markus Metzger
2022-01-23  3:24   ` Simon Marchi
2021-12-02  7:15 ` [PATCH v2 6/7] gdb, gdbserver: update thread identifier in enable_btrace target method Markus Metzger
2022-01-23  4:02   ` Simon Marchi [this message]
2022-01-24 16:40     ` Metzger, Markus T
2021-12-02  7:15 ` [PATCH v2 7/7] gdb, remote, btrace: move switch_to_thread call right before xfer call Markus Metzger
2022-01-23  4:19   ` Simon Marchi
2022-01-24 17:07     ` Metzger, Markus T
2022-01-21 11:41 ` [PATCH v2 0/7] gdb, thread-iter: handle null_ptid Metzger, Markus T
2022-01-27 12:49 ` Metzger, Markus T
2022-01-27 17:04   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6255abac-5141-8ff2-2217-b208b68795ad@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).