From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30135 invoked by alias); 2 Mar 2018 15:15:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29986 invoked by uid 89); 2 Mar 2018 15:15:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Mar 2018 15:15:38 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w22FFV8k023832 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 2 Mar 2018 10:15:35 -0500 Received: by simark.ca (Postfix, from userid 112) id 6ADCB1F42F; Fri, 2 Mar 2018 10:06:59 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6A25D1E072; Fri, 2 Mar 2018 10:06:54 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 02 Mar 2018 15:15:00 -0000 From: Simon Marchi To: Eli Zaretskii Cc: Sergio Durigan Junior , gdb-patches@sourceware.org, simon.marchi@ericsson.com, palves@redhat.com, brobecker@adacore.com, christophe.lyon@linaro.org Subject: Re: [PATCH] Conditionally include "" on common/pathstuff.c (and unbreak build on mingw*) In-Reply-To: <83h8pywqku.fsf@gnu.org> References: <20180301202005.11563-1-sergiodj@redhat.com> <83h8pywqku.fsf@gnu.org> Message-ID: <625c70bb51eb88e5448d935d523d5919@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 2 Mar 2018 15:15:31 +0000 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00061.txt.bz2 On 2018-03-02 08:32, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Simon Marchi , Pedro Alves >> , Joel Brobecker >> , Christophe Lyon >> , Sergio Durigan Junior >> >> Date: Thu, 1 Mar 2018 15:20:05 -0500 >> >> +#ifdef USE_WIN32API >> +#include >> +#endif > > Isn't USE_WIN32API specific to gdbserver? If so, perhaps it's better > to use __MINGW32__ or _WIN32 instead? I see it defined in both gdb and gdbserver: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/configure.ac;h=698fc7b83456f8c5a63ae0050dc8ec65069290f7;hb=HEAD#l1908 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/gdbserver/configure.ac;h=99801681ff47ee8dcd9ad2e5ae282dcd113c83e4;hb=HEAD#l281 Simon