From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2048.outbound.protection.outlook.com [40.107.116.48]) by sourceware.org (Postfix) with ESMTPS id 4A47A3856241 for ; Fri, 12 May 2023 18:50:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A47A3856241 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RtJVBUC+wQL/Z1BOhSwZy4v9WuXkq368xSCneupU/h5yupgkSsH0rIYBdoBS2uLHPaepH1qDkqonE8vpoSUGSyZLwOhwrqeMbM2W5Q5iPjEfoyE+3mVzndBInjriCuZeSCtbJxgzFc8vJL63bf+AfQfqOUgUOqn7IbCaBaWNGoBhXWz2mVDs4wQJ7XjvznK6241ywi9iYnbRbtS2TMjCOXBNg1Gi4U9A6fqDrVPt6RsUePZSck/TGFa8aVR4fs0+vnpKhKszhCojqwFhliqpWYYAqKNJAiNhJ1xGmc/VKRmMGKa6k/s7kmOkDHqzYREGyqVrISCkdAGBUD3KX8Aj0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=44DB1VX2wD8fwFn9cpvtWv8r5TkpWiPhQwN6a1ff2o0=; b=lOpRzVd2oAHdgOuSgInoRTROvlubxfeltEWm7ke5Gn9IVxMAJ1dcsTwEHe2IOXw2NJVEVl55rXihlH4oxGQA8ue/TTFk+J/tJwQ6P669Gq3RtKKY50TCzLCvmG2iG+hmDRz3APnP/YkXCgQA3K4NaXCdFSFmJM/tKkG3uwzNY4VD0Z2TVHFX9qTNRpjL399U5zzoBRhIKe9FTucnBOSm7DbiWtvgW7ipxXyVslgRa316GkJnd4JM4EUKSugriiKpCpSsmLmLQp7U3icEGvr8hy8ZfZwJ8HShCiNFEZrx4ZxvogxRuNCja7HeujeVRRPwwhsb5BsoKj3lzAsvjk0hvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=44DB1VX2wD8fwFn9cpvtWv8r5TkpWiPhQwN6a1ff2o0=; b=BnF9Q6kLCK+BrLY1bhwRChdeYGuL8YfgPN57+vMGdw5ixQvb/isIJhkzmK8n8Z21Q361fDpvOr4uNKsPB0PBjAqbuyMViOerXpotKVrOeVhYLuwvcTn796THKcdjVhKxft4r4yAS42FP3O2JpACOE0VsucYM/OPW2D5NzKVtIkYVNYGO4cnzWew349ZYZu01KwrmsaoHLOE3GKWLT9EwrKY1B/ihPT/ZQNAJbejFKtN9aznPJWyY9pbXv1UceS73omXn3Fz+MSdipjVpoRPmZXN5S3FWhBOSo6UZZ7WB5vqxow6WPdJTPJDjA7A6jK1dYBzvsl2RTtG1ESvyXkI4bA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB6103.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:36::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.20; Fri, 12 May 2023 18:50:39 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80%6]) with mapi id 15.20.6387.021; Fri, 12 May 2023 18:50:39 +0000 Message-ID: <62600d29-11cb-2cb4-912d-bd4928a141f7@efficios.com> Date: Fri, 12 May 2023 14:50:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] gdb: remove unnecessary call to std::string constructor Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches References: <20230511173351.41358-1-simon.marchi@efficios.com> <87jzxd2xvk.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87jzxd2xvk.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0106.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:83::18) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB6103:EE_ X-MS-Office365-Filtering-Correlation-Id: a2318ae6-165b-4f97-e113-08db5319c767 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sHgZpb9EBH48GaqlIJNQCDNnPEXsS480zaXs7gWY8rLpclf3uvjUmErWFaTmE+gF4uxvzsqZ6h1Rh0WdmwwRYOU1ovJKu0heshz+q1RhX8psWMAk1BsRTq9vVt6RVWJfNR6OrbemzJGcA+/+nlOWetmrzwRkMnAtTPOfNBea4+TVEoy2dp3Zg3t1Lj/fb1dDZjM8dPmsScoHRGwEU5gMlMHvmRiLpcXzB2jf1lH6XM5/ZDByE7Dm1L01jOxBIdYzT72a0DfURIOjZKy9h3gN49qheuDzZ/ZaiGPA2cmBAaJuDK3CPsko/R+UShzaULZ9vy0hBbLawLsVthfbRLVaN/TGFYWvWRbpj5kjWbBMrdHuAUXn4Daq/BaeA9AbQDHnhvTIGVPoBxMf5J14zZot9/JilurwlBeznFTQYqtBEM4lxw/5dWn4yNNtJLfWvh5gRK+ZjG8qbDz9zp8QHSRE9+QBLT7Esui9m7OfQi/HY0Y97Kau1FbP5vpj2hSP1oSyNIZlx2Y4yzhhCi4y6nZnZ4lhW9ujkN7hXq91OkAwzjVQ/iYSQsoUgxCEZVAGZoz7TPxii/0WpCGrmmbSF8ZdyUL02tfqn/mHWh1tXrYJSaFb+WXWWbaqclBRFkpbnMH++kdIlC4IDsrvGQSpnn9Tnw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(39830400003)(366004)(346002)(396003)(136003)(376002)(451199021)(5660300002)(31686004)(110136005)(44832011)(478600001)(6486002)(8676002)(8936002)(41300700001)(316002)(26005)(53546011)(6506007)(6512007)(66946007)(66476007)(66556008)(4744005)(2906002)(2616005)(186003)(36756003)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDE0WlJ0dG1OZkdGR2lnQ0p4UG5YOUNDMmlwOVhYaElRaERPbWZJOGplZENR?= =?utf-8?B?aUppdFJuQXNYTnlFQWFRSEdobFVXTFRQRFpXTXlaSmtTZDk0UFc5WGFrUDBi?= =?utf-8?B?Tzc2amd3TFR2ajFzdk1oOHAzZzBxWjJaYWRrZzBwR2lDVzFVbEhCUk9DSjBQ?= =?utf-8?B?RDZMNFZUaTZ3VzY0MkNDSzRjVXppSU55ZElNTEpJRDhLdE9MMFluUC9mZllV?= =?utf-8?B?SVBoMzRJMktpaGtreDBOSGxNellidE55dlBTdHdhS1RZcUt6UFRaQkJYenk1?= =?utf-8?B?YTEwSWxOdnNyNitQMkdVcmg4MTRHUWJPSmJTN0lVMVhaZkNXcXIxQm9aOEwr?= =?utf-8?B?a1RYNk9OVTlKQlFCYk5YQnJQTkU0TWI0UFc4WEkyczhrMkdMZnI3MVV4dGRn?= =?utf-8?B?OE9FcmJCeFc3emJLTWVIdkhwQ3d6ampWNFlwMFNqTG1uY2NzMXRvZTdSZ2Q4?= =?utf-8?B?SDhPamZINkxzN1lIQVBOd1k1MVlseC92Q2NGSU40cEJydXIxUFl6MnZISWlv?= =?utf-8?B?WVZkMmhETXpGWFJFc2NPVE5rMzVTbTRjYkp1a2orclB4VWVZeHc3Z2dSK2Jn?= =?utf-8?B?QTIwMEpCSHp5ZDBrWlF3MWdMUXh2MHBwamJzMkJULzhxMExkS1cxakNrN3Iv?= =?utf-8?B?ODBibjkrK1Y4MFVWcUMvbFZLTWpEc0JsR0EwSjQ0Ny90eFF2aDRleE9OS0pn?= =?utf-8?B?elg3K0dkcmFPcjg4VXlPSyt0N2VQYVdHcENHYWYrTEFQSWdySm40NFl6enpS?= =?utf-8?B?L0lqYmo5RlNOVWQyQjRTVFFGcnllQWpzWWFJTmtvd1A3aHhoRkNQU29UTXd0?= =?utf-8?B?NXFkTDZzWnlvbDFSVHhsRVo2VGlKSXFyRHg2b0N2QVlvNmVtM2VrSU4rdW9E?= =?utf-8?B?ZGtRVEtjamtCYnpsN2RMTXVXZTAzckRQaUhWODRuaGpWaUpGbzhWbXAyRGU5?= =?utf-8?B?VmZEMERRMWNaQlJXNTMvZEt6bHY5LzVIZWl3RUFJTHVoZGRpWjhHVjRieUNX?= =?utf-8?B?SWcyN3I2SVNGOGVzbVJNc3V2WUt0SnZIRnpESjJYbHdRUzFhVjVaNFlqakJ5?= =?utf-8?B?MlhoajBaSWhoc3lGSnpLZHdRYm5lWWJRNUdoTDRaZ2x6WkpOaDNXM2ZmTk9H?= =?utf-8?B?RW5SOTQyZWdxNytSeGNLZjFEQXFLYmQrQ3RsNGFQcjc0Sm1mb2tWMXhrM1FM?= =?utf-8?B?Qlo1V2J4TlVDaWhrVUdEeVFKSVpsVTc2L1BPbk9RZ0xWQUppbmtGRnI1RzRY?= =?utf-8?B?YWZtT3BLcGcraWQzVEFKVlphZXJ6YWlDTldiUUJBdVA3ZVpBWFpxSUlrcE9Z?= =?utf-8?B?VlhLMUVUUXF5VHQ2Yk92VkRxMzNqajFGM3pweCszYmZHRTc5ZVRFMnJXNklQ?= =?utf-8?B?OU5OR2dJNUZNWjU3dXRManozR25keVdtVWQ1RjZJS2gwdzlaSm83OWxZaWs5?= =?utf-8?B?NnY0ejFUVkF1dWZPR0J2MXJsTkpsRk40VUxZaDdDejViTFlwbTlBS1lRaDNT?= =?utf-8?B?THpTMWlRR1dBMDNYVEpKeUZzcVZZRnJWbnFucG1KbGFFalZGQkRTcmFVUU5o?= =?utf-8?B?WnVlZXc1Z3IvdnpPSjFMUFF1VTZZU1M4RE5MeHl0U2JpUUp6bWx6NWpiek91?= =?utf-8?B?VVg1dWR5OGdvU3V1bmxGWktWMmQvckVCSW01clp4a21xbWNjckRic3laTkFk?= =?utf-8?B?VVRqL1RIdGZrM2QyTHRJajhVdjR1N1VoQzN4b2xaOG1VRkUyWjdPaWNqWHY0?= =?utf-8?B?MkIwYlVYdmdXNkRIYXF1Tm0vL3Y0MS9melRnTStLdlRQdC82ZWg5cHd1aDJz?= =?utf-8?B?TU9JSlVHMWd6MEJLa0dWV21Za3phbER1QTFpUHhhdE9YUHlPYjF4bnJ6S1J3?= =?utf-8?B?QWhsalo1d3AzWlREaDlGUFVCMjY4WllIQzVSL3ZOaTUvY2U1V0IxUVlzMUdn?= =?utf-8?B?akttckpxcDUwc3JydzEvZ2wvOHVLMlQ1UitxM1Q3ek96R2g5a1MySDJUQ3BG?= =?utf-8?B?RW5Ra1pxUENUWnZ5M2piWmFCcndjalJ0R2NMaXhSek03TjRxYjJEakFBZDNP?= =?utf-8?B?cy9uQ2swV2hMaTVVYUlucXBNcDkxejdrS05Xb2RLL1hxOWg4bk0vSVI5UWFD?= =?utf-8?Q?W8nwea0j12UFVnW7v1R+bjgEu?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2318ae6-165b-4f97-e113-08db5319c767 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 18:50:39.7474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SpECNtuzMDutOUk9/C/IE89vcKLuTEqjSE+HLpsZCFzlq5h+cf+hG6Eqfzf1r+VN3N3nWiwUSBgH5GHjJ8KPPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB6103 X-Spam-Status: No, score=-3033.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/12/23 14:44, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> I spotted this explicit call to std::string, which creates an > Simon> unnecessary temporary extra std::string, while calling emplace_back. > Simon> I'm not sure if it has any impact in an optimized build, maybe the > Simon> compiler elides it. But still, it's unnecessary. > > It probably just moves the new string, but I agree it's better with your patch. Thanks, pushed. Simon