From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96123 invoked by alias); 8 Aug 2016 17:28:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96114 invoked by uid 89); 8 Aug 2016 17:28:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=inherited, HContent-Transfer-Encoding:7Bit X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 08 Aug 2016 17:28:46 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C220FB98D; Mon, 8 Aug 2016 13:28:43 -0400 (EDT) From: John Baldwin To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix PR gdb/18653: gdb disturbs inferior's inherited signal dispositions Date: Mon, 08 Aug 2016 17:28:00 -0000 Message-ID: <6289626.ArE7xOzU44@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <86d1ddee-9841-d332-27d5-15c8c185063e@redhat.com> References: <1470332251-10857-1-git-send-email-palves@redhat.com> <86d1ddee-9841-d332-27d5-15c8c185063e@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00104.txt.bz2 On Friday, August 05, 2016 11:56:56 AM Pedro Alves wrote: > On 08/05/2016 02:04 AM, Pedro Alves wrote: > > On 08/04/2016 07:37 PM, John Baldwin wrote: > > > >> Perhaps consider saving/restore the entire 'struct sigaction' instead > >> of just the sa_handler field given you are already requiring sigaction? > > > > Indeed, I think I should, because signal masks are not reset > > at exec time either. Forgot about that. Thanks for suggesting this. > > > > I'll give it a try soon. > > > > Like this? > > I renamed the new files and functions to avoid "disposition" since this > saves/restores more than than now. I also applied a bit more polish to > comments and error handling. Yep. Thanks, looks good to me. -- John Baldwin