Re: [PATCH] gdb: Fix GDB_AC_CHECK_BFD macro regression

[Simon Marchi <simark@simark.ca>]

On 3/7/23 09:21, Richard Purdie via Gdb-patches wrote:
> Commit 5218fa9e8937b007d554f1e01c2e4ecdb9b7e271, "gdb: use libtool in
> GDB_AC_CHECK_BFD" dropped passing in existing LDFLAGS. In our environment,
> this caused the configure check "checking for ELF support in BFD" to stop
> working causing build failures as we need our LDFLAGS to be used for
> correct linking.
> 
> That change also meant the code failed to match the comments. Add back the
> missing LDFLAGS preservation, fix our builds and match the comment.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  gdb/acinclude.m4 | 2 +-
>  gdb/configure    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4
> index 05106df8ee6..173e40b440a 100644
> --- a/gdb/acinclude.m4
> +++ b/gdb/acinclude.m4
> @@ -234,7 +234,7 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
>    # points somewhere with bfd, with -I/foo/lib and -L/foo/lib.  We
>    # always want our bfd.
>    CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
> -  LDFLAGS="-L../bfd -L../libiberty"
> +  LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
>    intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
>    LIBS="-lbfd -liberty $intl $LIBS"
>    CC="./libtool --quiet --mode=link $CC"
> diff --git a/gdb/configure b/gdb/configure
> index 017ec05e4b7..18328fe5d42 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -28323,7 +28323,7 @@ fi
>    # points somewhere with bfd, with -I/foo/lib and -L/foo/lib.  We
>    # always want our bfd.
>    CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
> -  LDFLAGS="-L../bfd -L../libiberty"
> +  LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
>    intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
>    LIBS="-lbfd -liberty $intl $LIBS"
>    CC="./libtool --quiet --mode=link $CC"

This LGTM, but just to be sure, let's wait for Jose to confirm.

Simon