From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=R7oz=6T=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id 69AF73858C00
	for <gdb-patches@sourceware.org>; Thu, 23 Feb 2023 21:34:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69AF73858C00
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 80D3C1E128;
	Thu, 23 Feb 2023 16:34:10 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1677188051; bh=sw3bPwT4KrHgrT0G7pi7XdPiQGYQR6FRQI0Z4PXtQEM=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=aQwTbPNJYV06gE+y0qTmZpt2x/e6zUykOLBTbJupcpyFxVVmIoXxXdcKB7tdpR1Cw
	 +73jwSJbgY2QQ39FlFF4HjUNqizFO0T7CFfndC6jgo1M2k9CucJMPkEc5hIfgZCoFQ
	 xiUDDtwNaaT0s0Vw76T5Xuc+c+ou0Ky1pIcfmVfs=
Message-ID: <62b3feea-91ba-7fbb-1f6d-115902dc9bf6@simark.ca>
Date: Thu, 23 Feb 2023 16:34:10 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] GDB: Fix out of bounds accesses with limited-length
 values
Content-Language: fr
To: "Maciej W. Rozycki" <macro@embecosm.com>, gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>,
 Richard Bunt <Richard.Bunt@arm.com>
References: <alpine.DEB.2.20.2302231218190.15477@tpp.orcam.me.uk>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <alpine.DEB.2.20.2302231218190.15477@tpp.orcam.me.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 2/23/23 16:14, Maciej W. Rozycki wrote:
> Fix accesses to limited-length values in `contents_copy_raw' and 
> `contents_copy_raw_bitwise' so that they observe the limit of the 
> original allocation.
> 
> Reported by Simon Marchi as a heap-buffer-overflow AddressSanitizer 
> issue triggered with gdb.ada/limited-length.exp.
> ---
> Hi,
> 
>  Verified to remove the original issue and not to cause any regressions
> with and w/o AddressSanitizer and native `x86_64-linux-gnu'.  OK to apply?
> 
>   Maciej

Thanks, that LGTM:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon