From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 268A13858D28 for ; Fri, 7 Apr 2023 07:26:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 268A13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 46A9822470; Fri, 7 Apr 2023 07:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680852360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B/9OEuUmwMFtMtGTJGrAVvYno2ojTILJU6dycHiwsX0=; b=GicYWrucs9iAity8XeFHrmt1y5h82noeMwOT8zhMun+3MQ6pIycxYON3jIIT33hoDfRthT svRGWohQegGGmOhaNYzncf4rV4GpsbUCoSd/lJuIBY6jCGrXUTCBxupTVuhfXacWRiPWEd /csx3E25IQmNJg3X5/mm2uM0r7WYoPA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680852360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B/9OEuUmwMFtMtGTJGrAVvYno2ojTILJU6dycHiwsX0=; b=j0UgbMTBf0tzhziu7FjEX/ruThiMAw+IdCom/oZ60qP8Df35z8MjxFB92sgLD41m4Cf75H vtm4dV+LgO5OUjDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 29D62133FE; Fri, 7 Apr 2023 07:26:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8JCDCIjFL2RkbAAAMHmgww (envelope-from ); Fri, 07 Apr 2023 07:26:00 +0000 Message-ID: <62b4adb5-b810-c2a1-8c62-8f2347243971@suse.de> Date: Fri, 7 Apr 2023 09:25:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] [gdb/testsuite] Add -q to INTERNAL_GDBFLAGS To: Simon Marchi , gdb-patches@sourceware.org References: <20230405183410.13468-1-tdevries@suse.de> <8ca29409-2a43-c4a1-ebbe-02ae519b79e4@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <8ca29409-2a43-c4a1-ebbe-02ae519b79e4@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/6/23 02:17, Simon Marchi wrote: > On 4/5/23 14:34, Tom de Vries via Gdb-patches wrote: >> Whenever we start gdb in the testsuite, we have the rather verbose: >> ... >> $ gdb >> GNU gdb (GDB) 14.0.50.20230405-git >> Copyright (C) 2023 Free Software Foundation, Inc. >> License GPLv3+: GNU GPL version 3 or later >> This is free software: you are free to change and redistribute it. >> There is NO WARRANTY, to the extent permitted by law. >> Type "show copying" and "show warranty" for details. >> This GDB was configured as "x86_64-pc-linux-gnu". >> Type "show configuration" for configuration details. >> For bug reporting instructions, please see: >> . >> Find the GDB manual and other documentation resources online at: >> . >> >> For help, type "help". >> Type "apropos word" to search for commands related to "word". >> (gdb) >> ... >> >> This makes gdb.log longer than necessary and harder to read. >> >> We do need to test that the output is produced, but that should be limited to >> one or a few test-cases. >> >> Fix this by adding -q to INTERNAL_GDBFLAGS, such that we simply have: >> ... >> $ gdb -q >> (gdb) > > The license text never really bothered me in gdb.log, when I consult > gdb.log I usually search for some string, so it just skips over that. I see. FWIW, I've always found it a tiny bit annoying, but got triggered to do something about it when playing around with test-case gdb.tui/tui-layout-asm.exp where I tried to reduce tui_asm_window_width to simulate the problem fixed by commit abdd4204a2f ("Fix for gdb.tui/tui-layout-asm.exp") on x86_64, and ran into the paging prompt due to the license text. I'm also working on a patch to use -eiex "set height 0" in INTERNAL_GDBFLAGS to make sure that the paging problem still doesn't happen when we filter out -q from INTERNAL_GDBFLAGS (and while working on that patch I ran into PR30320). > Not having the license text makes it a little less obvious in the log > when gdb has been restarted, so that might be a bit more confusing. Ack, true. For me, the license text takes about half of my screen estate, so I scroll past it often, and it reduces the amount of actual information on my screen. So I guess this is about the balance between small things are hard to spot and large things are hard to ignore. > But > otherwise, I don't really mind your change, I'll get used to it. > OK, thanks for the review, I'll commit shortly. Thanks, - Tom