From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by sourceware.org (Postfix) with ESMTPS id 6AC3C3839824 for ; Fri, 8 Apr 2022 14:33:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6AC3C3839824 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f45.google.com with SMTP id v20-20020a05600c15d400b0038e9a88aee7so2529309wmf.3 for ; Fri, 08 Apr 2022 07:33:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3A5si+t6pQjlIZyjKokQH6kZdCT+a6BfyEcTJsA8Eyg=; b=ZPxjY0lt6keVt75nZDS3VgWaSNyHhFuWVlmZzrXM/Zdi5+hXMPRQ1wJx+yDuesetfF rSWvcGoASHOZcrePlPkTXsBG6OvbynwpqbxS9eR8B+3sEViX3+inym2e3hRVZeTBRbma R+aqeiOig9jQsYi3UGJkASmms4X5tNruY8EKv2RzOwQ2xi1HKTOMTcGxcH5+q+WYYFqQ pUkZdWOU8F+dzMbYQtAFg2eaLcWRbezLepVUVIz29cgx6Sew8fRJifY4MyJJBjwZm3Hh RfyDAScKBl6nh0/9apkMmad4rJK0uBlureCitATgGtpG3YZJuhVGBiIbrQH5L1v5WwJd W4jg== X-Gm-Message-State: AOAM530OlFbFw/214TMzx+3H//N3eH5OWD61swN1xBgYsq2HLGFTYQ0Y sNXuvD8U0emJsjNJnhXbO6kDHyUdQ1E= X-Google-Smtp-Source: ABdhPJw+ZSlSdrm0FsClSS9+yUah2B/M0Lo8q1NTrGI91PPYjfws1GF6kFn/1XMXpQJlj/GYNmvP/Q== X-Received: by 2002:a05:600c:64a:b0:38e:912f:91ee with SMTP id p10-20020a05600c064a00b0038e912f91eemr7775928wmm.192.1649428413132; Fri, 08 Apr 2022 07:33:33 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id n65-20020a1c2744000000b003862bfb509bsm10299780wmn.46.2022.04.08.07.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 07:33:24 -0700 (PDT) Message-ID: <62be5383-59c6-3cc1-033d-8cacd71e908d@palves.net> Date: Fri, 8 Apr 2022 15:33:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: GDB 12.0.90 available for testing Content-Language: en-US To: Tom Tromey , Joel Brobecker via Gdb-patches Cc: Joel Brobecker References: <20220320055815.2A90FA4D6C@takamaka.home> <83v8w0ag5j.fsf@gnu.org> <83tubkadx4.fsf@gnu.org> <87ee28anbg.fsf@tromey.com> <83pmlsc1pj.fsf@gnu.org> <87k0c090o0.fsf@tromey.com> <874k338zkv.fsf@tromey.com> From: Pedro Alves In-Reply-To: <874k338zkv.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 14:33:36 -0000 On 2022-04-08 14:38, Tom Tromey wrote: >>> # The gnulib commit ID to use for the update. >>> -GNULIB_COMMIT_SHA1="776af40e09b476a41073131a90022572f448c189" >>> +GNULIB_COMMIT_SHA1="58c597d13bc57dce3e97ea97856573f2d68ccb8c" >>> >>> # The expected version number for the various auto tools we will >>> # use after the import. > > Joel> Is it just code, or does this update also cause the imports to > Joel> somehow change? The import changes would be the only thing that > Joel> might raise red-flags for me. Other than that, I don't think > Joel> I'd need to see the diff, really. The import process being > Joel> automated IIRC, it's all mechanical, as you say. > > I don't really know how to check this. > I re-ran update-gnulib.sh and it printed the appended module list. > It used to be that the update would tell you what dependencies were new, and which were removed. Either gnulib changed and doesn't print the same helpful info anymore, or the dependencies really didn't change. To be sure, I'd diff the logs of two different re-imports from scratch: - reimport gnulib at the current hash from scratch: rm -rf gnulib/import mkdir gnulib/import/ #to keep our script happy ./update-gnulib.sh .... 2>&1 | tee org - import gnulib at the new hash from scratch: rm -rf gnulib/import mkdir gnulib/import/ #to keep our script happy ./update-gnulib.sh .... 2>&1 | tee new diff org new, look out for new/dropped dependencies, see if we're losing something that we really do no want to lose but missed adding as explicit dependency, check if we gained some new dependency that actually eliminates the need for our own portability code, etc. Regardless, I would suggest that updating is useful to see the dependency updates, and other helpful info, but for final & real update, I'd suggest always reimporting from scratch, to avoid trusting that gnulib's update logic worked as well, that it removed stale files correctly, etc. Pedro Alves