From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 73E783858C01 for ; Wed, 23 Aug 2023 09:24:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73E783858C01 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 55D74302BBEC; Wed, 23 Aug 2023 11:24:17 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 578A3340053; Wed, 23 Aug 2023 11:24:17 +0200 (CEST) Message-ID: <62e6f9f8bf689e8f64b986afaefc4928bde3093a.camel@klomp.org> Subject: Re: [PATCH 07/10] gdb: add qMachineId packet From: Mark Wielaard To: Andrew Burgess , gdb-patches@sourceware.org Cc: Alexandra Petlanova Hajkova Date: Wed, 23 Aug 2023 11:24:17 +0200 In-Reply-To: <94e68e6c1400ede2e9e46fc8ef76bd82aa533e0e.1692200989.git.aburgess@redhat.com> References: <94e68e6c1400ede2e9e46fc8ef76bd82aa533e0e.1692200989.git.aburgess@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=-3034.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andrew, On Wed, 2023-08-16 at 16:55 +0100, Andrew Burgess wrote: > diff --git a/gdbserver/server.cc b/gdbserver/server.cc > index e749194e039..ae40e885e70 100644 > --- a/gdbserver/server.cc > +++ b/gdbserver/server.cc > @@ -51,6 +51,8 @@ > =C2=A0#include "gdbsupport/scoped_restore.h" > =C2=A0#include "gdbsupport/search.h" > =C2=A0 > +#include > + > =C2=A0/* PBUFSIZ must also be at least as big as IPA_CMD_BUF_SIZE, becaus= e > =C2=A0=C2=A0=C2=A0 the client state data is passed directly to some agent > =C2=A0=C2=A0=C2=A0 functions.=C2=A0 */ This include is only available when systemd-devel headers are installed. But it seems not to be used, so can just be removed as far as I can tell. Cheers, Mark