From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 07/11] Re-add zombie leader on exit, gdb/linux
Date: Mon, 7 Mar 2022 15:31:46 -0500 [thread overview]
Message-ID: <63334a7f-86fe-c036-035f-1aafde34f6a7@simark.ca> (raw)
In-Reply-To: <d510d11b-8eeb-c573-ba35-49c89d10ee11@palves.net>
On 2022-03-07 15:27, Pedro Alves wrote:
> Hmm, can you clarify? We're doing this for both WIFEXITED and WIFSIGNALED. The
> WIFSTOPPED case doesn't get here, it's handled in the if/then branch. I do think
> we need to do this for exits due to WIFSIGNALED just the same. Do you think
> otherwise?
Ah I missed the WIFSTOPPED check above. The case I was thinking was "what if we
get a WIFSTOPPED for a deleted zombie leader, that would probably be some problem
in the kernel, we don't want to add it back". And I didn't think about WSIGNALED.
So effectively, I was proposing to have:
else if (WIFSIGNALED (status) || WIFEXITED (status)
instead of an "else". But given that WIFSIGNALED and WIFEXITED are the only
plausible alternatives to WIFSTOPPED, it's not really necessary.
Simon
next prev parent reply other threads:[~2022-03-07 20:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 14:40 [PATCH 00/11] Linux: Fix issues around thread group leader exits Pedro Alves
2022-03-03 14:40 ` [PATCH 01/11] Fix gdbserver/linux target_waitstatus logging assert Pedro Alves
2022-03-03 14:40 ` [PATCH 02/11] Fix gdb.threads/clone-new-thread-event.exp race Pedro Alves
2022-03-03 14:40 ` [PATCH 03/11] Fix gdb.threads/current-lwp-dead.exp race Pedro Alves
2022-03-03 14:40 ` [PATCH 04/11] gdb: Reorganize linux_nat_filter_event Pedro Alves
2022-03-03 14:40 ` [PATCH 05/11] gdbserver: Reorganize linux_process_target::filter_event Pedro Alves
2022-03-03 14:40 ` [PATCH 06/11] gdbserver: Reindent check_zombie_leaders Pedro Alves
2022-03-03 14:40 ` [PATCH 07/11] Re-add zombie leader on exit, gdb/linux Pedro Alves
2022-03-07 20:08 ` Simon Marchi
2022-03-07 20:27 ` Pedro Alves
2022-03-07 20:31 ` Simon Marchi [this message]
2022-03-09 14:37 ` Pedro Alves
2022-03-03 14:40 ` [PATCH 08/11] Re-add zombie leader on exit, gdbserver/linux Pedro Alves
2022-03-03 14:40 ` [PATCH 09/11] Ensure EXIT is last event, gdb/linux Pedro Alves
2022-03-07 20:24 ` Simon Marchi
2022-03-09 0:21 ` Lancelot SIX
2022-03-09 14:45 ` Pedro Alves
2022-03-09 22:29 ` Lancelot SIX
2022-03-10 11:46 ` Pedro Alves
2022-03-03 14:40 ` [PATCH 10/11] Ensure EXIT is last event, gdbserver/linux Pedro Alves
2022-03-03 14:40 ` [PATCH 11/11] Process exit status is leader exit status testcase Pedro Alves
2023-06-22 11:28 ` Ilya Leoshkevich
2023-06-22 13:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63334a7f-86fe-c036-035f-1aafde34f6a7@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).