From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4FA683858D35 for ; Tue, 22 Nov 2022 20:20:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4FA683858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BA0051E0CB; Tue, 22 Nov 2022 15:20:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669148405; bh=KsrkFqEovHhRkoFjua1f22ad/mWGtDwWey+zKdYtpxw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=HNEUMyzUi8xaHv2cQiRxZMLbK/zWxeH6IQ/XXYb7GzmF+BM8kerQC62tN0fPc2Ogg Ld7sOGP84MM3B5bulXLPsHDLp3g0OyFDo7+EQmYpKU7/XUL26AXJalCdt8XxfEG56w OmJyNSuC53yz9EZ7sH53iIUrl3+jnJMXv1SnsO0c= Message-ID: <6383b8c6-c620-5b14-bd48-a53103d383d6@simark.ca> Date: Tue, 22 Nov 2022 15:20:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/5] fbsd-nat: Use regset supply/collect methods. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20220708005816.9408-1-jhb@FreeBSD.org> <20220708005816.9408-3-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20220708005816.9408-3-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/7/22 20:58, John Baldwin wrote: > fbsd-nat includes various helper routines for fetching and storing > register sets via ptrace where the register set is described by a > regset. These helper routines directly invoke the > supply/collect_regset regcache methods which doesn't permit a regset > to provide custom logic when fetching or storing a register set. > Instead, just use the function pointers from the struct regset > directly. > --- > gdb/fbsd-nat.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c > index 281b034b115..9d7383ac0ab 100644 > --- a/gdb/fbsd-nat.c > +++ b/gdb/fbsd-nat.c > @@ -1744,7 +1744,7 @@ fbsd_nat_target::fetch_register_set (struct regcache *regcache, int regnum, > if (ptrace (fetch_op, pid, (PTRACE_TYPE_ARG3) regs, 0) == -1) > perror_with_name (_("Couldn't get registers")); > > - regcache->supply_regset (regset, regnum, regs, size); > + regset->supply_regset (regset, regcache, regnum, regs, size); > return true; > } > return false; > @@ -1768,7 +1768,7 @@ fbsd_nat_target::store_register_set (struct regcache *regcache, int regnum, > if (ptrace (fetch_op, pid, (PTRACE_TYPE_ARG3) regs, 0) == -1) > perror_with_name (_("Couldn't get registers")); > > - regcache->collect_regset (regset, regnum, regs, size); > + regset->collect_regset (regset, regcache, regnum, regs, size); > > if (ptrace (store_op, pid, (PTRACE_TYPE_ARG3) regs, 0) == -1) > perror_with_name (_("Couldn't write registers")); > @@ -1813,7 +1813,7 @@ fbsd_nat_target::fetch_regset (struct regcache *regcache, int regnum, int note, > if (ptrace (PT_GETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) == -1) > perror_with_name (_("Couldn't get registers")); > > - regcache->supply_regset (regset, regnum, regs, size); > + regset->supply_regset (regset, regcache, regnum, regs, size); > return true; > } > return false; > @@ -1838,7 +1838,7 @@ fbsd_nat_target::store_regset (struct regcache *regcache, int regnum, int note, > if (ptrace (PT_GETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) == -1) > perror_with_name (_("Couldn't get registers")); > > - regcache->collect_regset (regset, regnum, regs, size); > + regset->collect_regset (regset, regcache, regnum, regs, size); > > if (ptrace (PT_SETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) == -1) > perror_with_name (_("Couldn't write registers")); > -- > 2.36.1 > Approved-By: Simon Marchi Simon