From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58649 invoked by alias); 24 Sep 2018 02:39:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58638 invoked by uid 89); 24 Sep 2018 02:39:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Sep 2018 02:39:06 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 19ABE1E186; Sun, 23 Sep 2018 22:39:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1537756744; bh=egz/+sazqgpLVtsd2LtbmU7aS6QhKC7GmQ4w17XSMqU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=AqtB3PFJDIgT/XouieX0IQyIPpugnOj0l4zzw3/N6TmN7szNcCF9CHHHqO2rOi30d do9zN/KffOVN5BnGiL7kGioVqRrevfAlbHrlXAws8/h2sY/3Q74xSBPFp2u75W2hkL 75oZ/6fwBEV4ovq5ktRfHbdRj4D27KVpUFDUSFoM= Subject: Re: [PATCH 7/7] Allow setting a parameter to raise gdb.GdbError To: Eli Zaretskii , Tom Tromey Cc: gdb-patches@sourceware.org References: <20180915072459.14934-1-tom@tromey.com> <20180915072459.14934-8-tom@tromey.com> <83va77i0ko.fsf@gnu.org> From: Simon Marchi Message-ID: <6385b06c-ec1a-3e6e-6b81-a4c0f4097556@simark.ca> Date: Mon, 24 Sep 2018 02:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <83va77i0ko.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00793.txt.bz2 On 2018-09-15 5:15 a.m., Eli Zaretskii wrote: >> From: Tom Tromey >> Cc: Tom Tromey >> Date: Sat, 15 Sep 2018 01:24:59 -0600 >> >> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi >> index aca6ec858cf..0487a6f3bf3 100644 >> --- a/gdb/doc/python.texi >> +++ b/gdb/doc/python.texi >> @@ -3824,6 +3824,30 @@ example, @kbd{set foo off}). The @code{value} attribute has already >> been populated with the new value and may be used in output. This >> method must return a string. If the returned string is not empty, >> @value{GDBN} will present it to the user. >> + >> +If this method raises @code{gdb.GdbError} (@pxref{Exception > > "raises the 'gdb.GdbError' exception", I presume? I think that was intentional, I often see it written this way. Here's an example from the Python doc: https://docs.python.org/2/library/string.html#string.index Everything in that series looks reasonable to me, thanks for doing this. Have you tried to run your tests on Python 3 though? I get some failures because long doesn't exist there. Simon