public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: make gdb.arch/amd64-disp-step-avx.exp actually test displaced stepping
Date: Thu, 12 Mar 2020 14:34:14 -0400	[thread overview]
Message-ID: <638bfab4-1f3d-66ab-ac76-d143f50580c0@simark.ca> (raw)
In-Reply-To: <878sk5jv01.fsf@tromey.com>

On 2020-03-12 2:19 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> The test gdb.arch/amd64-disp-step-avx.exp is meant to test that doing a
> Simon> displaced step of an AVX instruction works correctly.  However, I found
> Simon> (by pure coincidence) that the test instructions are not actually
> Simon> displaced stepped.  Rather, they are inline-stepped, so the test is not
> Simon> actually testing what it's meat to test.
> 
> Typo "meat" -> "meant".
> 
> 
> Nice catch here.  I think the patch looks good.
> 
> Tom
> 

Thanks, I pushed it.

Simon

      reply	other threads:[~2020-03-12 18:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 22:21 Simon Marchi
2020-03-12 18:19 ` Tom Tromey
2020-03-12 18:34   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=638bfab4-1f3d-66ab-ac76-d143f50580c0@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).