From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 4C247394743D
 for <gdb-patches@sourceware.org>; Thu, 12 Mar 2020 18:34:15 +0000 (GMT)
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 7ACDC1E4A5;
 Thu, 12 Mar 2020 14:34:14 -0400 (EDT)
Subject: Re: [PATCH] gdb: make gdb.arch/amd64-disp-step-avx.exp actually test
 displaced stepping
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
References: <20200305222108.27194-1-simon.marchi@efficios.com>
 <878sk5jv01.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <638bfab4-1f3d-66ab-ac76-d143f50580c0@simark.ca>
Date: Thu, 12 Mar 2020 14:34:14 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <878sk5jv01.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, SPF_HELO_PASS,
 SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 18:34:16 -0000

On 2020-03-12 2:19 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> The test gdb.arch/amd64-disp-step-avx.exp is meant to test that doing a
> Simon> displaced step of an AVX instruction works correctly.  However, I found
> Simon> (by pure coincidence) that the test instructions are not actually
> Simon> displaced stepped.  Rather, they are inline-stepped, so the test is not
> Simon> actually testing what it's meat to test.
> 
> Typo "meat" -> "meant".
> 
> 
> Nice catch here.  I think the patch looks good.
> 
> Tom
> 

Thanks, I pushed it.

Simon