From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48096 invoked by alias); 18 Jul 2016 16:00:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48083 invoked by uid 89); 18 Jul 2016 16:00:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:FAIL, H*r:0400 X-HELO: mailuogwdur.emc.com Received: from mailuogwdur.emc.com (HELO mailuogwdur.emc.com) (128.221.224.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 18 Jul 2016 16:00:17 +0000 Received: from maildlpprd52.lss.emc.com (maildlpprd52.lss.emc.com [10.106.48.156]) by mailuogwprd51.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id u6IG0B4u029905 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 18 Jul 2016 12:00:13 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com u6IG0B4u029905 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com u6IG0B4u029905 Received: from mailusrhubprd04.lss.emc.com (mailusrhubprd04.lss.emc.com [10.253.24.22]) by maildlpprd52.lss.emc.com (RSA Interceptor); Mon, 18 Jul 2016 11:59:38 -0400 Received: from MXHUB224.corp.emc.com (MXHUB224.corp.emc.com [10.253.68.94]) by mailusrhubprd04.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id u6IFxtGd003646 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=FAIL); Mon, 18 Jul 2016 11:59:55 -0400 Received: from MX203CL03.corp.emc.com ([fe80::4dee:b763:b476:8fbc]) by MXHUB224.corp.emc.com ([10.253.68.94]) with mapi id 14.03.0266.001; Mon, 18 Jul 2016 11:59:54 -0400 From: "taylor, david" To: Eli Zaretskii CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] Add '-at location' support to 'macro expand', 'macro expand-once', 'info macro', 'ptype', and 'whatis' commands. Date: Mon, 18 Jul 2016 16:00:00 -0000 Message-ID: <63F1AEE13FAE864586D589C671A6E18B0685D0@MX203CL03.corp.emc.com> References: <24519.1468851836@usendtaylorx2l> <83oa5v0yo1.fsf@gnu.org> In-Reply-To: <83oa5v0yo1.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Sentrion-Hostname: mailusrhubprd04.lss.emc.com X-RSA-Classifications: public X-SW-Source: 2016-07/txt/msg00194.txt.bz2 > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Eli Zaretskii > > From: David Taylor > > Date: Mon, 18 Jul 2016 10:23:56 -0400 > > > > Add '-at location' support to 'macro expand', 'macro expand-once', 'info > > macro', 'ptype', and 'whatis' commands. >=20 > Thanks. Thank you for taking the time to review the doc parts. > > +it can be any string of tokens. If the optional @var{location} is > > +specified, it is used to determine which macro definitions are in > > +scope; otherwise, as before, it uses the source and line asociated with > > +the current program counter. >=20 > Please lose the "as before" part, it is not appropriate for the > manual, since we always describe the current state of events. Good point. Fixed. > Also, there's a type in "asociated". Fixed. > > +can be any string of tokens. If the optional @var{location} is > > +specified, it is used to determine which macro definitions are in > > +scope; otherwise, as before, it uses the source and line asociated with > > +the current program counter. >=20 > Likewise. Fixed. > > +definition was established. The optional double dash is to signify the > > +end of argument processing and the beginning of @var{macro} for non > > +C-like macros where the macro may begin with a hyphen. If the optional > > +@var{location} is specified, it is used to determine which definition, > > +if any, of the macro is in scope; otherwise, as before, it uses the > > +source and line asociated with the current program counter. >=20 > Likewise. Fixed. > The documentation parts are approved with these fixed. Thanks. I'll repost once the non doc parts are reviewed. > > add_cmd ("expand", no_class, macro_expand_command, _("\ > > Fully expand any C/C++ preprocessor macro invocations in > EXPRESSION.\n\ > > -Show the expanded expression."), > > +Show the expanded expression.\n\ > > +Usage: macro expand [-at LCOATION,] [--] EXPR\n\ > ^^^^^^^^ > Typo. Good catch. Fixed. > > +Options:\n\ > > + -at Use LOCATION rather than the current PC for selecting > macros.\n\ >=20 > "Selecting" sounds not very accurate. Wouldn't "expanding" be better? Changed. Thanks.