From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2062.outbound.protection.outlook.com [40.107.115.62]) by sourceware.org (Postfix) with ESMTPS id 90A9E3858D28 for ; Fri, 22 Dec 2023 15:32:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90A9E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 90A9E3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.62 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703259125; cv=pass; b=jQjWOQ5GbCqKeongoxe9N6YBadzeYMYRks7vg4WKghd6ikgUzSBx/6y7TTM/P27AbT4K1PAPtn4IG7dtP8HYfGkbc2/IRq0rw0jgQD7IKakrCsln7ySJsytcr0lZMmr0SGei9wf0gMniryl92PIuk+OTvWeScwG1V0WAhEGKvsA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703259125; c=relaxed/simple; bh=x/axtZB7cDcdOgGHsMgMelJbdkLObE7qpq0pUKJSm5A=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=hHsgqp9RfboagcM6mcBUSVrL3X/GOyzTYeczMIZdYgd/T7r6tgerMZZiFkQ9GXdWGeUoVY46GShon/VlxqvMjH6mcQuL6+xkRdUx2bce+C+CVJCgKW0IL2sjAAAaytQmnjuqpFd3lqSqCrXleKw2lXSYAZiUfFtHvHfyVjFFEXY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNsIYx9NbiFL452Rb27MLPbXPqRShpI5fQGJC7j1ueQGHXyc3YcGDK7j0Kbzd0VW5fElHX+XddYLO/VAUye8M6b8LR+0o/NNaBDvOGqzrJ/hA+SpTIBJUjsvH4Hn3sfX/mf4a4tKPzxqyv61SKQkeASokoNkKL/X3+z5TQMcKhdTZNKPUb+WYPnsB4lmJHUxtUdpsARDHClCjaw0Ni4Yr27gGyYtbl7M+czm6BzHd4PchbF4Ik71WHxjTcxNN20prB/U3d5SbyurEudOOZCd+mlDn6ILROfKRT00WGvFlWnL8zNCT5LK+uvz2rZ2AZl46Qc570qYOxrVmBO6v7NJkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pKomjQ8xDORpZECOMN/2CDygpZ5JBITAifPcAnMUo44=; b=D2Xc1A2vx2OcmNnr73AeDsi2hyiez3nGaz8v7pmNrCYs4cfXHYYxAN2bMghbMkpNa6Hlnqp7dTDMwRNtT1t92Q5kT25JMw1otTtwOdbpmVx8pLSroUFkYj4+aX0jYVq8enESSlGCZx9Q5yZ0KKA3Tgd+VxXzoi//ADpkAuGDhc5bb3GftN2QhxR9+Mjo7JLIRQUuV0DbKKYC9Bcy2NXU9QGKPr4fEIGfU2CbyhUsFaBwW4BnY7/oh2h8Kc8TUG+/yuK16Or9BqUsMJDFIgz2BXd6CQ+TqtyAc+RDLfF+v+0X+6+fX9Pd0a4KOwQjIEWuEaZjSuvcabaQy0jSa08oZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pKomjQ8xDORpZECOMN/2CDygpZ5JBITAifPcAnMUo44=; b=qghNj1Ey6+Jlm9jUuvKCnQPyn9URL1tO9xJ3Cr6w6UrFhV6tJxyaGCIlX2V08ex19Ep4SesRDDicAbUeCjxSzZNCCOvniShhtdg/uw7PScKF2u1HMwQ8ZQWxtKLEe2WvkSn/nIqvHepoUpWPZd9jzyStaCp2x3ekTiYMxpsUZ8NrjSndi7RrNwAkMJpXuTv+Y9d892qrWsVEpjb+LuZZZZswM0UsyPC5JNUAe9IbJV9hJi5Lpx+iIJRayS1p/xwBGz5kSXGhRALjzam+jcyqVDd475MwZ6wU5wC2zHNDCixQcWoP9xUNbovqZoWrWjSxJs2RNlXn+JVbtfXM8cdV2A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB8134.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:7a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 15:32:01 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7%3]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 15:32:01 +0000 Message-ID: <63be6cf7-011d-4992-bbbc-ba9ac1ef1bc9@efficios.com> Date: Fri, 22 Dec 2023 10:31:59 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/24] gdb: make get_frame_register_bytes take the next frame Content-Language: en-US To: =?UTF-8?Q?K=C3=A9vin_Le_Gouguec?= Cc: gdb-patches@sourceware.org, Luis Machado , John Baldwin , "Aktemur, Tankut Baris" References: <20231201162751.741751-1-simon.marchi@efficios.com> <20231201162751.741751-13-simon.marchi@efficios.com> <87bkaiz7j9.fsf@adacore.com> From: Simon Marchi In-Reply-To: <87bkaiz7j9.fsf@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YQBPR0101CA0247.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:66::29) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB8134:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f23c896-57b2-4b78-47c0-08dc03032480 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UA2DGu4YvL16/DJOTOc6njhVLutszKup2Ht9lOqkV/SA7REigqfBFL1wBHeAJCI7aA8rGx+umwT0orvjNudsqmA1ncjapX1dVdj4GhdTDo5lNkgAnlj7L+vetxP9n8NPQ5c/fdyZeAerp8Wwo2HyvryanhG+qT4WKZyiay/DH4nV3Xq+RSJEDYxNcjUB6i9yR3WlFSKgu60Tu24ZSytSIn3AcmajWNP1Ucu3GekdzoV6zaTu6ofrOyyzkngRgnCu69cXvsx79fLZQ4ugExcailTH+I1aFWjYby2AyJaCBlxhRQGGCerwZyuNXLc5QBekYcTJLWGfHG7VfiA88/CqkZ7zC6hj9rSyM82OLt2Oent5wwrSyI1HGbeHpMGYO6qVQlmPVXuCtouYBcMaxx8sI2+YqBJpjf+Zrcf1jQxlhnic/Bhsqnw0KyMx0Wiuv/R+yj1fxuq7lX7Z6+LSuXXlNN/CmzYlYRQRQdlBPMhLqSnAcUNrfQ/Y9+YS+iyGg87tMFwwebziWnCce8ZdVLHbxNnecdcQRDOTSrN8+6D/7bnK0A0cAhE2wrFkp80wMUwZrN4PCVFuDZAPJqMZUWBxg/A0+/4NmgiaBNzyqHQ/e+IET2b9ha6xJcrff3TQ7dR4Gvz4JS/W0iQUvOXhFsOSVw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(346002)(396003)(366004)(39830400003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(83380400001)(38100700002)(41300700001)(31686004)(31696002)(2616005)(26005)(36756003)(6512007)(6506007)(316002)(478600001)(6486002)(66556008)(6916009)(66946007)(54906003)(66476007)(8676002)(8936002)(4326008)(44832011)(2906002)(4001150100001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amN3SXRZZldpb0d1N2w0bUZPTllHUWQ2UjdjckpUREI5Z1dwcW94OFFadWxs?= =?utf-8?B?eUkyNEhqZjRtSjN1Mmh6elBUM20wWW1yZHZOVDF0ekkyMXBaWEJTVEo1Y2Rs?= =?utf-8?B?Q3dqSnNhRWxXL2lVbHZmS1dIVmoya1JIUDJ3SGlBTEZCcGkxZ0NIZnVBeVRm?= =?utf-8?B?TXZCZHVVdkI3cWl0TWVXSGtFNDFkZDZzVVVYdVUwemlEU3kzNmtDOGd2ODE5?= =?utf-8?B?NFE3cHJvZWl0bmhGOHhKdXdYTW9mVmtHOGVpNGxJYSszWVVYc3NlSXNrQzA2?= =?utf-8?B?aTAxTDFUZW1RNjg1eG1YOWNlbWtNeXhMQWdUY2huKzZyaVdGYW1qN0krYlli?= =?utf-8?B?ckRuVnNNZWc0UU4zMGdXYzM2TVdJNGRUMEdmUWltSmFyNkdQcGlIT1hCb0lM?= =?utf-8?B?OXJVdVlNY3RqeXJuZ3I5SkhRamxNZ3ovTmFORU9UMUlGYkM3UEhrY0JMcGVR?= =?utf-8?B?WkJZVVBCSjdoMW5idFdhTjFSaG93YmRtOEM1VWdxS1V1cFMydmxrbGxSOVEv?= =?utf-8?B?VFVWMml6TXV0cU9oZmpWUFN0MkpFMHpEbzFkOURVcGRJK1RaOCs4LytOTUIr?= =?utf-8?B?QVpId1M2RmtGRUZnVlphdkJFZjJjWUZ3ei8rdkJUdUNtd1h6YzhHMk1ZTXNi?= =?utf-8?B?cDc5b2EycXJ1NnQ1Ukt0RDNwOURDdDJ5eS84Tk0yNjh6Y2pUNE9IdjU3N2x2?= =?utf-8?B?RFVkYzlnUDZtbWhBZWo1TXZtNW53aWczOFBXVVpmN0lBQ3p2YlNPVU9xTWJ1?= =?utf-8?B?NEhLWHVOaHVDWS9HeGRkZVdFbk9KekNZTmdsSmpXL3JVZWZDbWovK3Bnemgr?= =?utf-8?B?amRuSWxIeWFyUFJVdnVBWFFybzBZajJ6R09MOURkazBWR0g4VWhQQlZwamhX?= =?utf-8?B?YnB4UjdlaEdHb0RFMWw2azlheWt5V0JOTVpJUlg2bG52Z1VncnE2SHJZQUZC?= =?utf-8?B?dzE5U1RlTEZIbWVpeU5BSktnaWl3Q0RBZlRDNFhjN0k2Q2ZES1lZd0ZGTVNN?= =?utf-8?B?aG05VDhwUVV1amEzdE82WjdNQ212Nyt5TTRoL1lKRXZiVGpCUVVUdURxYzU2?= =?utf-8?B?U0VnTzlrVWZzbVpFRGZFMTFSWkNTWCtHQVBoUkJwS0VKZ3hpOWZUaWtUUkho?= =?utf-8?B?UStzQlc3cjEwNzhsNStKK3BtemhwbE4reEdON0c1SGttdTJKLzlCVzcvRGxq?= =?utf-8?B?RSs0TFlZVlAvcVFNRkR5TnFvekZBVUdxVS92Q2VJMUdUSjdtSEZVYklhQWxC?= =?utf-8?B?QVJYRjZPeWJhbnliWFM3b3h0OGNDUE9zNStmYzFpMStkMG1yLzdCZExEaUh0?= =?utf-8?B?ZURDRU1hd29ZREVlVjlqOHVCWEhRK0IrU2drVkdOa3RuYUZ0UlFkU1BlSnAx?= =?utf-8?B?MkFHOURlWi9CN05Rc0wrZWMwU2JLbDBhV3FwbVVGSmR5YkV1ci9RWlNDdDBi?= =?utf-8?B?SWtQUmNSVTdIendYdkxzalh5a3d3aDUyUnF0cE5EeDZYdWJGRmxKS3oxUzdL?= =?utf-8?B?aEE5MHMvN1pTbkxjU1VmQndEaS9TcVhJZitLVGF0aXc2WjhaSjdZSk9oWTd3?= =?utf-8?B?SHNua2s2QjhXeGxTK0Y3eTVCemQ1QnV4M2JSSTJ2Qlp2OUFndTVqckRObVlQ?= =?utf-8?B?alhjNnR5UWY2UTMyWDNKWHBRWkdLRlFMRFk3M2V6NFgxMHVRNmZmKzNmSVpZ?= =?utf-8?B?blR0ZnhuVUpSOGN4dFVldm5kM241SVRyL29HR1IrMmNJV1VTN3J6djMzQnVG?= =?utf-8?B?anp0eDFjd0xZWDk4R0drZ0ZNQnhCa1dUQWNEa1pQaUgzcGxXZlB3d0VpQTZ4?= =?utf-8?B?czRxUWNTWXBKKzVIaCtxNTl6bGw3VEhMWTM5aG4rR2NFem1CbVl3L1MzWm5p?= =?utf-8?B?c0ozTGNqL1Nrdm1iU1VmTEdPR3VVTlVibDNhZVJTaWVTNyt1SmRTeUdlKzlZ?= =?utf-8?B?ZEsvRXVCTitnTFF0TVN6K1h0clRyNzI2Mmh5OE5oNW1OdCtxdGU2NzhYRCto?= =?utf-8?B?U1FEMVg2TXpGUG5ZRkVXTlp6MlMycG9Tb1pmWlNMcHhodHM3bmI3NU9QMVZ6?= =?utf-8?B?anBvS1JvNXVVM3k5Y09TdE9idFNrbkQ1cEp0Rkl2dWg1RTE5Z1l6QmptVW9U?= =?utf-8?Q?MZTyiA5v+Bqc0baKpoQ9HMffz?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f23c896-57b2-4b78-47c0-08dc03032480 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 15:32:01.4038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pVw7Qv3f9J7Ius70LKuK0Cb47dRAd9PH4plTa9TrD43NsUBTEQSLSubeqPb6nP0M7jLFLxz9A0DdfvuwVprq8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8134 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kevin, > Should this have been changed to 'next_frame', as the commit message > suggests, and as was done in the other *-tdep.c? Yes, you're right. > > Asking because I'm observing a regression on ppc-linux in our internal > testsuite. I've reproduced that regression with the O2_float_param > testcase: > > cd gdb/testsuite/gdb.ada/O2_float_param > powerpc-linux-gnu-gnatmake foo.adb \ > -cargs -g -O2 -bargs -static -largs -static > scp foo $TARGET: > […gdb…] foo \ > -batch \ > -ex 'tbreak callee.increment' \ > -ex 'target remote | ssh gdbserver - foo' \ > -ex continue > > Expected: > > > Temporary breakpoint 1, callee.increment (val=val@entry=99.0, msg=...) at callee.adb:19 > > Currently, since 2023-12-14 "gdb: make get_frame_register_bytes take the > next frame" (9fc79b42369): > > > Temporary breakpoint 1, callee.increment (val=, val@entry=0.0, msg=...) at callee.adb:19 > > Applying the attached patch gets us the expected output back, and does > not introduce further regressions that I could find. I've tried it on > top of both master and your recently submitted "register value cleanups" > series, <20231221191716.257256-1-simon.marchi@efficios.com>. > > Let me know if I've missed something! Your patch LGTM, thanks for finding and fixing it. Approved-By: Simon Marchi Simon