From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 183693857C71 for ; Thu, 4 Nov 2021 19:51:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 183693857C71 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id C846E3A3F81; Thu, 4 Nov 2021 15:51:30 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Bg6HD7CoITNt; Thu, 4 Nov 2021 15:51:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 7291D3A3D2C; Thu, 4 Nov 2021 15:51:30 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 7291D3A3D2C X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NnEidNKvmv9R; Thu, 4 Nov 2021 15:51:30 -0400 (EDT) Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) by mail.efficios.com (Postfix) with ESMTPSA id 638763A3D2B; Thu, 4 Nov 2021 15:51:30 -0400 (EDT) Message-ID: <63d70020-7f80-f101-3e33-baeae6d3384d@efficios.com> Date: Thu, 4 Nov 2021 15:51:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 5/5] gdb: introduce "set index-cache enabled", deprecate "set index-cache on/off" Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20211101155009.457224-1-simon.marchi@efficios.com> <20211101155009.457224-6-simon.marchi@efficios.com> <878ry3kbtt.fsf@tromey.com> From: Simon Marchi In-Reply-To: <878ry3kbtt.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 19:51:32 -0000 On 2021-11-04 14:36, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> Fix this by introducing "set/show index-cache enabled on/off", regular > Simon> boolean setting commands. Keep commands "set index-cache on" and "set > Simon> index-cache off" as deprecated aliases of "set index-cache enabled", > Simon> with respectively the default arguments "on" and "off". > > This seems fine to me. Thank you. > > Tom > Pushed, thanks. Simon