From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2DE83384DB53 for ; Fri, 15 Dec 2023 15:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DE83384DB53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2DE83384DB53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702655601; cv=none; b=pMrnr9b/W6BG8hbqFREoes6lbaoIkADAwahF5gcd2sKZKKSE4kiDmkTOtl6+pNOYHj1wok8pE8T7GD2pzB8bNod0xorHClNEC0AhOyyHDNSAS70bKS1x/xvOnhOtq/xQ69cim8oljpzYUKZJet3uMJ50TW5+Sel8F+m2bM1Ry5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702655601; c=relaxed/simple; bh=ML0lVB1vZVyukkDCph9KCrQJjKOBFPCc4B8uaGOKWJg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vmUysgbT5/JpG3tmz+PpWLWkjlBJGlsE7wUEzaYeUEPdxaSj3YIwg2etpCFHji41UX/rcGbd6pA2yiu0kQACITD3N3BFFvyTJSmeqccu/kWWxtXWqCc1Y02ADZd99ht527LCqRAXGHz+dnWqC6mlsW7Pflu371zl5BDJn0yVU+A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1702655599; bh=ML0lVB1vZVyukkDCph9KCrQJjKOBFPCc4B8uaGOKWJg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=butpCmst4Bh+xuzCgw9OUohhY7cZOcmUx9ho5L2h+iE7ktbMTAxBKybYScF3QvnKN AskC4ja/EYoztTYMVnSNMh3HwYr2S5XF6XU9G3JpYvTNRilhBoDtvGZJcxxWm+jUcg 7NMBWggv3RSx/2TBWMiyWshi/qnJ2ovnUdTmaXnU= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BD67C1E0AC; Fri, 15 Dec 2023 10:53:19 -0500 (EST) Message-ID: <63d99b56-ae76-4082-9074-1367506eed27@simark.ca> Date: Fri, 15 Dec 2023 10:53:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix two bugs in gdbserver thread name handling Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20231215145928.3396394-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20231215145928.3396394-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/15/23 09:59, Tom Tromey wrote: > Simon pointed out that my earlier patch to gdbserver's thread name > code: > > commit 07b3255c3bae7126a0d679f957788560351eb236 > Author: Tom Tromey > Date: Thu Jul 13 17:28:48 2023 -0600 > > Filter invalid encodings from Linux thread names > > ... introduced a regression. Looking at it, I found another bug as > well. This patch fixes both of them. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31153 My intuition is that the changes make sense, but it would be nice if you could describe the bugs in the commit message, to make sure we're on the same page. Simon