[PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp

[PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp

[Simon Marchi]

This test has a little oversight: the test procedure doesn't actually
use its parameters, the commands and expected patterns are hard-coded,
so we always test with i386:x86-64, instead of with the three arches.
Fix that.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-osabi.exp (test_osabi_none): Use the
	parameters.

Change-Id: Iee2c32963d09e502ae791d5df2b6c04a1f49a57a
---
 gdb/testsuite/gdb.arch/amd64-osabi.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/amd64-osabi.exp b/gdb/testsuite/gdb.arch/amd64-osabi.exp
index 0c435893bfd3..151fa35e8e4c 100644
--- a/gdb/testsuite/gdb.arch/amd64-osabi.exp
+++ b/gdb/testsuite/gdb.arch/amd64-osabi.exp
@@ -24,10 +24,10 @@ if { ![istarget x86_64-*-* ] } {
 proc test_osabi_none { arch void_ptr_size long_double_size } {
     clean_restart
 
-    gdb_test "set architecture i386:x86-64" "The target architecture is set to \"i386:x86-64\"\\."
+    gdb_test "set architecture $arch" "The target architecture is set to \"$arch\"\\."
     gdb_test_no_output "set osabi none" "set osabi none"
-    gdb_test "print sizeof (void*)" " = 8"
-    gdb_test "print sizeof (long double)" " = 16"
+    gdb_test "print sizeof (void*)" " = $void_ptr_size"
+    gdb_test "print sizeof (long double)" " = $long_double_size"
 }
 
 set infos { \
-- 
2.30.1

Re: [PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp

[Andrew Burgess]

* Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-05-10 12:01:52 -0400]:

> This test has a little oversight: the test procedure doesn't actually
> use its parameters, the commands and expected patterns are hard-coded,
> so we always test with i386:x86-64, instead of with the three arches.
> Fix that.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.arch/amd64-osabi.exp (test_osabi_none): Use the
> 	parameters.

LGTM.

Thanks,
Andrew

> 
> Change-Id: Iee2c32963d09e502ae791d5df2b6c04a1f49a57a
> ---
>  gdb/testsuite/gdb.arch/amd64-osabi.exp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.arch/amd64-osabi.exp b/gdb/testsuite/gdb.arch/amd64-osabi.exp
> index 0c435893bfd3..151fa35e8e4c 100644
> --- a/gdb/testsuite/gdb.arch/amd64-osabi.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-osabi.exp
> @@ -24,10 +24,10 @@ if { ![istarget x86_64-*-* ] } {
>  proc test_osabi_none { arch void_ptr_size long_double_size } {
>      clean_restart
>  
> -    gdb_test "set architecture i386:x86-64" "The target architecture is set to \"i386:x86-64\"\\."
> +    gdb_test "set architecture $arch" "The target architecture is set to \"$arch\"\\."
>      gdb_test_no_output "set osabi none" "set osabi none"
> -    gdb_test "print sizeof (void*)" " = 8"
> -    gdb_test "print sizeof (long double)" " = 16"
> +    gdb_test "print sizeof (void*)" " = $void_ptr_size"
> +    gdb_test "print sizeof (long double)" " = $long_double_size"
>  }
>  
>  set infos { \
> -- 
> 2.30.1
> 

Re: [PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp

[Simon Marchi]

> LGTM.
> 
> Thanks,
> Andrew

Thanks, pushed.

Simon