From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F11CF3858284 for ; Thu, 25 Aug 2022 07:51:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F11CF3858284 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-319-ZjxqVGxOO1CKaMuUx6Hdag-1; Thu, 25 Aug 2022 03:51:44 -0400 X-MC-Unique: ZjxqVGxOO1CKaMuUx6Hdag-1 Received: by mail-ed1-f71.google.com with SMTP id x3-20020a05640226c300b00446ad76aeb5so7570944edd.8 for ; Thu, 25 Aug 2022 00:51:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=wKpiZwsYjuAZ8sfV13LMe1unqS2i7LsU35tIc+XSJsM=; b=WQR6iDHuRH9yxU4YPh5vBuvHYR+oMShwOHTKPIZOMoQm64lLdboodJ/wABe2mzh3e2 cU+VUYqy4Dzk+tYKIuK3wFbc9cyn4XhgjExozGDJx+ydTRbq6UYoPm18aRKXASm4w993 9lcWaw7wRQRjCBwcJz05m+RgNTzC8F47nijLPCGXWf8ELLIC2cnD/Owtxv5iIG8sNgkw NcbMZi1UUf8kdL61aIAXYDt0mJkE4H3SoM9uU8B7WNk99c5+NFQhmpu62V84cNpKhs8n hkcP0OvL9nD/EWRYNpCMNJOInIgMk7KWGoBFOYibCRAKh6UsydAVgHjzJVjWMduBOvWg E7cQ== X-Gm-Message-State: ACgBeo2m+wND1ZYaHkJdDWzmlRfPoHiS65xLf8QgX6ENdz2T9kPyUpkd VhdhF7rssYjPc3+wFDuHGS08LhqwB+IhYAcqe7GbnviMXDGpIdq21hoTgBpPlr1+frK2oVKHglR fa9dyO87KUsgbrZM+wP2vNA== X-Received: by 2002:a17:907:75c1:b0:730:aa62:7f65 with SMTP id jl1-20020a17090775c100b00730aa627f65mr1538667ejc.355.1661413902963; Thu, 25 Aug 2022 00:51:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR5qIuIYj97sMq97fMyTK1gQb1okroZbDAlk2Dp5uMg6C3cM8NlHjQxg2MEzoWf+vuMmE/EiFw== X-Received: by 2002:a17:907:75c1:b0:730:aa62:7f65 with SMTP id jl1-20020a17090775c100b00730aa627f65mr1538657ejc.355.1661413902782; Thu, 25 Aug 2022 00:51:42 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b0073d9630cbafsm2042844ejt.126.2022.08.25.00.51.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 00:51:42 -0700 (PDT) Message-ID: <64419112-959f-75b9-3665-2a943e1b39a5@redhat.com> Date: Thu, 25 Aug 2022 09:51:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PINGv3][PATCH v4 00/15] Clean gdb.base when testing with clang To: Bruno Larsen , gdb-patches@sourceware.org References: <20220720194441.168906-1-blarsen@redhat.com> <73fc7290-2168-adcf-b97b-01d81968bcdf@redhat.com> From: Bruno Larsen In-Reply-To: <73fc7290-2168-adcf-b97b-01d81968bcdf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2022 07:51:47 -0000 ping! On 18/08/2022 09:25, Bruno Larsen wrote: > ping 2! > > On 20/07/2022 21:44, Bruno Larsen wrote: >> When testing GDB with clang, gdb.base had over 50 more failures than >> when >> testing with gcc.  Examining the failed tests led to a few clang bugs, a >> few GDB bugs, and many testsuite assumptions that could be changed. >> >> After this patch series, nothing should be changed for testing with gcc, >> and testing with clang should only show non-trivial failures for >> maint.exp and macscp.exp, along with the same GCC failures. >> >> Changes in v4: >>      * Added new test to step through a function's epoligue >>      * renamed gdb_step_until_regexp -> gdb_step_until >>      * small style and wording changes in patches 1 and 2 >>      * Dropped patch 3 - no longer necessary >>      * patch 4 was reworked based on Andrew's suggestion >> small note, Andrew has OK'd patched 5 and 6 (currently 4 and 5) in v3; >> >> Changes in v3: >>      * Fixed some issues that only showed up on CXX_FOR_TARGET=clang >>      * rebased on current master >> >> Changes in v2: >>      * Introduced gdb_step_until_regexp, based on Pedro's and >> Andrew's suggestions >>      * reworked fixes for: skip.exp, skip-solib.exp and msym-bp-shl.exp >>      * Used Pedro's suggestion for call-ar-st >>      * reordered patches slightly >> >> Bruno Larsen (15): >>    gdb/testsuite: introduce gdb_step_until >>    gdb/testsuite: Add a proc to test where compiler links the epilogue >>    Change gdb.base/skip-solib.exp deal with lack of epilogue information >>    gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang >>    update gdb.base/info-program.exp to not fail with clang >>    fix gdb.base/access-mem-running.exp for clang testing >>    Fix gdb.base/call-ar-st to work with Clang >>    add xfails to gdb.base/complex-parts.exp when testing with clang >>    gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang >>    explicitly test for stderr in gdb.base/dprintf.exp >>    gdb/testsuite: Update gdb.base/so-impl-ld.exp >>    [gdb/testsuite]: fix gdb.base/jit-elf.exp when testing with clang >>    gdb/testsuite: fix gdb.base/info-types-c++ with clang >>    gdb.base/skip.exp: Use finish to exit functions >>    gdb/testsuite: Add test to step through function epilogue >> >>   gdb/testsuite/gdb.base/access-mem-running.c   |   2 +- >>   gdb/testsuite/gdb.base/call-ar-st.exp         |  13 ++- >>   gdb/testsuite/gdb.base/complex-parts.exp      |   5 + >>   gdb/testsuite/gdb.base/dprintf.exp            |  10 ++ >>   gdb/testsuite/gdb.base/info-program.exp       |   2 +- >>   gdb/testsuite/gdb.base/info-types.exp.tcl     | 109 ++++++++++++------ >>   gdb/testsuite/gdb.base/jit-elf.exp            |   2 +- >>   gdb/testsuite/gdb.base/msym-bp-shl.exp        |   8 ++ >>   gdb/testsuite/gdb.base/nodebug.exp            |  12 +- >>   gdb/testsuite/gdb.base/skip-inline.exp        |  23 ++-- >>   gdb/testsuite/gdb.base/skip-solib-lib.c       |   3 +- >>   gdb/testsuite/gdb.base/skip-solib-main.c      |   3 +- >>   gdb/testsuite/gdb.base/skip-solib.exp         |  12 +- >>   gdb/testsuite/gdb.base/skip.exp               |  32 +++-- >>   gdb/testsuite/gdb.base/so-impl-ld.exp         |  13 +-- >>   gdb/testsuite/gdb.base/solib1.c               |   5 +- >>   .../gdb.base/step-through-epilogue.c          |  15 +++ >>   .../gdb.base/step-through-epilogue.exp        |  86 ++++++++++++++ >>   gdb/testsuite/lib/gdb.exp                     |  62 ++++++++++ >>   19 files changed, 334 insertions(+), 83 deletions(-) >>   create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.c >>   create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.exp >> -- Cheers, Bruno