[PING^4] [PATCH] Also compare frame_id_is_next in frapy_richcompare

[PING^4] [PATCH] Also compare frame_id_is_next in frapy_richcompare

[Hannes Domani]

Ping.


Am Donnerstag, 21. Januar 2021, 19:07:33 MEZ hat Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben:

> Ping.
>
>
> Am Samstag, 9. Januar 2021, 16:36:13 MEZ hat Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben:
>
> > Ping.
> >
> >
> > Am Samstag, 2. Januar 2021, 14:19:07 MEZ hat Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben:
> >
> > > Ping.
> > >
> > >
> > > Am Freitag, 18. Dezember 2020, 18:25:41 MEZ hat Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben:
> > >
> > > > The last frame in a corrupt stack stores the frame_id of the next frame,
> > > > so these two frames currently compare as equal.
> > > >
> > > > So if you have a backtrace where the oldest frame is corrupt, this happens:
> > > >
> > > > (gdb) py
> > > > >f = gdb.selected_frame()
> > > > >while f.older():
> > > > >  f = f.older()
> > > > >print(f == f.newer())
> > > > >end
> > > > True
> > > >
> > > > With this change, that same example returns False.
> > > >
> > > > gdb/ChangeLog:
> > > >
> > > > 2020-12-18  Hannes Domani  <ssbssa@yahoo.de>
> > > >
> > > >     * python/py-frame.c (frapy_richcompare): Compare frame_id_is_next.
> > > > ---
> > > > gdb/python/py-frame.c | 7 +++++--
> > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c
> > > > index 6b2b29d786..f3086f4bd2 100644
> > > > --- a/gdb/python/py-frame.c
> > > > +++ b/gdb/python/py-frame.c
> > > > @@ -658,8 +658,11 @@ frapy_richcompare (PyObject *self, PyObject *other, int op)
> > > >       return Py_NotImplemented;
> > > >     }
> > > >
> > > > -  if (frame_id_eq (((frame_object *) self)->frame_id,
> > > > -          ((frame_object *) other)->frame_id))
> > > > +  frame_object *self_frame = (frame_object *) self;
> > > > +  frame_object *other_frame = (frame_object *) other;
> > > > +
> > > > +  if (self_frame->frame_id_is_next == other_frame->frame_id_is_next
> > > > +      && frame_id_eq (self_frame->frame_id, other_frame->frame_id))
> > > >     result = Py_EQ;
> > > >   else
> > > >     result = Py_NE;
> > > > --
> > > > 2.29.2

Re: [PING^4] [PATCH] Also compare frame_id_is_next in frapy_richcompare

[Tom Tromey]

>> > > > With this change, that same example returns False.
>> > > >
>> > > > gdb/ChangeLog:
>> > > >
>> > > > 2020-12-18  Hannes Domani  <ssbssa@yahoo.de>
>> > > >
>> > > >     * python/py-frame.c (frapy_richcompare): Compare frame_id_is_next.

This seems reasonable, but is it possible to add a test case for it?

Tom

Re: [PING^4] [PATCH] Also compare frame_id_is_next in frapy_richcompare

[Hannes Domani]

 Am Samstag, 6. Februar 2021, 23:38:18 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:

> >> > > > With this change, that same example returns False.
> >> > > >
> >> > > > gdb/ChangeLog:
> >> > > >
> >> > > > 2020-12-18  Hannes Domani  <ssbssa@yahoo.de>
> >> > > >
> >> > > >     * python/py-frame.c (frapy_richcompare): Compare frame_id_is_next.
>
>
> This seems reasonable, but is it possible to add a test case for it?

I thought about it, but I couldn't figure out how to intentionally create
a corrupt frame.


Hannes

Re: [PING^4] [PATCH] Also compare frame_id_is_next in frapy_richcompare

[Tom Tromey]

>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:

Hannes>  Am Samstag, 6. Februar 2021, 23:38:18 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
>> >> > > > With this change, that same example returns False.
>> >> > > >
>> >> > > > gdb/ChangeLog:
>> >> > > >
>> >> > > > 2020-12-18  Hannes Domani  <ssbssa@yahoo.de>
>> >> > > >
>> >> > > >     * python/py-frame.c (frapy_richcompare): Compare frame_id_is_next.
>> 
>> 
>> This seems reasonable, but is it possible to add a test case for it?

Hannes> I thought about it, but I couldn't figure out how to intentionally create
Hannes> a corrupt frame.

Yeah, that makes sense.  The patch is ok.  Thank you.

Tom

Re: [PING^4] [PATCH] Also compare frame_id_is_next in frapy_richcompare

[Hannes Domani]

 Am Sonntag, 7. Februar 2021, 15:22:48 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:

> >>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes>  Am Samstag, 6. Februar 2021, 23:38:18 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >> >> > > > With this change, that same example returns False.
> >> >> > > >
> >> >> > > > gdb/ChangeLog:
> >> >> > > >
> >> >> > > > 2020-12-18  Hannes Domani  <ssbssa@yahoo.de>
> >> >> > > >
> >> >> > > >     * python/py-frame.c (frapy_richcompare): Compare frame_id_is_next.
> >>
> >>
> >> This seems reasonable, but is it possible to add a test case for it?
>
> Hannes> I thought about it, but I couldn't figure out how to intentionally create
> Hannes> a corrupt frame.
>
> Yeah, that makes sense.  The patch is ok.  Thank you.

Pushed, thanks.


Hannes