From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id EF069384640E for ; Wed, 24 Apr 2024 21:07:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF069384640E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF069384640E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713992877; cv=none; b=RBy6HtEekZKEi96FLWUSLU0cVERjuF4it1xxQjYzbZiY+oEjLhNI4x5a0gfud+Ptpcvy1SQSVmYsTepUElTuETKoOgegOnu2T1s4NQIVgrPur1ismH/qFyVE1PBC9QlufRqCpgYOgND41yyQdXClGkYm8dlAEkomh0UXvvrS5Io= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713992877; c=relaxed/simple; bh=XgdtUizNb+PJkdvfkzxqHidOuQibzW7LLiRAgt1AfVQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=EBfvN1xgxEcHeJ0i9N0w1hpPtLpEpIHG2payef/sRBHe/+kf+/EGACbon54p8yJlO9aXilHZO89UpIP6UoMzd1sybWm7vZb7NAwQ0KVUaCdfbVYCydy3Gi7zskDswpkSujoc9EXmZXFDAZIYpCRjnR6qIN7SgUJxeWV2VO25Z6M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AEB0721B70; Wed, 24 Apr 2024 21:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713992874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMgFDO2ZxZvDkltWtTIxlc9BOsyFb4gw0LZczfYGQTE=; b=z05qZkEHj3goX7mIXYTUvhJZbWkf+0QoOTuW+2dIUlJcVdIlCjquPsYHmOaFusmcIbg2aO YhMxrhYlUu1JTH+/mZxyDLEiPvv/jHNlFuEVIxBOw3myh38a82xm3/8Az9MfzCOTWXmJzF Q3mBnk5I43W0xfvkYyjxoKqEFsHhEqM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713992874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMgFDO2ZxZvDkltWtTIxlc9BOsyFb4gw0LZczfYGQTE=; b=RtDK/Tx5bGTlS1k2OcF4h9ipLYAxluZZYu1XwXJKO9+Kk5zwakszppen8a46wqyeC9/YO3 q203G+RHFabW+EDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=z05qZkEH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="RtDK/Tx5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713992874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMgFDO2ZxZvDkltWtTIxlc9BOsyFb4gw0LZczfYGQTE=; b=z05qZkEHj3goX7mIXYTUvhJZbWkf+0QoOTuW+2dIUlJcVdIlCjquPsYHmOaFusmcIbg2aO YhMxrhYlUu1JTH+/mZxyDLEiPvv/jHNlFuEVIxBOw3myh38a82xm3/8Az9MfzCOTWXmJzF Q3mBnk5I43W0xfvkYyjxoKqEFsHhEqM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713992874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMgFDO2ZxZvDkltWtTIxlc9BOsyFb4gw0LZczfYGQTE=; b=RtDK/Tx5bGTlS1k2OcF4h9ipLYAxluZZYu1XwXJKO9+Kk5zwakszppen8a46wqyeC9/YO3 q203G+RHFabW+EDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 990161393C; Wed, 24 Apr 2024 21:07:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id G2G0I6p0KWajAwAAD6G6ig (envelope-from ); Wed, 24 Apr 2024 21:07:54 +0000 Message-ID: <64b0e2d7-666d-4435-929e-07fcf3bd9cdb@suse.de> Date: Wed, 24 Apr 2024 23:07:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] [gdb/testsuite] Fix end_sequence addresses To: Carl Love , gdb-patches@sourceware.org References: <20240408120445.12544-1-tdevries@suse.de> <20240408120445.12544-3-tdevries@suse.de> <7d515dd6-f327-4587-89c6-ed7e93b7efdd@linux.ibm.com> <8032f800-235f-4181-a84e-2f2fb2a086b7@linux.ibm.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <8032f800-235f-4181-a84e-2f2fb2a086b7@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.50 X-Rspamd-Action: no action X-Rspamd-Queue-Id: AEB0721B70 X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/24/24 20:28, Carl Love wrote: > > Tom: > > The following patch fixes the issue for me on PowerPC. Please let me know if it looks ok and if the patch works on your systems as well. Thanks. > > Carl Hi Carl, I don't see the FAILs you mentioned, but your patch is correct, and doesn't regress the test-case for me on x86_64-linux. Thanks for finding, reporting and fixing this. So, approved, but consider making the commit message shorter. Including the entire commit message of the patch you're fixing is a bit of an overkill. Approved-By: Tom de Vries Thanks, - Tom > > ---------------------------------------------------------------------- > > Fix end_sequence addresses for dw2-lines.exp > > The patch: > > From f0d556d14b1d1c3f8e2f9c13b08adca22e1b8c9c Mon Sep 17 00:00:00 2001 > From: Tom de Vries > Date: Wed, 17 Apr 2024 12:55:00 +0200 > Subject: [PATCH] [gdb/testsuite] Fix end_sequence addresses > > I noticed in test-case gdb.reverse/map-to-same-line.exp, that the end of main: > ... > 00000000004102c4 : > 4102c4: 52800000 mov w0, #0x0 // #0 > 4102c8: 9100c3ff add sp, sp, #0x30 > 4102cc: d65f03c0 ret > ... > is not described by the line table: > ... > File name Line number Starting address View Stmt > ... > map-to-same-line.c 54 0x4102ac x > map-to-same-line.c - 0x4102c4 > ... > > Fix this by ending the line table at $main_end. > > Likewise in a few other test-cases, found using: > ... > $ find gdb/testsuite/ -type f \ > | xargs grep -B1 DW_LNE_end_sequence \ > | grep set_address \ > | egrep -v "_end|_len" > ... > > Tested on aarch64-linux. > --- > gdb/testsuite/gdb.dwarf2/dw2-gas-workaround.exp | 2 +- > gdb/testsuite/gdb.dwarf2/dw2-inline-header-1.exp | 2 +- > gdb/testsuite/gdb.dwarf2/dw2-inline-header-2.exp | 2 +- > gdb/testsuite/gdb.dwarf2/dw2-inline-header-3.exp | 2 +- > gdb/testsuite/gdb.dwarf2/dw2-line-number-zero.exp | 7 +++++-- > gdb/testsuite/gdb.dwarf2/dw2-lines.exp | 2 +- > gdb/testsuite/gdb.dwarf2/dw2-vendor-extended-opcode.exp | 4 +++- > gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp.tcl | 2 +- > gdb/testsuite/gdb.reverse/map-to-same-line.c | 1 - > gdb/testsuite/gdb.reverse/map-to-same-line.exp | 3 ++- > 10 files changed, 16 insertions(+), 11 deletions(-) > > The issue in file dw2-lines.exp is the change > > > - DW_LNE_set_address bar_label_5 > + DW_LNE_set_address "$main_start + $main_len" > > The label bar_label_5 is in function bar, not function main. The new > set address should have been $bar_start + $bar_len. > --- > gdb/testsuite/gdb.dwarf2/dw2-lines.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp > index 85d5e9c8afb..af5b6b71768 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp > @@ -104,7 +104,7 @@ proc test_1 { _cv _cdw64 _lv _ldw64 {_string_form ""}} { > line [line_for bar_label_4] > DW_LNS_copy > > - DW_LNE_set_address "$main_start + $main_len" > + DW_LNE_set_address "$bar_start + $bar_len" > DW_LNE_end_sequence > } > }