From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 89EAE3858D1E; Wed, 17 May 2023 14:35:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89EAE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9B0F21E0D6; Wed, 17 May 2023 10:35:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1684334100; bh=dr6/Q2U+3DVc5CdEdUQvjKE3C2aZG8X07MsecUdWqy4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZRWmZyiLd+5oC5fJb6bloU0oRTWE4Fete/LeAx44xvkyn5nDoJggbZw3aMwnUfsvN I1wxn1xFelgyig2zlFe2fGsg44vsV+dwDDb+0WgP4IahHhJwjrMOk9AGu3Bzo9P7nb M7hxSQNgGyYglGMoUxPA3Rrvd9t2eQ+YHAc5E9O8= Message-ID: <64b12aa0-89e4-c6e7-aeb2-a7f7e2b1aa96@simark.ca> Date: Wed, 17 May 2023 10:35:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS To: Bruno Larsen , Eli Zaretskii Cc: gdb-patches@sourceware.org, gdb@sourceware.org References: <20230516143826.3431583-1-blarsen@redhat.com> <20230516143826.3431583-2-blarsen@redhat.com> <83pm70z2hr.fsf@gnu.org> <83cz30yxox.fsf@gnu.org> <83728fde-a0e8-026b-d4d1-89975ff5ca28@simark.ca> <831qjfzo6n.fsf@gnu.org> <71a08d05-ce55-ec44-2804-13145283ef6b@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <71a08d05-ce55-ec44-2804-13145283ef6b@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > My reading of the kernel's documentation of the tag[1] makes it sound like it is a partial approval, especially the lines: > > | > > Acked-by: is not as formal as Signed-off-by:. It is a record that the acker > has at least reviewed the patch and has indicated acceptance.| > > And the only time I saw it used in QEMU seems to corroborate that reading. That said, I can be misunderstanding here (english is not my native language after all). > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=HEAD#n441 Thanks for the pointers. It looks like Acked-By can fit a range of situations, as long as it fits in "I didn't look at all of it or didn't do a thoroug review, but what I have seen LGTM". I think it fits my use case of just reading the commit message and agreeing with that. Simon