From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de [217.72.192.78]) by sourceware.org (Postfix) with ESMTPS id DADA83858405 for ; Wed, 30 Mar 2022 10:50:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DADA83858405 X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.111.41] ([95.90.135.181]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MUU6E-1nQkRl1Rrc-00QW8R; Wed, 30 Mar 2022 12:50:25 +0200 Message-ID: <64cadd4a-fff4-5988-3f2b-1bee9d3ee0e4@web.de> Date: Wed, 30 Mar 2022 12:50:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 2/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited' Content-Language: en-US To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Andrew Burgess , Simon Marchi , Tom Tromey References: <05e800f2-c119-1675-7465-f3ea3168cb58@web.de> From: Simon Sobisch In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wZvidJJxEZEa6trePipR+o0ojriMsLmfRd2d269ogNpiVO9nud5 KIBdsV6I0euOFc0jWyLxSQBXnUrcDNg62Lxzn4iLXKNMnaB5ULQ0QzCzvfntbMUzrg7v24i PLxa7blX2Xdc5ogdGFp+SVDjAzhxL7JE4eEIuTBUQpSpk1cl4AGHzbtLuwozbpwdvRnvBIO 1KDaP8LAZcmJJAx2eb0kA== X-UI-Out-Filterresults: notjunk:1;V03:K0:OvqqlP5KqhM=:ZYgm4P4RvD2kHjnhpUtb+I qSdiWwh/Aw0UZlAtA7UmZyNvgXNVtycQa4ftuay19a6Y0Ynrez1NR69HqTmNAvvyDXXcl/axQ rkv7JrVAsO8JHWHvI9V8TfszY/QZE8fxVp+wtpzGvqeIc4Aeo8eFD7srLeGs5sVW4UZaJ/YAv rVpkIlFBCWzDXCfXESiVeoawvuyQq5wFtf7vgmks+SXVlzaoaW/YCZ+sxn4ORQQl8vf9QLgcc pq//Qo1yjvsPcPUtdHWK/zYQ6h/o+gA3uhe61Mmu+6IUxXvcPd6UTEmK69ueh7CCdhhl7wFv3 G3DEPIxmPBzGSfBuQe6KkWmkb4FvAm9+bG/k2DzjsenrXNQZdnq+AntpVrUAFdTaE3S9wchLd B5irKOvhE/nCWWYlWgC4hEbRsDfg+y7YwhlwKX5M/SKQ1CRHeNWe0FlBc3Xl5WL1ksmkKSvaU oB9wMebfCueBAwbbSPVHu8LOcjq3OpMGWG2PWt3HMnWBuANUrqVioi2lk5r6s3s9+T/cZoA8z 9Fu31jatInIAGSWeNj/HJDqRn4y54w51kCmYgUlm7LuJh3FsJQk8ZAD+uSJVp1PGhiFkV7koA joMOsD5s8bmLkDA8t+LStPT+26jkitgw5nQdZqNyn+6Hyw2YTZy7c6HaNzVmsyqP7b1OGoOYw 7ivrRNCguUBZdYzunF2UjUi3vmj/BQ8EWzuFOZIOJn/UQD+Mc/shMXrpBW74mZyt9k5Tlf15g bqcWnXQj7Zef2AhCkuXmbWpG04rDVA4jY+ouBJEZFXAswWKzEMeuHtenrdG7MNheY0Ed3kzMM qDpMIY9Z7ktMRfk+Z8crCzl8pUeJkGFoOWCw+Ug21HqGmPC4j8AUPduXJiMphkZ3LC2BcF9GM GIIDNT7pb1T/Pv+dM1UNVrGEAWJib1SQRGDuAe/oA4UM1c3n/MRYEc2PGnkHjLlf5WIFD19kk lIlClwmsH/KgBH2VJTyQM2PH5Bc0vLcDd0CN/lopoQFAMk89I2Kan+55VM4RLjzA6iDhAloiW yuouKGvMpHZGD2o5syGxznB0fZ3YtWPWXpxWcKYoQZLkLF4cf5Y+qsFoiH9xAr6C6NZQaOxJj qhQz7SGoTAv0Pw= X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:50:52 -0000 Am 30.03.2022 um 12:40 schrieb Maciej W. Rozycki: > On Wed, 30 Mar 2022, Simon Sobisch wrote: > >> That seems like it should be mentioned in NEWS as it possibly affects >> existing python extensions (if the commit that was fixed landed in an >> official release). > > Hmm, do we mention bug fixes in NEWS? > > Maciej Should - if it changes the result. When you get a parameter before and it is an integer you can do integer comparisons on it. After the changes it is None and you can't do integer comparisons on it (raises an exception). So if the bug was introduced to have -1 and it is likely that people coded against that: please give them a clue with a note like Python scripting: GDB x introduced a bug where `gdb.Parameter()` returns '-1' for some Parameters when meaning "unlimited", which is now restored to the previous behavior of returning 'None'. This will allow people to watch out for this and adjust their scripts to check for -1, then set to None (if they care for the buggy versions) and compare to "None" in all places. Thanks, Simon