From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29099 invoked by alias); 12 Dec 2019 19:55:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29088 invoked by uid 89); 12 Dec 2019 19:55:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:532, management X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2019 19:55:42 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id xBCJtYZx023141 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Dec 2019 14:55:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca xBCJtYZx023141 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1576180540; bh=mTthi4C2okJogm6wgBFr3D6us7FtW7KEtK0Q+CLcoyY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BqEKBruFAsKqiQTP9NNAZ9tIXEfzXw81QnxHrwamY9uC0f7dD358i6mQrM2zs3f+k /VzFO2EXVEr1Mgj/W0NoCOwOof5CtPaP7DhcmQg4Ec2leLpvAHTTzbh7HuiuuLELi9 tEvSooPUUhy2Kbqb0d9rYz3pqZ8fnFsIR8qdy81Y= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 526D21E573; Thu, 12 Dec 2019 14:55:34 -0500 (EST) Subject: Re: [PATCH 1/2] Replace xmalloc/xfree with vector in jit.c To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20191211063732.1043487-1-simon.marchi@polymtl.ca> <877e315py7.fsf@tromey.com> From: Simon Marchi Message-ID: <6533bf4a-9eea-66f2-55be-248df1828d2e@polymtl.ca> Date: Thu, 12 Dec 2019 19:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <877e315py7.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00538.txt.bz2 On 2019-12-12 2:00 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I'm currently studying that code and noticed this manual memory > Simon> management, which could easily be replaced with a vector, so here it is. > > Simon> gdb/ChangeLog: > > Simon> * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with > Simon> gdb::byte_vector. > > Thanks, this looks good to me. Thanks, I pushed this patch alone. Simon