From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: donb@codesourcery.com
Subject: Re: [PATCHv4 4/5] gdb: Remove out of date comment
Date: Sun, 12 Nov 2017 20:57:00 -0000 [thread overview]
Message-ID: <65430be7-c4da-1eab-5337-ec971a104c64@simark.ca> (raw)
In-Reply-To: <f4b00f078a138b48a2ffd72eb3620400e735710e.1508418720.git.andrew.burgess@embecosm.com>
On 2017-10-19 09:27 AM, Andrew Burgess wrote:
> Comment clean up.
>
> gdb/ChangeLog:
>
> * varobj.c (varobj_create): Remove out of date comment.
> ---
> gdb/ChangeLog | 4 ++++
> gdb/varobj.c | 1 -
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/varobj.c b/gdb/varobj.c
> index 56affc73f0..d8b927ef4f 100644
> --- a/gdb/varobj.c
> +++ b/gdb/varobj.c
> @@ -311,7 +311,6 @@ varobj_create (const char *objname,
> else
> fi = NULL;
>
> - /* frame = -2 means always use selected frame. */
> if (type == USE_SELECTED_FRAME)
> var->root->floating = 1;
>
>
LGTM.
next prev parent reply other threads:[~2017-11-12 20:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 13:27 [PATCHv4 0/5] Fix -var-update for registers in frames 1 and up Andrew Burgess
2017-10-19 13:27 ` [PATCHv4 3/5] gdb: PR mi/20395: " Andrew Burgess
2017-11-12 20:49 ` Simon Marchi
2017-10-19 13:27 ` [PATCHv4 2/5] gdb: New API for tracking innermost block Andrew Burgess
2017-11-12 16:26 ` Simon Marchi
2017-10-19 13:27 ` [PATCHv4 1/5] gdb: Remove duplicate declaration of a function Andrew Burgess
2017-11-12 16:00 ` Simon Marchi
2017-10-19 13:27 ` [PATCHv4 4/5] gdb: Remove out of date comment Andrew Burgess
2017-11-12 20:57 ` Simon Marchi [this message]
2017-10-19 13:27 ` [PATCHv4 5/5] gdb: Don't store a thread-id for floating varobj Andrew Burgess
2017-11-12 21:00 ` Simon Marchi
2018-01-02 15:31 ` [PATCHv5 0/5] Fix -var-update for registers in frames 1 and up Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 2/5] gdb: New API for tracking innermost block Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 3/5] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up Andrew Burgess
2018-01-21 0:45 ` Pedro Alves
2018-01-20 21:34 ` [PATCHv6 1/5] gdb: Remove duplicate declaration of global innermost_block Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 5/5] gdb: Don't store a thread-id for floating varobj Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 0/5] Fix -var-update for registers in frames 1 and up Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 4/5] gdb: Remove out of date comment Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 " Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 3/5] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up Andrew Burgess
2018-01-16 16:34 ` Pedro Alves
2018-01-02 15:32 ` [PATCHv5 5/5] gdb: Don't store a thread-id for floating varobj Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 2/5] gdb: New API for tracking innermost block Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 1/5] gdb: Remove duplicate declaration of global innermost_block Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65430be7-c4da-1eab-5337-ec971a104c64@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).